fixing misc lint errors

Author: Mzack9999

.golangci.yml

@@ -41,8 +41,6 @@ linters-settings:
           - (github.com/golangci/golangci-lint/pkg/logutils.Log).Fatalf
   # lll:
   #   line-length: 140
-  maligned:
-    suggest-new: true
   misspell:
     locale: US
   nolintlint:
@@ -73,14 +71,12 @@ linters:
     - gosimple
     - govet
     - ineffassign
-    - interfacer
-    - maligned
     - misspell
     - nakedret
     - noctx
     - nolintlint
     - rowserrcheck
-    - scopelint
+    - exportloopref
     - staticcheck
     - structcheck
     - stylecheck

cmd/simplehttpserver/simplehttpserver.go

@@ -16,5 +16,5 @@ func main() {
 	if err := r.Run(); err != nil {
 		gologger.Info().Msgf("%s\n", err)
 	}
-	defer r.Close()
+	defer r.Close() //nolint
 }

internal/runner/options.go

@@ -95,10 +95,10 @@ func (options *Options) configureOutput() {
 }
 
 // FolderAbsPath of the fileserver folder
-func (o *Options) FolderAbsPath() string {
-	abspath, err := filepath.Abs(o.Folder)
+func (options *Options) FolderAbsPath() string {
+	abspath, err := filepath.Abs(options.Folder)
 	if err != nil {
-		return o.Folder
+		return options.Folder
 	}
 	return abspath
 }

internal/runner/runner.go

@@ -28,7 +28,7 @@ func New(options *Options) (*Runner, error) {
 	}
 
 	if r.options.EnableTCP {
-		serverTCP, err := tcpserver.New(tcpserver.Options{
+		serverTCP, err := tcpserver.New(&tcpserver.Options{
 			Listen:  r.options.ListenAddress,
 			TLS:     r.options.TCPWithTLS,
 			Domain:  "local.host",

pkg/binder/binder.go

@@ -33,5 +33,4 @@ func GetRandomListenAddress(currentAddress string) (string, error) {
 	}
 
 	return net.JoinHostPort(addrOrig, fmt.Sprintf("%d", newPort)), nil
-
 }

pkg/tcpserver/tcpserver.go

@@ -11,6 +11,8 @@ import (
 	"gopkg.in/yaml.v2"
 )
 
+const readTimeout = 5
+
 // Options of the tcp server
 type Options struct {
 	Listen      string
@@ -24,12 +26,12 @@ type Options struct {
 
 // TCPServer instance
 type TCPServer struct {
-	options  Options
+	options  *Options
 	listener net.Listener
 }
 
 // New tcp server instance with specified options
-func New(options Options) (*TCPServer, error) {
+func New(options *Options) (*TCPServer, error) {
 	return &TCPServer{options: options}, nil
 }
 
@@ -50,11 +52,11 @@ func (t *TCPServer) ListenAndServe() error {
 }
 
 func (t *TCPServer) handleConnection(conn net.Conn) error {
-	defer conn.Close()
+	defer conn.Close() //nolint
 
 	buf := make([]byte, 4096)
 	for {
-		if err := conn.SetReadDeadline(time.Now().Add(time.Duration(5 * time.Second))); err != nil {
+		if err := conn.SetReadDeadline(time.Now().Add(readTimeout * time.Second)); err != nil {
 			gologger.Info().Msgf("%s\n", err)
 		}
 		_, err := conn.Read(buf)
@@ -77,7 +79,7 @@ func (t *TCPServer) handleConnection(conn net.Conn) error {
 	}
 }
 
-// ListenAndServe requests over tls
+// ListenAndServeTLS requests over tls
 func (t *TCPServer) ListenAndServeTLS() error {
 	var tlsConfig *tls.Config
 	if t.options.Certificate != "" && t.options.Key != "" {