-
Notifications
You must be signed in to change notification settings - Fork 59
RHOAIENG-39075: Add new E2E test structure and initial existing cluster test #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-39075: Add new E2E test structure and initial existing cluster test #948
Conversation
|
@kryanbeane: This pull request references RHOAIENG-39075 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
6f56f55 to
5376b68
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #948 +/- ##
==========================================
- Coverage 94.21% 94.08% -0.14%
==========================================
Files 24 24
Lines 2128 2130 +2
==========================================
- Hits 2005 2004 -1
- Misses 123 126 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/hold |
laurafitzgerald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kryanbeane a few comments inline. Overall the change looks good. I didn't review the utils files in anger but please let me know if i should. This gives us a great structure going forward for adding the additional testing. Will those be done in seperate prs?
Yep separate PRs. This PR is mostly to decide on structure. Pawel pointed out we never got rid of AppWrapper, so I'll follow up with that PR. Then I'll create new versions of our old tests in this new layout, last will be adding additional tests |
5376b68 to
955c37f
Compare
955c37f to
e9935db
Compare
|
/unhold |
pawelpaszki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving. Once all the new tests are in place we will need to thoroughly test them before marking them with Quality Gates (e.g. smoke, tier1, pre_upgrade/ post_upgrade)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pawelpaszki The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3417529
into
project-codeflare:main
Issue link
https://issues.redhat.com/browse/RHOAIENG-39075
What changes have been made
Added new E2E directory structure
Verification steps
N/A
Checks