Skip to content

Conversation

@kryanbeane
Copy link
Contributor

Issue link

https://issues.redhat.com/browse/RHOAIENG-39075

What changes have been made

Added new E2E directory structure

Verification steps

N/A

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 28, 2025

@kryanbeane: This pull request references RHOAIENG-39075 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Issue link

https://issues.redhat.com/browse/RHOAIENG-39075

What changes have been made

Added new E2E directory structure

Verification steps

N/A

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.08%. Comparing base (b713531) to head (e9935db).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #948      +/-   ##
==========================================
- Coverage   94.21%   94.08%   -0.14%     
==========================================
  Files          24       24              
  Lines        2128     2130       +2     
==========================================
- Hits         2005     2004       -1     
- Misses        123      126       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 28, 2025
@kryanbeane
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2025
Copy link
Contributor

@laurafitzgerald laurafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kryanbeane a few comments inline. Overall the change looks good. I didn't review the utils files in anger but please let me know if i should. This gives us a great structure going forward for adding the additional testing. Will those be done in seperate prs?

@kryanbeane
Copy link
Contributor Author

Hi @kryanbeane a few comments inline. Overall the change looks good. I didn't review the utils files in anger but please let me know if i should. This gives us a great structure going forward for adding the additional testing. Will those be done in seperate prs?

Yep separate PRs. This PR is mostly to decide on structure. Pawel pointed out we never got rid of AppWrapper, so I'll follow up with that PR. Then I'll create new versions of our old tests in this new layout, last will be adding additional tests

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2025
@kryanbeane
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2025
Copy link
Contributor

@pawelpaszki pawelpaszki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving. Once all the new tests are in place we will need to thoroughly test them before marking them with Quality Gates (e.g. smoke, tier1, pre_upgrade/ post_upgrade)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pawelpaszki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3417529 into project-codeflare:main Dec 1, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants