fix: Application Logs in non-follow mode incorrectly render newlines

starpit · starpit · commit e1eb246428b3 · 2022-07-05T09:56:47.000-04:00
diff --git a/plugins/plugin-codeflare/src/components/Terminal.tsx b/plugins/plugin-codeflare/src/components/Terminal.tsx
@@ -97,8 +97,8 @@ export default class XTerm extends React.PureComponent<Props, State> {
 
     if (this.props.initialContent) {
       // @starpit i don't know why we have to split the newlines...
-      //this.props.initialContent.split(/\n/).forEach(this.writeln)
-      this.terminal.write(this.props.initialContent)
+      this.props.initialContent.split(/\n/).forEach((line) => this.terminal.writeln(line))
+      // this.terminal.write(this.props.initialContent)
     }
 
     this.terminal.open(xtermContainer)

Original file line number	Diff line number	Diff line change
`@@ -97,8 +97,8 @@ export default class XTerm extends React.PureComponent<Props, State> {`
`97`	`97`
`98`	`98`	`if (this.props.initialContent) {`
`99`	`99`	`// @starpit i don't know why we have to split the newlines...`
`100`		`- //this.props.initialContent.split(/\n/).forEach(this.writeln)`
`101`		`- this.terminal.write(this.props.initialContent)`
	`100`	`+ this.props.initialContent.split(/\n/).forEach((line) => this.terminal.writeln(line))`
	`101`	`+ // this.terminal.write(this.props.initialContent)`
`102`	`102`	`}`
`103`	`103`
`104`	`104`	`this.terminal.open(xtermContainer)`