Skip to content

Commit cda8d2b

Browse files
committed
fix: tray dashboard popups should be in follow mode
for now, at least. it would be nice if we could detect whether a job is running, and only follow running jobs... until we have that kind of capability, we need to follow everything...
1 parent ee65e37 commit cda8d2b

File tree

1 file changed

+3
-1
lines changed
  • plugins/plugin-codeflare/src/tray/menus/profiles/dashboards

1 file changed

+3
-1
lines changed

plugins/plugin-codeflare/src/tray/menus/profiles/dashboards/codeflare.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,9 @@ import windowOptions from "../../../window"
2727
function openRunInCodeflareDashboard(createWindow: CreateWindowFunction, profile: string, runId: string) {
2828
const runsDir = Profiles.guidebookJobDataPath({ profile })
2929
createWindow(
30-
["codeflare", "dashboard", join(runsDir, runId)],
30+
// TODO -f: follow by default. should we be smarter, and detect
31+
// which -runs are in a non-RUNNING state, and don't follow those?
32+
["codeflare", "dashboard", "-f", join(runsDir, runId)],
3133
windowOptions({ title: "CodeFlare Dashboard - " + runId })
3234
)
3335
}

0 commit comments

Comments
 (0)