Skip to content

Commit b672b8d

Browse files
committed
fix: move dashboard charts to lower left
1 parent 1d665eb commit b672b8d

File tree

5 files changed

+23
-21
lines changed

5 files changed

+23
-21
lines changed

plugins/plugin-codeflare/src/components/Chart.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ interface Props {
6464
}
6565

6666
export default class BaseChart extends React.PureComponent<Props> {
67-
private static fontSize = 7
67+
private static fontSize = 8
6868
private static tickLabelFontSize = BaseChart.fontSize - 1
6969

7070
private static readonly dimensions = {

plugins/plugin-codeflare/src/components/Description.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ const Description = (props: Props) => {
3535
const { summaryData } = props
3636

3737
return (
38-
<DescriptionList>
38+
<DescriptionList isHorizontal isAutoColumnWidths isFluid>
3939
{summaryData.map(({ label, value }, index) => (
4040
<DescriptionListGroup key={index}>
4141
<DescriptionListTerm>{label}</DescriptionListTerm>

plugins/plugin-codeflare/web/scss/components/Dashboard/Charts.scss

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,13 @@
1717
@import "mixins";
1818

1919
@include ChartGrid {
20+
$gap: 0.6875em;
21+
2022
display: grid;
21-
grid-gap: 0.6875em;
22-
padding: 2em;
23-
grid-template-columns: repeat(4, 1fr);
24-
grid-auto-rows: minmax(300px, max-content);
23+
grid-gap: $gap;
24+
padding: $gap;
25+
grid-template-columns: repeat(2, 1fr);
26+
grid-auto-rows: minmax(250px, max-content);
2527

2628
font-family: var(--font-sans-serif);
2729
}

plugins/plugin-codeflare/web/scss/components/Dashboard/Description.scss

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,20 +20,25 @@
2020
dd {
2121
margin: 0;
2222
}
23+
.pf-c-description-list__description {
24+
font-weight: 300;
25+
color: var(--color-text-02);
26+
}
2327
.pf-c-description-list {
2428
font-family: var(--font-sans-serif);
25-
grid-template-columns: 1fr;
2629
padding: 0 1em;
2730
}
31+
32+
/* for vertical layout
33+
.pf-c-description-list {
34+
grid-template-columns: 1fr;
35+
}
2836
.pf-c-description-list__group {
2937
grid-template-columns: 1fr;
3038
}
3139
.pf-c-description-list__term,
3240
.pf-c-description-list__description {
3341
grid-column-start: unset;
3442
}
35-
.pf-c-description-list__description {
36-
font-weight: 300;
37-
color: var(--color-text-02);
38-
}
43+
*/
3944
}

plugins/plugin-codeflare/web/scss/components/Dashboard/_index.scss

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,17 +29,12 @@
2929

3030
@include TopLevelTab {
3131
@include Split(3) {
32-
/* @include Rows(7); */
33-
@include Columns(13);
34-
grid-template-rows: repeat(3, 10vmax) repeat(4, auto);
32+
grid-template-rows: 200px 1fr;
33+
grid-template-columns: repeat(4, minmax(100px, 200px)) repeat(9, minmax(150px, auto));
34+
3535
grid-template-areas:
36-
"T1 T1 T1 T3 T3 T3 T3 T3 T3 T3 T3 T3 T3"
37-
"T1 T1 T1 T3 T3 T3 T3 T3 T3 T3 T3 T3 T3"
38-
"T1 T1 T1 T3 T3 T3 T3 T3 T3 T3 T3 T3 T3"
39-
"T1 T1 T1 T2 T2 T2 T2 T2 T2 T2 T2 T2 T2"
40-
"T1 T1 T1 T2 T2 T2 T2 T2 T2 T2 T2 T2 T2"
41-
"T1 T1 T1 T2 T2 T2 T2 T2 T2 T2 T2 T2 T2"
42-
"T1 T1 T1 T2 T2 T2 T2 T2 T2 T2 T2 T2 T2";
36+
"T1 T1 T1 T1 T1 T1 T1 T1 T1 T1 T1 T1 T1"
37+
"T3 T3 T3 T3 T2 T2 T2 T2 T2 T2 T2 T2 T2";
4338
}
4439
}
4540

0 commit comments

Comments
 (0)