chore: cleanup of the "hello" window code and components and scss

Rename "welcome" to "hello"

Author: starpit

plugins/plugin-client-default/notebooks/welcome.md renamed to plugins/plugin-client-default/notebooks/hello.md

@@ -8,38 +8,32 @@ layout:
     2: 
         position: default
         maximized: true
-    3: 
-        position: default
-        maximized: true
         inverseColors: true
 ---
 
-<img alt="CodeFlare Icon" src="@kui-shell/client/icons/svg/codeflare.svg" width="80" height="80" />
-
----
-
-<!-- TODO find some content to place here? -->
+<!-- <img alt="CodeFlare Icon" src="@kui-shell/client/icons/svg/codeflare.svg" width="80" height="80" /> -->
 
----
-
-=== "Job Runs"
+=== "Profiles"
 
     ```shell
     ---
     execute: now
     maximize: true
     outputOnly: true
     ---
-    codeflare get run
+    codeflare get profile
     ```
 
-=== "Profiles"
+---
+
+=== "Job Runs"
 
     ```shell
     ---
     execute: now
     maximize: true
     outputOnly: true
     ---
-    codeflare get profile
+    codeflare get run
     ```
+

plugins/plugin-client-default/src/index.tsx

@@ -26,8 +26,6 @@ import { productTitle } from "@kui-shell/client/config.d/name.json"
 
 import CodeFlareWidget from "./CodeFlareWidget"
 
-import "../web/scss/guidebooks/welcome.scss"
-
 /**
  * We will set this bit when the user dismisses the Welcome to Kui
  * tab, so as to avoid opening it again and bothering that user for

plugins/plugin-client-default/web/scss/guidebooks/welcome.scss renamed to plugins/plugin-codeflare/src/controller/hello.ts

@@ -14,15 +14,10 @@
  * limitations under the License.
  */
 
-@import "@kui-shell/plugin-client-common/web/scss/components/Terminal/mixins";
-@import "@kui-shell/plugin-client-common/web/scss/components/TopLevelTab/mixins";
+import { Arguments } from "@kui-shell/core"
 
-@include TopLevelTab {
-  &.codeflare--welcome-guidebook {
-    @include Split(3) {
-      grid-template-rows: 80px 1fr;
-      grid-template-columns: 80px 1fr;
-      grid-template-areas: "T1 T2" "T3 T3";
-    }
-  }
+import "../../web/scss/components/Hello/_index.scss"
+
+export default function hello(args: Arguments) {
+  return args.REPL.qexec("commentary --readonly -f /kui/client/hello.md")
 }

plugins/plugin-codeflare/src/controller/index.ts

@@ -47,7 +47,7 @@ export default function registerCodeflareCommands(registrar: Registrar) {
   registrar.listen("/codeflare/get/run", (args) => import("./run/get").then((_) => _.default(args)), { needsUI: true })
 
   // launch our hello guidebook
-  registrar.listen("/codeflare/hello", (args) => args.REPL.qexec("commentary --readonly -f /kui/client/welcome.md"), {
+  registrar.listen("/codeflare/hello", (args) => import("./hello").then((_) => _.default(args)), {
     needsUI: true,
     outputOnly: true,
   })

plugins/plugin-codeflare/src/controller/profile/get.tsx

@@ -19,8 +19,6 @@ import { Profiles } from "madwizard"
 import { Arguments } from "@kui-shell/core"
 import { Grid, GridItem, Tile } from "@patternfly/react-core"
 
-import "../../../web/scss/components/Welcome/_index.scss"
-
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
 export default async function getProfiles(args: Arguments) {
   const profiles = await Profiles.list({})
@@ -30,7 +28,7 @@ export default async function getProfiles(args: Arguments) {
       <Grid hasGutter className="codeflare--grid">
         {profiles.map((_) => (
           <GridItem key={_.profile.name}>
-            <Tile className="codeflare--tile" title={_.profile.name} />
+            <Tile isSelected className="codeflare--tile" title={_.profile.name} />
           </GridItem>
         ))}
       </Grid>

plugins/plugin-codeflare/src/controller/run/get.tsx

@@ -24,8 +24,6 @@ import { Arguments, ReactResponse } from "@kui-shell/core"
 import { width, height } from "../dashboard"
 import { getJobDefinition } from "../description"
 
-import "../../../web/scss/components/Welcome/_index.scss"
-
 async function openDashboard(this: Arguments["REPL"], evt: React.MouseEvent<HTMLDivElement>) {
   const runDir = evt.currentTarget.getAttribute("data-run-dir")
   if (runDir) {

plugins/plugin-codeflare/web/scss/components/Welcome/_index.scss renamed to plugins/plugin-codeflare/web/scss/components/Hello/_index.scss

@@ -14,10 +14,24 @@
  * limitations under the License.
  */
 
+@import "@kui-shell/plugin-client-common/web/scss/components/Terminal/mixins";
+@import "@kui-shell/plugin-client-common/web/scss/components/TopLevelTab/mixins";
+
+@include TopLevelTab {
+  &.codeflare--welcome-guidebook {
+    @include Split(2) {
+      grid-template-rows: 1fr;
+      grid-template-columns: 1fr 4fr;
+      grid-template-areas: "T1 T2";
+    }
+  }
+}
+
 $gap: 3px;
+$cell: 1.5em;
 
 @mixin Grid {
-  .codeflare--grid {
+  .pf-l-grid.codeflare--grid {
     @content;
   }
 }
@@ -39,13 +53,14 @@ $gap: 3px;
   padding: 1em;
   flex: 1;
   grid-auto-rows: max-content;
-  grid-template-columns: repeat(auto-fit, minmax(25px, max-content));
+  grid-template-columns: repeat(auto-fit, $cell);
 }
 
 @include Mini {
-  grid-gap: 2 * $gap;
+  grid-gap: $gap;
   @include Tile {
     padding: $gap;
+    height: $cell;
   }
 }
 
@@ -81,5 +96,5 @@ $gap: 3px;
 
 .pf-c-tile__title {
   color: var(--color-tile-title);
-  font-weight: 500;
+  font-size: 0.6875rem;
 }