fix: updates to restore self-test capability vs private repos

Author: starpit

deploy/self-test/Dockerfile

@@ -3,6 +3,11 @@ FROM node:lts-bullseye-slim
 LABEL org.opencontainers.image.source https://github.com/project-codeflare/codeflare-cli
 
 ENV DEBIAN_FRONTEND=noninteractive
+
+RUN apt update && apt -y install sudo curl python3 python3-pip git \
+        && pip3 install --no-cache-dir  -U pip && pip3 install --no-cache-dir -U setuptools \
+        && apt -y clean && rm -rf /var/lib/apt/lists/*
+
 ENV KUI_HEADLESS=true
 ENV KUI_HEADLESS_WEBPACK=true
 ENV NO_KIND=true
@@ -13,10 +18,7 @@ ADD dist/headless /usr/local/CodeFlare
 ADD bin/codeflare /usr/local/bin/codeflare
 ADD node_modules/@guidebooks/store/dist/store /usr/local/CodeFlare/store
 
-RUN apt update && apt -y install sudo curl python3 python3-pip git \
-        && pip3 install --no-cache-dir  -U pip && pip3 install --no-cache-dir -U setuptools \
-        && apt -y clean && rm -rf /var/lib/apt/lists/* \
-        && codeflare -n util/jq \
+RUN codeflare -n util/jq \
         && codeflare -n util/websocat \
         && codeflare -n ml/ray/install/cli \
         && codeflare -n openshift/oc \

deploy/self-test/roberta/1gpu/once.yaml

@@ -47,9 +47,19 @@ spec:
   template:
     spec:
       serviceAccountName: codeflare-self-test-serviceaccount
+      volumes:
+        - name: ssh-key
+          secret:
+            secretName: github
+            defaultMode: 0600
+            optional: true
       containers:
       - name: self-test
         image: ghcr.io/project-codeflare/codeflare-self-test:0.11.3
+        volumeMounts:
+          - mountPath: "/tmp/github/"
+            name: ssh-key
+            readOnly: true
         env:
           # - name: GUIDEBOOK_RUN_ARGS
           #  value: "-V"
@@ -76,11 +86,13 @@ spec:
               secretKeyRef:
                 name: github
                 key: GITHUB_USER
+                optional: true
           - name: ML_CODEFLARE_ROBERTA_GITHUB_TOKEN
             valueFrom:
               secretKeyRef:
                 name: github
                 key: GITHUB_TOKEN
+                optional: true
           - name: MODE
             value: development # otherwise building codeflare-cli takes a huge amount of memory
           - name: KUBE_CONTEXT_FOR_TEST

deploy/self-test/roberta/1gpu/periodic.yaml

@@ -51,9 +51,19 @@ spec:
       template:
         spec:
           serviceAccountName: codeflare-self-test-serviceaccount
+          volumes:
+            - name: ssh-key
+              secret:
+                secretName: github
+                defaultMode: 0600
+                optional: true
           containers:
           - name: self-test
             image: ghcr.io/project-codeflare/codeflare-self-test:0.11.3
+            volumeMounts:
+              - mountPath: "/tmp/github/"
+                name: ssh-key
+                readOnly: true
             env:
               # - name: GUIDEBOOK_RUN_ARGS
               #  value: "-V"

deploy/self-test/self-test.sh

@@ -25,7 +25,7 @@ function cleanup {
             ICON=":green_heart:"
             TEXT="$(date)\nSuccessful run\nVariants: $variants"
         else
-            ICON=":red-siren:"
+            ICON=":fail:"
             TEXT="$(date)\nFailed run\nVariants: $variants"
             # TODO, add tee'd logs of failing run
         fi

package-lock.json

@@ -24,6 +24,6 @@
   },
   "dependencies": {
     "madwizard": "^0.21.5",
-    "@guidebooks/store": "^0.8.3"
+    "@guidebooks/store": "^0.9.0"
   }
 }