chore: refactor madwizard-specific logic and ui into plugin-madwizard

Author: starpit

package-lock.json

@@ -13,5 +13,5 @@ execute: now
 outputOnly: true
 maximize: true
 ---
-codeflare designer
+madwizard designer
 ```

plugins/plugin-client-default/notebooks/hello.md

@@ -28,7 +28,6 @@
     "@patternfly/react-core": "^4.267.6",
     "allotment": "^1.17.1",
     "asciinema-player": "^3.0.1",
-    "chalk": "^5.2.0",
     "chokidar": "^3.5.3",
     "json-diff": "^1.0.0",
     "needle": "^3.2.0",

plugins/plugin-codeflare/package.json

@@ -15,7 +15,7 @@
  */
 
 import React from "react"
-import { openWindow } from "../controller/profile/actions"
+import { openWindow } from "@kui-shell/plugin-madwizard/watch"
 import { Select, SelectOption, SelectOptionObject } from "@patternfly/react-core"
 
 type Props = {

plugins/plugin-codeflare/src/components/DashboardSelect.tsx

@@ -19,8 +19,8 @@ import { Prompts, Tree } from "madwizard"
 import { cli } from "madwizard/dist/fe/cli"
 import { Loading } from "@kui-shell/plugin-client-common"
 
-import AskUI, { Ask } from "./Ask"
-import { guidebookStore } from "../controller/respawn"
+import { AskUI, Ask } from "@kui-shell/plugin-madwizard/components"
+import { guidebookStore } from "@kui-shell/plugin-madwizard/watch"
 
 type Props = {
   guidebook: string

plugins/plugin-codeflare/src/components/Guide.tsx

@@ -15,7 +15,7 @@
  */
 
 import { version } from "@kui-shell/client/package.json"
-import { doMadwizard, MadWizardOptions } from "@kui-shell/plugin-madwizard"
+import { doMadwizard, MadWizardOptions } from "@kui-shell/plugin-madwizard/do"
 
 import comIBMResearchFM from "../teams/com/ibm/research/fm"
 import comIBMResearchNASA from "../teams/com/ibm/research/nasa"

plugins/plugin-codeflare/src/controller/catchall.ts

@@ -54,7 +54,7 @@ async function dashboardcli(args: Arguments<DashboardOptions>) {
 }
 
 async function dashboardui(args: Arguments<DashboardOptions>) {
-  const { setTabReadonly } = await import("@kui-shell/plugin-madwizard")
+  const { setTabReadonly } = await import("@kui-shell/plugin-madwizard/do")
   setTabReadonly(args)
 
   const filepath = args.argvNoOptions[2]

plugins/plugin-codeflare/src/controller/dashboard.ts

@@ -15,10 +15,6 @@
  */
 
 import { Arguments } from "@kui-shell/core"
-import { doExecWithPty } from "@kui-shell/plugin-bash-like"
-import { setTabReadonly } from "@kui-shell/plugin-madwizard"
-
-import respawnCommand from "./respawn"
 
 /**
  * Entrypoint for madwizard tasks from tray.ts. We could improve the
@@ -28,9 +24,15 @@ import respawnCommand from "./respawn"
  * see bin/codeflare; we are mostly copying bits from there
  */
 export default async function guide(args: Arguments) {
+  const [{ doExecWithPty }, { respawn }, { setTabReadonly }] = await Promise.all([
+    import("@kui-shell/plugin-bash-like"),
+    import("@kui-shell/plugin-madwizard/watch"),
+    import("@kui-shell/plugin-madwizard/do"),
+  ])
+
   setTabReadonly(args)
 
-  const { argv, env } = await respawnCommand(
+  const { argv, env } = await respawn(
     args.command.replace(/--type=renderer/, "").replace(/^codeflare\s+gui\s+guide/, "codeflare")
   )
 

plugins/plugin-codeflare/src/controller/guide.ts

@@ -15,7 +15,7 @@
  */
 
 import { KResponse, Registrar } from "@kui-shell/core"
-import { MadWizardOptions, flags } from "@kui-shell/plugin-madwizard"
+import { MadWizardOptions, flags } from "@kui-shell/plugin-madwizard/do"
 
 import { width, height } from "@kui-shell/client/config.d/style.json"
 
@@ -64,49 +64,41 @@ export default function registerCodeflareCommands(registrar: Registrar) {
     height,
   })
 
-  registrar.listen("/codeflare/reset/profile", (args) => import("./profile/reset").then((_) => _.default(args)))
-  registrar.listen("/codeflare/delete/profile", (args) => import("./profile/delete").then((_) => _.default(args)))
-  registrar.listen("/codeflare/rename/profile", (args) => import("./profile/rename").then((_) => _.default(args)))
-
-  registrar.listen("/codeflare/get/profile", () => import("./profile/get").then((_) => _.default()), {
-    needsUI: true,
-  })
   registrar.listen("/codeflare/get/run", (args) => import("./run/get").then((_) => _.default(args)), {
     needsUI: true,
     outputOnly: true,
   })
 
   // launch our explore guidebook
   ;["ui", "explore", "explorer", "hello"].forEach((explore) =>
-    registrar.listen(`/codeflare/${explore}`, (args) => import("./hello").then((_) => _.default(args)), {
-      needsUI: true,
-      outputOnly: true,
-      width,
-      height,
-    })
+    registrar.listen(
+      `/codeflare/${explore}`,
+      (args) => import("@kui-shell/plugin-madwizard").then((_) => _.hello(args)),
+      {
+        needsUI: true,
+        outputOnly: true,
+        width,
+        height,
+      }
+    )
   )
 
   /**
    * Launch the gallery with asciinema plays
    */
-  registrar.listen("/codeflare/gallery", () => import("./hello").then((_) => _.gallery()), {
+  /* registrar.listen("/codeflare/gallery", () => import("./hello").then((_) => _.gallery()), {
     outputOnly: true,
-  })
+  }) */
 
   /**
    * Launch a gallery with the example dashboards
    */
-  registrar.listen("/codeflare/dashboard-gallery", (args) => import("./hello").then((_) => _.dashboardGallery(args)))
-
-  /** UI for running profile-related tasks */
-  registrar.listen("/codeflare/designer", (args) => import("./terminal").then((_) => _.designer(args)), {
-    needsUI: true,
-  })
+  // registrar.listen("/codeflare/dashboard-gallery", (args) => import("./hello").then((_) => _.dashboardGallery(args)))
 
   /** Open a plain terminal */
-  registrar.listen("/codeflare/terminal/shell", (args) => import("./terminal").then((_) => _.shell(args)), {
+  /* registrar.listen("/codeflare/terminal/shell", (args) => import("./terminal").then((_) => _.shell(args)), {
     needsUI: true,
-  })
+  }) */
 
   /**
    * Register a catch-all command handler: any `/^codeflare/` command

plugins/plugin-codeflare/src/controller/index.ts

@@ -19,7 +19,6 @@ import { Profiles } from "madwizard"
 import { basename, join } from "path"
 import prettyMilliseconds from "pretty-ms"
 import { Arguments, Table } from "@kui-shell/core"
-import { setTabReadonly } from "@kui-shell/plugin-madwizard"
 
 import { productName } from "@kui-shell/client/config.d/name.json"
 
@@ -78,6 +77,8 @@ function getRunTime(start: number, end: number): string {
 }
 
 export default async function getRuns(args: Arguments) {
+  const [{ setTabReadonly }] = await Promise.all([import("@kui-shell/plugin-madwizard/do")])
+
   setTabReadonly(args)
   const profile = args.parsedOptions.p || args.parsedOptions.profile