Skip to content

Commit 3ad8c79

Browse files
committed
test: run the cli test suite on mac, too
We cannot yet enable windows tests, due to an issue with running the headless builder on windows: ``` [webpack-cli] Invalid value '${MODE-production}' for the '--mode' option [webpack-cli] Expected: 'development | production | none' ```
1 parent 554c9cf commit 3ad8c79

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/cli.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212

1313
strategy:
1414
matrix:
15-
os: [ubuntu-latest]
15+
os: [ubuntu-latest, macOS-latest] # windows-latest kui headless build son windows seem to fail [webpack-cli] Invalid value '${MODE-production}' for the '--mode' option
1616
node-version: [16.x]
1717

1818
steps:

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@
2727
"build:docker:self-test": "npm run build:headless-maybe && docker build -f deploy/self-test/Dockerfile -t ${SELF_TEST_IMAGE-ghcr.io/project-codeflare/codeflare-self-test:${VERSION-latest}} .",
2828
"run:self-test": "./deploy/self-test/test-in-kind.sh",
2929
"build:headless-maybe": "if [ ! -n \"$FAST\" ]; then npm run build:headless; fi",
30-
"build:headless": "CLIENT_HOME=$PWD webpack-cli --mode=${MODE-production} --config node_modules/@kui-shell/webpack/headless-webpack.config.js",
31-
"docker:debug": "ENTRYPOINT=bash ./bin/codeflare -d",
30+
"build:headless": "cross-env CLIENT_HOME=$PWD webpack-cli --mode=${MODE-production} --config node_modules/@kui-shell/webpack/headless-webpack.config.js",
31+
"docker:debug": "cross-env ENTRYPOINT=bash ./bin/codeflare -d",
3232
"store-for-prod": "rm -rf store && cp -a node_modules/@guidebooks/store/dist/store .",
3333
"build:electron:mac:amd64": "npm run store-for-prod && KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare PLATFORM=mac ARCH=x64 kui-build-electron",
3434
"build:electron:mac:arm64": "npm run store-for-prod && KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare PLATFORM=mac ARCH=arm64 kui-build-electron",

0 commit comments

Comments
 (0)