Abstract startElectron method to a common shareable folder to use in other tests rather than only for plan.ts

Author: Pablo Carmona

tests/common/startElectron.ts

@@ -0,0 +1,50 @@
+import { _electron as electron } from "playwright"
+import { join } from "path"
+import { main } from "../../package.json"
+import { productName } from "../../plugins/plugin-client-default/config.d/name.json"
+
+function githubActionsOS() {
+  return process.env.RUNNER_OS.replace(/macOS/, "darwin")
+    .replace(/Linux/, "linux")
+    .replace(/Windows/, "win32")
+}
+
+function githubActionsArch() {
+  return process.env.RUNNER_ARCH.replace(/X64/, "x64").replace(/ARM64/, "arm64")
+}
+
+function electronProductionPath() {
+  return process.platform === "linux"
+    ? productName
+    : process.platform === "win32"
+      ? `${productName}.exe`
+      : join(productName + ".app", "Contents/MacOS", productName)
+}
+
+export default async function startElectron() {
+  // Launch Electron app; "shell" tells Kui to ignore the command line
+  // and just launch a plain shell
+  const executablePath = !process.env.EXECUTABLE_PATH
+    ? undefined
+    : process.env.EXECUTABLE_PATH !== "github-actions-production"
+      ? process.env.EXECUTABLE_PATH
+      : join(
+        process.env.GITHUB_WORKSPACE,
+        "dist/electron",
+        `${productName}-${githubActionsOS()}-${githubActionsArch()}`,
+        electronProductionPath()
+      )
+
+  const app = await electron.launch({ args: [main, "shell"], executablePath })
+
+  const page = await (await app).firstWindow()
+
+  // clear localStorage
+  await page.evaluate(() => {
+    return localStorage.removeItem("debug")
+  })
+
+  await page.click(".repl-block.repl-active .repl-input-element")
+
+  return { app, page }
+}

tests/plugin-codeflare/dashboard/dashboard.ts

@@ -0,0 +1,23 @@
+import slash from "slash"
+import { join, relative } from "path"
+import { test, expect } from "@playwright/test"
+
+import startElectron from "../../common/startElectron"
+
+export default function doDashboard(directory: string) {
+  test.slow()
+  test(`codeflare dashboard -f ${directory}`, async () => {
+    const { app, page } = await startElectron()
+
+    await page.keyboard.type(`dashboard -f ${slash(relative(process.cwd(), join(__dirname, "./inputs", directory)))}`)
+
+
+    await page.keyboard.press("Enter")
+
+    const splitSelector = ".kui--terminal-split-container"
+    const splitElement = await page.locator(splitSelector)
+    await expect(splitElement).toBeVisible()
+
+    await app.close()
+  })
+}

tests/plugin-codeflare/dashboard/inputs/1.spec.ts

@@ -0,0 +1,3 @@
+import doDashboard from "../dashboard";
+
+doDashboard("1")

tests/plugin-madwizard/plan/plan.ts

@@ -18,59 +18,12 @@ import slash from "slash"
 import { join, relative } from "path"
 
 import { test, expect } from "@playwright/test"
-import { Page, _electron as electron } from "playwright"
+import { Page } from "playwright"
 
-import { main } from "../../../package.json"
-import { productName } from "../../../plugins/plugin-client-default/config.d/name.json"
+import startElectron from "../../common/startElectron"
 
 import { Tree } from "./Input"
 
-function githubActionsOS() {
-  return process.env.RUNNER_OS.replace(/macOS/, "darwin")
-    .replace(/Linux/, "linux")
-    .replace(/Windows/, "win32")
-}
-
-function githubActionsArch() {
-  return process.env.RUNNER_ARCH.replace(/X64/, "x64").replace(/ARM64/, "arm64")
-}
-
-function electronProductionPath() {
-  return process.platform === "linux"
-    ? productName
-    : process.platform === "win32"
-    ? `${productName}.exe`
-    : join(productName + ".app", "Contents/MacOS", productName)
-}
-
-async function startElectron() {
-  // Launch Electron app; "shell" tells Kui to ignore the command line
-  // and just launch a plain shell
-  const executablePath = !process.env.EXECUTABLE_PATH
-    ? undefined
-    : process.env.EXECUTABLE_PATH !== "github-actions-production"
-    ? process.env.EXECUTABLE_PATH
-    : join(
-        process.env.GITHUB_WORKSPACE,
-        "dist/electron",
-        `${productName}-${githubActionsOS()}-${githubActionsArch()}`,
-        electronProductionPath()
-      )
-
-  const app = await electron.launch({ args: [main, "shell"], executablePath })
-
-  const page = await (await app).firstWindow()
-
-  // clear localStorage
-  await page.evaluate(() => {
-    return localStorage.removeItem("debug")
-  })
-
-  await page.click(".repl-block.repl-active .repl-input-element")
-
-  return { app, page }
-}
-
 async function checkNode(page: Page, tree: Tree, containerSelector: string) {
   const nodeSelector = `${containerSelector} > .pf-c-tree-view__content > .pf-c-tree-view__node`
   await page.isVisible(nodeSelector)