ensure AppWrapper controller sets PodsReady condition on Workload (#180) (#182)

dgrove-oss · web-flow · commit 51470846ce7a · 2024-06-27T21:20:31.000-04:00
Need to conservatively set the WaitForPodsReady option to true so that
the AppWrapper instance of Kueue's generic reconciller loop will set
the PodsReady condition on the Workload instance when pods become
ready.
diff --git a/pkg/controller/setup.go b/pkg/controller/setup.go
@@ -33,6 +33,7 @@ import (
 	"github.com/project-codeflare/appwrapper/internal/webhook"
 	"github.com/project-codeflare/appwrapper/pkg/config"
 
+	"sigs.k8s.io/kueue/apis/config/v1beta1"
 	"sigs.k8s.io/kueue/pkg/controller/jobframework"
 )
 
@@ -43,6 +44,7 @@ func SetupControllers(mgr ctrl.Manager, awConfig *config.AppWrapperConfig) error
 			mgr.GetClient(),
 			mgr.GetEventRecorderFor("kueue"),
 			jobframework.WithManageJobsWithoutQueueName(true),
+			jobframework.WithWaitForPodsReady(&v1beta1.WaitForPodsReady{Enable: true}),
 		).SetupWithManager(mgr); err != nil {
 			return fmt.Errorf("workload controller: %w", err)
 		}

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@ import (`
`33`	`33`	`"github.com/project-codeflare/appwrapper/internal/webhook"`
`34`	`34`	`"github.com/project-codeflare/appwrapper/pkg/config"`
`35`	`35`
	`36`	`+ "sigs.k8s.io/kueue/apis/config/v1beta1"`
`36`	`37`	`"sigs.k8s.io/kueue/pkg/controller/jobframework"`
`37`	`38`	`)`
`38`	`39`
`@@ -43,6 +44,7 @@ func SetupControllers(mgr ctrl.Manager, awConfig *config.AppWrapperConfig) error`
`43`	`44`	`mgr.GetClient(),`
`44`	`45`	`mgr.GetEventRecorderFor("kueue"),`
`45`	`46`	`jobframework.WithManageJobsWithoutQueueName(true),`
	`47`	`+ jobframework.WithWaitForPodsReady(&v1beta1.WaitForPodsReady{Enable: true}),`
`46`	`48`	`).SetupWithManager(mgr); err != nil {`
`47`	`49`	`return fmt.Errorf("workload controller: %w", err)`
`48`	`50`	`}`