MenuItem: add props interface and update to named export --no-verify

Author: clairep94

client/components/Dropdown/MenuItem.tsx

@@ -1,10 +1,17 @@
-import PropTypes from 'prop-types';
 import React from 'react';
-import { ButtonOrLink } from '../../common/ButtonOrLink';
+import { ButtonOrLink, ButtonOrLinkProps } from '../../common/ButtonOrLink';
 
 // TODO: combine with NavMenuItem
 
-function MenuItem({ hideIf, ...rest }) {
+export interface MenuItemProps extends ButtonOrLinkProps {
+  /**
+   * Provides a way to deal with optional items.
+   */
+  hideIf?: boolean;
+  value?: string;
+}
+
+export function MenuItem({ hideIf = false, ...rest }: MenuItemProps) {
   if (hideIf) {
     return null;
   }
@@ -15,21 +22,3 @@ function MenuItem({ hideIf, ...rest }) {
     </li>
   );
 }
-
-MenuItem.propTypes = {
-  ...ButtonOrLink.propTypes,
-  onClick: PropTypes.func,
-  value: PropTypes.string,
-  /**
-   * Provides a way to deal with optional items.
-   */
-  hideIf: PropTypes.bool
-};
-
-MenuItem.defaultProps = {
-  onClick: null,
-  value: null,
-  hideIf: false
-};
-
-export default MenuItem;

client/modules/IDE/components/AssetListRow.jsx

@@ -4,7 +4,7 @@ import { Link } from 'react-router-dom';
 import { useDispatch } from 'react-redux';
 import { useTranslation } from 'react-i18next';
 import prettyBytes from 'pretty-bytes';
-import MenuItem from '../../../components/Dropdown/MenuItem';
+import { MenuItem } from '../../../components/Dropdown/MenuItem';
 import TableDropdown from '../../../components/Dropdown/TableDropdown';
 import { deleteAssetRequest } from '../actions/assets';
 

client/modules/IDE/components/CollectionList/CollectionListRow.jsx

@@ -5,7 +5,7 @@ import { Link } from 'react-router-dom';
 import { bindActionCreators } from 'redux';
 import { withTranslation } from 'react-i18next';
 import styled from 'styled-components';
-import MenuItem from '../../../../components/Dropdown/MenuItem';
+import { MenuItem } from '../../../../components/Dropdown/MenuItem';
 import TableDropdown from '../../../../components/Dropdown/TableDropdown';
 import * as ProjectActions from '../../actions/project';
 import * as CollectionsActions from '../../actions/collections';

client/modules/IDE/components/SketchListRowBase.jsx

@@ -7,7 +7,7 @@ import { connect } from 'react-redux';
 import * as ProjectActions from '../actions/project';
 import * as IdeActions from '../actions/ide';
 import TableDropdown from '../../../components/Dropdown/TableDropdown';
-import MenuItem from '../../../components/Dropdown/MenuItem';
+import { MenuItem } from '../../../components/Dropdown/MenuItem';
 import { formatDateToString } from '../../../utils/formatDate';
 import { getConfig } from '../../../utils/getConfig';
 import VisibilityDropdown from '../../User/components/VisibilityDropdown';

client/modules/IDE/components/VersionPicker.jsx

@@ -7,7 +7,7 @@ import styled from 'styled-components';
 import { prop } from '../../../theme';
 import { useP5Version } from '../hooks/useP5Version';
 import { p5Versions } from '../../../../common/p5Versions';
-import MenuItem from '../../../components/Dropdown/MenuItem';
+import { MenuItem } from '../../../components/Dropdown/MenuItem';
 import { DropdownMenu } from '../../../components/Dropdown/DropdownMenu';
 import { updateFileContent } from '../actions/files';
 // eslint-disable-next-line import/no-cycle