Skip to content

Commit d831513

Browse files
committed
Move MesssageHandler to a custom hook, create hooks directory
1 parent b10f498 commit d831513

File tree

7 files changed

+14
-27
lines changed

7 files changed

+14
-27
lines changed

client/components/useAsModal.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React from 'react';
22
import styled from 'styled-components';
3-
import { useModalBehavior } from '../utils/custom-hooks';
3+
import { useModalBehavior } from '../modules/IDE/hooks/custom-hooks';
44

55
const BackgroundOverlay = styled.div`
66
position: fixed;

client/modules/IDE/components/Console.jsx

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,9 @@ import DownArrowIcon from '../../../images/down-arrow.svg';
3737

3838
import * as IDEActions from '../../IDE/actions/ide';
3939
import * as ConsoleActions from '../../IDE/actions/console';
40-
import { useDidUpdate } from '../../../utils/custom-hooks';
40+
import { useDidUpdate } from '../hooks/custom-hooks';
41+
import useHandleMessageEvent from '../hooks/useHandleMessageEvent';
42+
import { listen } from '../../../utils/dispatcher';
4143

4244
const getConsoleFeedStyle = (theme, times, fontSize) => {
4345
const style = {
@@ -100,15 +102,18 @@ const Console = ({ t }) => {
100102
collapseConsole, expandConsole, clearConsole, dispatchConsoleEvent
101103
} = bindActionCreators({ ...IDEActions, ...ConsoleActions }, useDispatch());
102104

103-
// useEffect(() => {
104-
// clearConsole();
105-
// dispatchConsoleEvent(consoleEvents);
106-
// }, [theme, fontSize]);
107-
108105
const cm = useRef({});
109106

110107
useDidUpdate(() => { cm.current.scrollTop = cm.current.scrollHeight; });
111108

109+
const handleMessageEvent = useHandleMessageEvent();
110+
useEffect(() => {
111+
const unsubscribe = listen(handleMessageEvent);
112+
return function cleanup() {
113+
unsubscribe();
114+
};
115+
});
116+
112117
const consoleClass = classNames({
113118
'preview-console': true,
114119
'preview-console--collapsed': !isExpanded
File renamed without changes.

client/modules/IDE/components/MessageHandler.jsx renamed to client/modules/IDE/hooks/useHandleMessageEvent.js

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
1-
import React, { useEffect } from 'react';
21
import { useDispatch } from 'react-redux';
32
import { Decode } from 'console-feed';
43
import { isEqual } from 'lodash';
54
import { dispatchConsoleEvent } from '../actions/console';
65
import { stopSketch, expandConsole } from '../actions/console';
7-
import { listen } from '../../../utils/dispatcher';
86

9-
function useHandleMessageEvent() {
7+
export default function useHandleMessageEvent() {
108
const dispatch = useDispatch();
119

1210
const handleMessageEvent = (data) => {
@@ -47,16 +45,3 @@ function useHandleMessageEvent() {
4745
};
4846
return handleMessageEvent;
4947
}
50-
51-
function MessageHandler() {
52-
const handleMessageEvent = useHandleMessageEvent();
53-
useEffect(() => {
54-
const unsubscribe = listen(handleMessageEvent);
55-
return function cleanup() {
56-
unsubscribe();
57-
};
58-
});
59-
return null;
60-
}
61-
62-
export default MessageHandler;

client/modules/IDE/pages/IDEView.jsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import About from '../components/About';
3434
import AddToCollectionList from '../components/AddToCollectionList';
3535
import Feedback from '../components/Feedback';
3636
import { CollectionSearchbar } from '../components/Searchbar';
37-
import MessageHandler from '../components/MessageHandler';
3837
import { getIsUserOwner } from '../selectors/users';
3938

4039

@@ -258,7 +257,6 @@ class IDEView extends React.Component {
258257
<Helmet>
259258
<title>{getTitle(this.props)}</title>
260259
</Helmet>
261-
<MessageHandler />
262260
{this.props.toast.isVisible && <Toast />}
263261
<Nav
264262
warnIfUnsavedChanges={this.handleUnsavedChanges}

client/modules/IDE/pages/MobileIDEView.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ import Dropdown from '../../../components/Dropdown';
3737
import { getIsUserOwner } from '../selectors/users';
3838

3939

40-
import { useEffectWithComparison, useEventListener } from '../../../utils/custom-hooks';
40+
import { useEffectWithComparison, useEventListener } from '../hooks/custom-hooks';
4141

4242
import * as device from '../../../utils/device';
4343

client/utils/previewEntry.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ setInterval(() => {
1717
messages: consoleBuffer,
1818
source: 'sketch'
1919
};
20-
// this could import dispatch instead! wowowowow
2120
window.parent.postMessage(message, window.origin);
2221
consoleBuffer.length = 0;
2322
}

0 commit comments

Comments
 (0)