add separate getProjectForUser to controller

Author: raclim

server/controllers/project.controller.js

@@ -165,14 +165,29 @@ export async function projectExists(projectId) {
  */
 export async function projectForUserExists(username, projectId) {
   const user = await User.findByUsername(username);
-  if (!user) return { success: false };
+  if (!user) return false;
+  const project = await Project.findOne({
+    user: user._id,
+    $or: [{ _id: projectId }, { slug: projectId }]
+  });
+  return project != null;
+}
+
+/**
+ * @param {string} username
+ * @param {string} projectId - the database id or the slug or the project
+ * @return {Promise<object>}
+ */
+export async function getProjectForUser(username, projectId) {
+  const user = await User.findByUsername(username);
+  if (!user) return { exists: false };
   const project = await Project.findOne({
     user: user._id,
     $or: [{ _id: projectId }, { slug: projectId }]
   });
   return project != null
-    ? { success: true, projectName: project.name }
-    : { success: false };
+    ? { exists: true, userProject: project }
+    : { exists: false };
 }
 
 /**

server/routes/server.routes.js

@@ -3,7 +3,8 @@ import sendHtml, { renderIndex, renderProjectIndex } from '../views/index';
 import { userExists } from '../controllers/user.controller';
 import {
   projectExists,
-  projectForUserExists
+  projectForUserExists,
+  getProjectForUser
 } from '../controllers/project.controller';
 import { collectionForUserExists } from '../controllers/collection.controller';
 
@@ -43,15 +44,15 @@ router.get(
 );
 
 router.get('/:username/sketches/:project_id', async (req, res) => {
-  const exists = await projectForUserExists(
+  const userProject = await getProjectForUser(
     req.params.username,
     req.params.project_id
   );
 
-  if (exists.success && exists.projectName) {
-    res.send(renderProjectIndex(req.params.username, exists.projectName));
+  if (userProject.exists) {
+    res.send(renderProjectIndex(req.params.username, userProject.projectName));
   } else {
-    sendHtml(req, res, exists);
+    sendHtml(req, res, userProject.exists);
   }
 });
 

server/views/index.js

@@ -102,8 +102,8 @@ export function renderProjectIndex(username, projectName) {
  * @param {import('express').e.Response} res
  * @param {boolean} [exists]
  */
-export default function sendHtml(req, res, exists = {success:true}) {
-  if (!exists.success) {
+export default function sendHtml(req, res, exists = true) {
+  if (!exists) {
     res.status(404);
     get404Sketch((html) => res.send(html));
   } else {