[#1804] update variable names, remove server-side routes

Author: catarak

client/modules/User/pages/DashboardView.jsx

@@ -32,7 +32,7 @@ class DashboardView extends React.Component {
     this.gotoHomePage = this.gotoHomePage.bind(this);
     this.toggleCollectionCreate = this.toggleCollectionCreate.bind(this);
     this.state = {
-      isCollectionCreate: false
+      collectionCreateVisible: false
     };
   }
 
@@ -74,7 +74,7 @@ class DashboardView extends React.Component {
 
   toggleCollectionCreate() {
     this.setState((prevState) => ({
-      isCollectionCreate: !prevState.isCollectionCreate
+      collectionCreateVisible: !prevState.collectionCreateVisible
     }));
   }
 
@@ -149,7 +149,7 @@ class DashboardView extends React.Component {
             {this.renderContent(currentTab, username)}
           </div>
         </main>
-        {this.state.isCollectionCreate && (
+        {this.state.collectionCreateVisible && (
           <Overlay
             title={this.props.t('DashboardView.CreateCollectionOverlay')}
             closeOverlay={this.toggleCollectionCreate}

server/routes/server.routes.js

@@ -121,23 +121,6 @@ router.get('/about', (req, res) => {
   res.send(renderIndex());
 });
 
-router.get('/:username/collections/create', (req, res) => {
-  userExists(req.params.username, (exists) => {
-    const isLoggedInUser =
-      req.user && req.user.username === req.params.username;
-    const canAccess = exists && isLoggedInUser;
-    return canAccess
-      ? res.send(renderIndex())
-      : get404Sketch((html) => res.send(html));
-  });
-});
-
-router.get('/:username/collections/create', (req, res) => {
-  userExists(req.params.username, (exists) =>
-    exists ? res.send(renderIndex()) : get404Sketch((html) => res.send(html))
-  );
-});
-
 router.get('/:username/collections/:id', (req, res) => {
   collectionForUserExists(req.params.username, req.params.id, (exists) =>
     exists ? res.send(renderIndex()) : get404Sketch((html) => res.send(html))