move isTestEnvironemnt to its own module for better testability

Author: clairep94

client/modules/IDE/actions/uploader.js

@@ -1,6 +1,7 @@
 import { TEXT_FILE_REGEX } from '../../../../server/utils/fileUtils';
 import { apiClient } from '../../../utils/apiClient';
-import { getConfig, isTestEnvironment } from '../../../utils/getConfig';
+import { getConfig } from '../../../utils/getConfig';
+import { isTestEnvironment } from '../../../utils/checkTestEnv';
 import { handleCreateFile } from './files';
 
 const s3BucketUrlBase = getConfig('S3_BUCKET_URL_BASE');

client/utils/checkTestEnv.ts

@@ -0,0 +1,3 @@
+import { getEnvVar } from './getConfig';
+
+export const isTestEnvironment = getEnvVar('NODE_ENV') === 'test';

client/utils/getConfig.ts

@@ -1,8 +1,10 @@
+import { isTestEnvironment } from './checkTestEnv';
+
 /**
- * Internal function to retrieve env vars, with no error handling.
+ * Function to retrieve env vars, with no error handling.
  * @returns String value of env variable or undefined if not found.
  */
-function getEnvVar(key: string): string | undefined {
+export function getEnvVar(key: string): string | undefined {
   const configSource = global ?? window;
   const env = configSource?.process?.env ?? {};
 
@@ -16,8 +18,6 @@ interface GetConfigOptions {
   throwErrorInTestEnv?: boolean; // this is only to test getConfig and should never be set to override defaults
 }
 
-export const isTestEnvironment = getEnvVar('NODE_ENV') === 'test';
-
 const defaultGetConfigOptions: GetConfigOptions = {
   warn: !isTestEnvironment,
   nullishString: false,

client/utils/parseStringToType.test.ts

@@ -1,5 +1,9 @@
 import { parseNumber, parseBoolean } from './parseStringToType';
 
+jest.mock('./checkTestEnv', () => ({
+  isTestEnvironment: false
+}));
+
 describe('parseNumber', () => {
   beforeEach(() => {
     jest.spyOn(console, 'warn').mockImplementation(() => {});

client/utils/parseStringToType.ts

@@ -1,3 +1,4 @@
+import { isTestEnvironment } from './checkTestEnv';
 /* eslint-disable consistent-return */
 /**
  * Parses a string into a number.
@@ -9,7 +10,9 @@ export function parseNumber(
   nullishNumber = false
 ): number | undefined {
   if (!str) {
-    console.warn(`parseNumber: got nullish input`);
+    if (!isTestEnvironment) {
+      console.warn(`parseNumber: got nullish input`);
+    }
     return nullishNumber ? 0 : undefined;
   }
 
@@ -32,7 +35,9 @@ export function parseBoolean(
   nullishBool = false
 ): boolean | undefined {
   if (!str) {
-    console.warn('parseBoolean: got nullish input');
+    if (!isTestEnvironment) {
+      console.warn('parseBoolean: got nullish input');
+    }
     return nullishBool ? false : undefined;
   }