Merge pull request #2610 from PiyushChandra17/piyush/fix-app-crash

fix crashing of app irrespective of aws s3 bucket set up

Author: lindapaiste

client/modules/IDE/actions/collections.js

@@ -27,10 +27,9 @@ export function getCollections(username) {
         dispatch(stopLoader());
       })
       .catch((error) => {
-        const { response } = error;
         dispatch({
           type: ActionTypes.ERROR,
-          error: response.data
+          error: error?.response?.data
         });
         dispatch(stopLoader());
       });
@@ -59,11 +58,9 @@ export function createCollection(collection) {
         browserHistory.push(location);
       })
       .catch((error) => {
-        const { response } = error;
-        console.error('Error creating collection', response.data);
         dispatch({
           type: ActionTypes.ERROR,
-          error: response.data
+          error: error?.response?.data
         });
         dispatch(stopLoader());
       });
@@ -91,14 +88,11 @@ export function addToCollection(collectionId, projectId) {
         return response.data;
       })
       .catch((error) => {
-        const { response } = error;
         dispatch({
           type: ActionTypes.ERROR,
-          error: response.data
+          error: error?.response?.data
         });
         dispatch(stopLoader());
-
-        return response.data;
       });
   };
 }
@@ -124,14 +118,11 @@ export function removeFromCollection(collectionId, projectId) {
         return response.data;
       })
       .catch((error) => {
-        const { response } = error;
         dispatch({
           type: ActionTypes.ERROR,
-          error: response.data
+          error: error?.response?.data
         });
         dispatch(stopLoader());
-
-        return response.data;
       });
   };
 }
@@ -149,13 +140,10 @@ export function editCollection(collectionId, { name, description }) {
         return response.data;
       })
       .catch((error) => {
-        const { response } = error;
         dispatch({
           type: ActionTypes.ERROR,
-          error: response.data
+          error: error?.response?.data
         });
-
-        return response.data;
       });
   };
 }
@@ -174,13 +162,10 @@ export function deleteCollection(collectionId) {
         return response.data;
       })
       .catch((error) => {
-        const { response } = error;
         dispatch({
           type: ActionTypes.ERROR,
-          error: response.data
+          error: error?.response?.data
         });
-
-        return response.data;
       });
   };
 }

client/modules/IDE/actions/preferences.js

@@ -7,10 +7,9 @@ function updatePreferences(formParams, dispatch) {
     .put('/preferences', formParams)
     .then(() => {})
     .catch((error) => {
-      const { response } = error;
       dispatch({
         type: ActionTypes.ERROR,
-        error: response.data
+        error: error?.response?.data
       });
     });
 }

client/modules/IDE/actions/project.js

@@ -61,10 +61,9 @@ export function getProject(id, username) {
         dispatch(setUnsavedChanges(false));
       })
       .catch((error) => {
-        const { response } = error;
         dispatch({
           type: ActionTypes.ERROR,
-          error: response.data
+          error: error?.response?.data
         });
       });
   };
@@ -338,10 +337,9 @@ export function cloneProject(project) {
             dispatch(setNewProject(response.data));
           })
           .catch((error) => {
-            const { response } = error;
             dispatch({
               type: ActionTypes.PROJECT_SAVE_FAIL,
-              error: response.data
+              error: error?.response?.data
             });
           });
       }
@@ -376,10 +374,9 @@ export function changeProjectName(id, newName) {
         }
       })
       .catch((error) => {
-        const { response } = error;
         dispatch({
           type: ActionTypes.PROJECT_SAVE_FAIL,
-          error: response.data
+          error: error?.response?.data
         });
       });
   };

client/modules/IDE/actions/projects.js

@@ -22,10 +22,9 @@ export function getProjects(username) {
         dispatch(stopLoader());
       })
       .catch((error) => {
-        const { response } = error;
         dispatch({
           type: ActionTypes.ERROR,
-          error: response.data
+          error: error?.response?.data
         });
         dispatch(stopLoader());
       });