feat: support new w/o parens in php 8.4

Author: claytonrcarter

src/needs-parens.mjs

@@ -1,4 +1,9 @@
-import { getPrecedence, shouldFlatten, isBitwiseOperator } from "./util.mjs";
+import {
+  getPrecedence,
+  shouldFlatten,
+  isBitwiseOperator,
+  isMinVersion,
+} from "./util.mjs";
 
 function needsParens(path, options) {
   const { parent } = path;
@@ -128,13 +133,16 @@ function needsParens(path, options) {
     }
     case "clone":
     case "new": {
+      const requiresParens =
+        node.kind === "clone" ||
+        (node.kind === "new" && !isMinVersion(options.phpVersion, "8.4"));
       switch (parent.kind) {
         case "propertylookup":
         case "nullsafepropertylookup":
         case "staticlookup":
         case "offsetlookup":
         case "call":
-          return key === "what";
+          return key === "what" && requiresParens;
         default:
           return false;
       }

tests/new/__snapshots__/jsfmt.spec.mjs.snap

@@ -654,12 +654,12 @@ abstract class A
     }
 }
 
-$class = (new Foo())->veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongMethod();
-$class = (new Foo([
+$class = new Foo()->veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongMethod();
+$class = new Foo([
     "VeryVeryVeryVeryVeryVeryVeryVeryVeryLongKey" =>
         "VeryVeryVeryVeryVeryVeryVeryVeryVeryLongValue",
-]))->veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongMethod();
-$class = (new PendingDispatch(new $this->class(...func_get_args())))->chain(
+])->veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongMethod();
+$class = new PendingDispatch(new $this->class(...func_get_args()))->chain(
     $this->chain,
 );
 $dumper = in_array(PHP_SAPI, ["cli", "phpdbg"])
@@ -676,7 +676,7 @@ $class = new static(
 $response = new \\Illuminate\\Http\\JsonResponse(
     new JsonResponseTestJsonSerializeObject(),
 );
-$result = (new Pipeline(new \\Illuminate\\Container\\Container()))
+$result = new Pipeline(new \\Illuminate\\Container\\Container())
     ->send("foo")
     ->through([new PipelineTestPipeOne()])
     ->then(function ($piped) {

tests/parens/__snapshots__/jsfmt.spec.mjs.snap

@@ -4865,11 +4865,11 @@ $var = $var[0][1]::foo();
 $var = $var[0]->foo()->baz;
 $var = $var[0]->foo()->baz;
 
-$var = (new Foo())->bar;
-$var = (new Foo())::bar;
-$var = (new Foo())->bar();
-$var = (new Foo())::bar();
-$var = (new Foo())[1];
+$var = new Foo()->bar;
+$var = new Foo()::bar;
+$var = new Foo()->bar();
+$var = new Foo()::bar();
+$var = new Foo()[1];
 
 $var = $var->bar()();
 $var = $var->bar()();
@@ -5146,33 +5146,33 @@ new Translator(
 <?php
 $var = new Foo();
 $var = new Foo();
-$var = (new Foo())->c();
+$var = new Foo()->c();
 $var = new class {
     public function log($msg)
     {
         echo $msg;
     }
 };
-$var = (new foo())->bar();
-$var = (new foo())->bar()->foo();
-$var = (new foo())->bar()->foo();
-$var = (new foo())->bar()->foo();
-$var = (new foo())->bar()->foo()[0];
-$var = (new foo())->bar()->foo()[0][1];
-$var = (new foo())->bar()->foo()->baz();
-$var = (new $foo())->bar;
-$var = (new $bar->y())->x;
-$var = (new foo())[0];
-$var = (new foo())[0]["string"];
+$var = new foo()->bar();
+$var = new foo()->bar()->foo();
+$var = new foo()->bar()->foo();
+$var = new foo()->bar()->foo();
+$var = new foo()->bar()->foo()[0];
+$var = new foo()->bar()->foo()[0][1];
+$var = new foo()->bar()->foo()->baz();
+$var = new $foo()->bar;
+$var = new $bar->y()->x;
+$var = new foo()[0];
+$var = new foo()[0]["string"];
 $var = new $a->b();
 $var = new $a->b();
-$var = (new $a())->b();
-$var = (new $a())->b();
-(new class {})->foo;
-(new class {})->foo();
-(new class {})();
-(new class {})["foo"];
-$var = (new class {})->foo;
+$var = new $a()->b();
+$var = new $a()->b();
+new class {}->foo;
+new class {}->foo();
+new class {}();
+new class {}["foo"];
+$var = new class {}->foo;
 
 
 ================================================================================