Skip to content

fix: add range offset for insertion suggestion #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: add range offset for insertion suggestion #768

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
69b4661
fix: add range offset for insertion suggestion
codeshake Oct 30, 2025
4c93d1b
fix: refactor diff function
codeshake Oct 30, 2025
9ec8fa3
fix: refactor diff function
codeshake Oct 30, 2025
1ee5d5f
Merge branch 'main' into main
codeshake Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions eslint-plugin-prettier.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,22 +104,28 @@ function getLocFromIndex(sourceCode, index) {
function reportDifference(context, difference) {
const { operation, offset, deleteText = '', insertText = '' } = difference;
/** @type {AST.Range} */
const range = [offset, offset + deleteText.length];
const [highlightStart, highlightEnd] = [
offset,
offset + (deleteText.length || Math.min(insertText.length, 1)),
];
/** @type {AST.Range} */
const replaceRange = [offset, offset + deleteText.length];
// `context.getSourceCode()` was deprecated in ESLint v8.40.0 and replaced
// with the `sourceCode` property.
// TODO: Only use property when our eslint peerDependency is >=8.40.0.
const sourceCode = context.sourceCode ?? context.getSourceCode();

const [start, end] = range.map(index => getLocFromIndex(sourceCode, index));

context.report({
messageId: operation,
data: {
deleteText: showInvisibles(deleteText),
insertText: showInvisibles(insertText),
},
loc: { start, end },
fix: fixer => fixer.replaceTextRange(range, insertText),
loc: {
start: getLocFromIndex(sourceCode, highlightStart),
end: getLocFromIndex(sourceCode, highlightEnd),
},
fix: fixer => fixer.replaceTextRange(replaceRange, insertText),
});
}

Expand Down
Loading