Merge pull request #306 from prettier-solidity/assembly-func-definition

Improve assembly functions without return values

Author: fvictorio

src/nodes/AssemblyFunctionDefinition.js

@@ -15,18 +15,20 @@ const AssemblyFunctionDefinition = {
       '(',
       printSeparatedList(path.map(print, 'arguments')),
       ')',
-      group(
-        printSeparatedItem(
-          concat([
-            '->',
-            printSeparatedList(path.map(print, 'returnArguments'), {
-              firstSeparator: line,
-              lastSeparator: ''
-            })
-          ]),
-          { firstSeparator: line }
-        )
-      ),
+      node.returnArguments.length === 0
+        ? ' '
+        : group(
+            printSeparatedItem(
+              concat([
+                '->',
+                printSeparatedList(path.map(print, 'returnArguments'), {
+                  firstSeparator: line,
+                  lastSeparator: ''
+                })
+              ]),
+              { firstSeparator: line }
+            )
+          ),
       path.call(print, 'body')
     ])
 };

tests/Assembly/Assembly.sol

@@ -138,4 +138,13 @@ assembly{
     three:
 }
 }
+
+  function assemblyFunctionNoReturn () {
+
+    assembly {
+
+function $somefn(somearg) {
+}
+    }
+  }
 }

tests/Assembly/__snapshots__/jsfmt.spec.js.snap

@@ -141,6 +141,15 @@ assembly{
     three:
 }
 }
+
+  function assemblyFunctionNoReturn () {
+
+    assembly {
+
+function $somefn(somearg) {
+}
+    }
+  }
 }
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 contract Assembly {
@@ -319,6 +328,14 @@ contract Assembly {
         three:
         }
     }
+
+    function assemblyFunctionNoReturn() {
+        assembly {
+            function $somefn(somearg) {
+
+            }
+        }
+    }
 }
 
 `;