Improve function calls in assembly code (#98)

Author: Franco Victorio

src/printer.js

@@ -499,11 +499,20 @@ function genericPrint(path, options, print) {
       if (node.arguments.length === 0) {
         return node.functionName;
       }
-      // @TODO: add call args
       return concat([
         node.functionName,
         '(',
-        join(', ', path.map(print, 'arguments')),
+        group(
+          concat([
+            indent(
+              concat([
+                softline,
+                join(concat([',', line]), path.map(print, 'arguments'))
+              ])
+            ),
+            softline
+          ])
+        ),
         ')'
       ]);
     case 'HexNumber':

tests/Assembly/Assembly.sol

@@ -25,4 +25,14 @@ contract Assembly {
 for { let i := 0 } lt(i, x) { i := add(i, 1) } { y := mul(2, y) }
         }
   }
+
+  function callWithComments() {
+    assembly {
+      f(
+        1, // one
+        2, // two
+        3 // three
+      )
+    }
+  }
 }

tests/Assembly/__snapshots__/jsfmt.spec.js.snap

@@ -28,6 +28,16 @@ contract Assembly {
 for { let i := 0 } lt(i, x) { i := add(i, 1) } { y := mul(2, y) }
         }
   }
+
+  function callWithComments() {
+    assembly {
+      f(
+        1, // one
+        2, // two
+        3 // three
+      )
+    }
+  }
 }
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 contract Assembly {
@@ -43,10 +53,16 @@ contract Assembly {
     assembly {
       switch value
         case 0 {
-          mstore(0, 0x0000000000000000000000000000000000000000000000000000000000000000)
+          mstore(
+            0,
+            0x0000000000000000000000000000000000000000000000000000000000000000
+          )
         }
         case 1 {
-          mstore(0, 0x1111111111111111111111111111111111111111111111111111111111111111)
+          mstore(
+            0,
+            0x1111111111111111111111111111111111111111111111111111111111111111
+          )
         }
     }
   }
@@ -62,6 +78,16 @@ contract Assembly {
       }
     }
   }
+
+  function callWithComments() {
+    assembly {
+      f(
+        1, // one
+        2, // two
+        3 // three
+      )
+    }
+  }
 }
 
 `;

tests/Proxy/__snapshots__/jsfmt.spec.js.snap

@@ -86,11 +86,14 @@ contract Proxy {
       // block because it will not return to Solidity code. We overwrite the
       // Solidity scratch pad at memory position 0.
       calldatacopy(0, 0, calldatasize)
+
       // Call the implementation.
       // out and outsize are 0 because we don't know the size yet.
       let result := delegatecall(gas, implementation, 0, calldatasize, 0, 0)
+
       // Copy the returned data.
       returndatacopy(0, 0, returndatasize)
+
       switch result
         // delegatecall returns 0 on error.
         case 0 {