Skip to content

enh: display directory base name as terminal title on Unix based systems (~/dir) #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

enh: display directory base name as terminal title on Unix based systems (~/dir) #269

wants to merge 1 commit into from
+17 −1

Conversation

@kmr-srbh
Copy link

@kmr-srbh kmr-srbh commented Sep 18, 2025 •
edited
Loading

Resolves #237

Before

~/OpenSource/shell(main)$ 
~/OpenSource/shell(main)$ cd ./crates/
~/OpenSource/shell/crates(main)$ cd ..
~/OpenSource/shell(main)$

Now

~/shell(display-unix-style-cwd)$ 
~/shell(display-unix-style-cwd)$ cd ./crates/
~/crates(display-unix-style-cwd)$ cd ..
~/shell(display-unix-style-cwd)$

Changes

  • Updates the prompt string to the directory base name after the cd command.
  • Sets the terminal title to the directory base name after the cd command.

@kmr-srbh
Copy link
Author

kmr-srbh commented Sep 18, 2025 •
edited
Loading

CC @certik, @wolfv

@kmr-srbh kmr-srbh changed the title enh: display home-relative directory paths on Unix based systems (~/dir) enh: display directory base name as path on Unix based systems (~/dir) Sep 18, 2025
@kmr-srbh kmr-srbh force-pushed the display-unix-style-cwd branch from b4b67cc to a660418 Compare September 18, 2025 21:08
@kmr-srbh kmr-srbh changed the title enh: display directory base name as path on Unix based systems (~/dir) enh: display directory base name as terminal title on Unix based systems (~/dir) Sep 18, 2025
@kmr-srbh kmr-srbh force-pushed the display-unix-style-cwd branch from a660418 to 143f127 Compare September 18, 2025 21:10
wolfv
wolfv reviewed Nov 11, 2025
View reviewed changes
crates/deno_task_shell/src/shell/types.rs
shell_options: HashMap<ShellOptions, bool>,
}

#[allow(clippy::print_stdout)]
Copy link
Member

@wolfv wolfv Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this function removed? I think it seems useful and I don't see us setting the title elsewhere?

wolfv
wolfv reviewed Nov 11, 2025
View reviewed changes
crates/shell/src/main.rs
Copy link
Member

@wolfv wolfv Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only sets the PS1, right? Not the terminal title? Or am I missing something?

@kmr-srbh
enh: display directory base name as terminal title on Unix based syst…
e3a8414 
…ems (`~/dir`)

Signed-off-by: Saurabh Kumar <developer.saurabh@outlook.com>
@kmr-srbh kmr-srbh force-pushed the display-unix-style-cwd branch from f81a79f to e3a8414 Compare November 11, 2025 14:42
@kmr-srbh
Copy link
Author

kmr-srbh commented Nov 11, 2025 •
edited
Loading

Hello @wolfv! Thanks for the review! :)

I was developing with the VS Code integrated terminal and misunderstood the prompt string to be the terminal title. I am new to terminal emulators and learning. I have pushed the new changes. Thank you very much for your guidance!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfv wolfv wolfv left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When showing the directory in the terminal tab, use ~

2 participants

@kmr-srbh @wolfv