Fix: Import JupyterDashPersistentInlineOutput only when needed (#349)

* 🔍 Fix: Import JupyterDashPersistentInlineOutput only when needed and update dependencies #348

* :see_no_evil fix: fix formatting

* 🔍 fix tests + improve import error message

Author: jonasvdd

plotly_resampler/figure_resampler/figure_resampler.py

@@ -26,7 +26,6 @@
     MinMaxLTTB,
 )
 from .figure_resampler_interface import AbstractFigureAggregator
-from .jupyter_dash_persistent_inline_output import JupyterDashPersistentInlineOutput
 from .utils import is_figure, is_fr
 
 # Default arguments for the Figure overview
@@ -626,6 +625,10 @@ def show_dash(
         # function signatures are slightly different for the (Jupyter)Dash and the
         # JupyterDashInlinePersistent implementations
         if mode == "inline_persistent":
+            from .jupyter_dash_persistent_inline_output import (
+                JupyterDashPersistentInlineOutput,
+            )
+
             jpi = JupyterDashPersistentInlineOutput(self)
             jpi.run_app(app=app, **kwargs)
         else:

plotly_resampler/figure_resampler/jupyter_dash_persistent_inline_output.py

@@ -12,10 +12,15 @@
 try:
     from IPython.display import HTML, display
 except ImportError:
-    pass
+    raise ImportError(
+        "The `jupyter_dash_persistent_inline_output` requirements are not installed.\n"
+        "Please install them with:\n"
+        "pip install plotly_resampler[inline_persistent]"
+    )
 
-from dash._jupyter import JupyterDash, _jupyter_config, make_server, retry
+from dash._jupyter import JupyterDash, _jupyter_config, make_server
 from plotly.graph_objects import Figure
+from retrying import retry
 
 
 class JupyterDashPersistentInlineOutput:

poetry.lock

@@ -55,7 +55,7 @@ tsdownsample = ">=0.1.3"
 
 [tool.poetry.extras]
 # Optional dependencies
-inline_persistent = ["kaleido", "Flask-Cors"]
+inline_persistent = ["kaleido", "Flask-Cors", "ipython"]
 
 [tool.poetry.dev-dependencies]
 pytest = "^7.2.0"

pyproject.toml

@@ -1279,7 +1279,7 @@ def test_manual_jupyterdashpersistentinline():
 
     import dash
 
-    from plotly_resampler.figure_resampler.figure_resampler import (
+    from plotly_resampler.figure_resampler.jupyter_dash_persistent_inline_output import (
         JupyterDashPersistentInlineOutput,
     )