fix: types node16 resolution (#117)

* fix: Types

* fix: ESLint configuration

* ci: Merge the workflows (sorry for sneaking in)

Author: rschristian

.github/workflows/ci.yml

@@ -18,16 +18,28 @@ jobs:
         with:
           node-version: 22
           cache: npm
+          cache-dependency-path: '**/package-lock.json'
 
       - name: Install NPM dependencies
         run: npm ci
 
-      - name: build
-        run: npm run build
-
       - name: test
         env:
           CI: true
         run: |
           npm run lint
           npm run test
+
+  size:
+    name: Compressed Size
+    runs-on: ubuntu-latest
+    timeout-minutes: 5
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 22
+          cache: 'npm'
+          cache-dependency-path: '**/package-lock.json'
+
+      - uses: preactjs/compressed-size-action@v2

.github/workflows/size.yml

@@ -10,7 +10,7 @@
 	"scripts": {
 		"prepare": "npx simple-git-hooks",
 		"build": "microbundle -f cjs,es,umd --no-generateTypes",
-		"lint": "eslint src/*.{js,jsx}",
+		"lint": "eslint src/*.js",
 		"test": "npm run test:types & npm run test:browser",
 		"test:browser": "wtr test/*.test.{js,jsx}",
 		"test:types": "tsc -p test/",

package.json

@@ -1,11 +1,4 @@
-import { h, AnyComponent } from 'preact';
-
-type PreactCustomElement = HTMLElement & {
-	_root: ShadowRoot | HTMLElement;
-	_vdomComponent: AnyComponent;
-	_vdom: ReturnType<typeof h> | null;
-	_props: Record<string, unknown>;
-};
+import { AnyComponent } from 'preact';
 
 type Options =
 	| {
@@ -46,9 +39,11 @@ type Options =
  * const klass = register(PreactComponent, 'my-component');
  * ```
  */
-export default function register<P = {}, S = {}>(
+declare function register<P = {}, S = {}>(
 	Component: AnyComponent<P, S>,
 	tagName?: string,
 	propNames?: (keyof P)[],
 	options?: Options
 ): HTMLElement;
+
+export = register;

src/index.d.ts

@@ -1,25 +1,27 @@
 import { h, cloneElement, render, hydrate, Fragment } from 'preact';
 
 /**
- * @typedef {import('./index.d.ts').PreactCustomElement} PreactCustomElement
+ * @typedef {import('./internal.d.ts').PreactCustomElement} PreactCustomElement
  */
 
 /**
- * @type {import('./index.d.ts').default}
+ * @type {import('./index.d.ts')}
  */
 export default function register(Component, tagName, propNames, options) {
 	function PreactElement() {
 		const inst = /** @type {PreactCustomElement} */ (
 			Reflect.construct(HTMLElement, [], PreactElement)
 		);
 		inst._vdomComponent = Component;
-		inst._root =
-			options && options.shadow
-				? inst.attachShadow({ mode: options.mode || 'open' })
-				: inst;
 
-		if (options && options.adoptedStyleSheets) {
-			inst._root.adoptedStyleSheets = options.adoptedStyleSheets;
+		if (options && options.shadow) {
+			inst._root = inst.attachShadow({ mode: options.mode || 'open' });
+
+			if (options.adoptedStyleSheets) {
+				inst._root.adoptedStyleSheets = options.adoptedStyleSheets;
+			}
+		} else {
+			inst._root = inst;
 		}
 
 		return inst;
@@ -49,9 +51,7 @@ export default function register(Component, tagName, propNames, options) {
 	propNames.forEach((name) => {
 		Object.defineProperty(PreactElement.prototype, name, {
 			get() {
-				return this._vdom
-					? this._vdom.props[name]
-					: this._props[name];
+				return this._vdom ? this._vdom.props[name] : this._props[name];
 			},
 			set(v) {
 				if (this._vdom) {

src/index.js

@@ -0,0 +1,8 @@
+import { h, AnyComponent } from 'preact';
+
+export type PreactCustomElement = HTMLElement & {
+	_root: ShadowRoot | HTMLElement;
+	_vdomComponent: AnyComponent;
+	_vdom: ReturnType<typeof h> | null;
+	_props: Record<string, unknown>;
+};