Skip to content

Consolidate input-bound assertions in poly_ntt and polyvec_basemul_acc #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
willieyz wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Consolidate input-bound assertions in poly_ntt and polyvec_basemul_acc #1334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fcb490
refactor: move pre-bound_assertion into native branch
willieyz Dec 2, 2025
03b54c9
Remove outdate comment and add assertion for mlk_polyvec_basemul_acc_…
willieyz Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions mlkem/src/poly.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,17 +456,14 @@ __contract__(
MLK_INTERNAL_API
void mlk_poly_ntt(mlk_poly *p)
{
mlk_assert_abs_bound(p, MLKEM_N, MLKEM_Q);

#if defined(MLK_USE_NATIVE_NTT)
int ret;
mlk_assert_abs_bound(p, MLKEM_N, MLKEM_Q);
ret = mlk_ntt_native(p->coeffs);
if (ret == MLK_NATIVE_FUNC_SUCCESS)
{
int ret;
ret = mlk_ntt_native(p->coeffs);
if (ret == MLK_NATIVE_FUNC_SUCCESS)
{
mlk_assert_abs_bound(p, MLKEM_N, MLK_NTT_BOUND);
return;
}
mlk_assert_abs_bound(p, MLKEM_N, MLK_NTT_BOUND);
return;
}
#endif /* MLK_USE_NATIVE_NTT */

Expand Down
4 changes: 1 addition & 3 deletions mlkem/src/poly_k.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,7 @@ void mlk_polyvec_basemul_acc_montgomery_cached(
#if defined(MLK_USE_NATIVE_POLYVEC_BASEMUL_ACC_MONTGOMERY_CACHED)
{
int ret;
/* Omitting bounds assertion for cache since native implementations may
* decide not to use a mulcache. Note that the C backend implementation
* of poly_basemul_montgomery_cached() does still include the check. */
mlk_assert_bound_2d(a->vec, MLKEM_K, MLKEM_N, 0, MLKEM_UINT12_LIMIT);
#if MLKEM_K == 2
ret = mlk_polyvec_basemul_acc_montgomery_cached_k2_native(
r->coeffs, (const int16_t *)a, (const int16_t *)b,
Expand Down