From c5aa01fa7e9cad1493d835d9092d50de1c3ad832 Mon Sep 17 00:00:00 2001 From: "Matthias J. Kannwischer" Date: Mon, 10 Nov 2025 11:38:57 +0800 Subject: [PATCH 1/3] CI: config-variation - validate test IDs Currently the config variation action gets a space separated lists of config variations. If you pass an invalid test id, it silently gets ignored which is error prone. This commit adds a validation step checking that only allowed IDs are passed. Signed-off-by: Matthias J. Kannwischer --- .github/actions/config-variations/action.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/actions/config-variations/action.yml b/.github/actions/config-variations/action.yml index eb6d734b1c..75f6af1140 100644 --- a/.github/actions/config-variations/action.yml +++ b/.github/actions/config-variations/action.yml @@ -17,6 +17,11 @@ inputs: runs: using: 'composite' steps: + - name: "Validate test IDs" + shell: bash + run: | + ALLOWED="all pct-enabled pct-enabled-broken custom-zeroize native-cap-ON native-cap-OFF native-cap-ID_AA64PFR1_EL1 native-cap-CPUID_AVX2 no-asm serial-fips202 custom-randombytes custom-memcpy custom-memset custom-stdlib nblocks-1 nblocks-2 nblocks-4" + for t in ${{ inputs.tests }}; do echo "$ALLOWED" | grep -qw "$t" || { echo "Invalid test ID: $t. Allowed: $ALLOWED"; exit 1; }; done - name: "PCT enabled" if: ${{ inputs.tests == 'all' || contains(inputs.tests, 'pct-enabled') }} uses: ./.github/actions/multi-functest From 92dd34a6935a2d503b677d2ff2c08d6c60ffc901 Mon Sep 17 00:00:00 2001 From: "Matthias J. Kannwischer" Date: Mon, 10 Nov 2025 09:47:59 +0800 Subject: [PATCH 2/3] (Temporarily) disable Mingw-w64 5.4.0 quickchecks CI is failing to install the Mingw-w64 toolchain due to sourceforge.net returning (403) Forbidden. Other versions work fine. This commits (temporarily) disables Mingw-w64 5.4.0. Signed-off-by: Matthias J. Kannwischer --- .github/workflows/base.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/base.yml b/.github/workflows/base.yml index b4ba224a5f..0106222511 100644 --- a/.github/workflows/base.yml +++ b/.github/workflows/base.yml @@ -186,7 +186,8 @@ jobs: strategy: fail-fast: false matrix: - mingw-version: [5.4.0, 11.2.0, 12.2.0, 13.2.0, 14.2.0, 15.2.0] + # TODO: re-enable 5.4.0 or other old version + mingw-version: [11.2.0, 12.2.0, 13.2.0, 14.2.0, 15.2.0] name: Quickcheck (Mingw-w64 ${{ matrix.mingw-version }}) runs-on: windows-latest steps: From e74cd7dbe0cae9404c0236c5c2a75cfe52d6fba3 Mon Sep 17 00:00:00 2001 From: "Matthias J. Kannwischer" Date: Mon, 10 Nov 2025 12:13:02 +0800 Subject: [PATCH 3/3] test invalid config variation Signed-off-by: Matthias J. Kannwischer --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 21ea226d0b..a5dc7d535c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -466,6 +466,7 @@ jobs: uses: ./.github/actions/config-variations with: gh_token: ${{ secrets.GITHUB_TOKEN }} + tests: 'pct-enabled invalid-test-id' check-cf-protections: name: Test control-flow protections (${{ matrix.compiler.name }}, x86_64) strategy: