Add copyright header to Makefiles and .yml files and extend lint

mkannwischer · hanno-becker · commit a5e61996e41e · 2025-11-12T05:40:03.000Z
A couple of files in mlkem-native are lacking copyright headers for no good
reason. This commit adds the copyright headers and extends the lint script
to also cover Makefiles, .mk files, and .yml files.

Signed-off-by: Matthias J. Kannwischer &lt;matthias@kannwischer.eu&gt;
diff --git a/.github/actions/bench/action.yml b/.github/actions/bench/action.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: Bench mlkem-native
diff --git a/.github/actions/cbmc/action.yml b/.github/actions/cbmc/action.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: CBMC
diff --git a/.github/actions/config-variations/action.yml b/.github/actions/config-variations/action.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: 'Custom config tests'
diff --git a/.github/actions/ct-test/action.yml b/.github/actions/ct-test/action.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: CT Test
diff --git a/.github/actions/functest/action.yml b/.github/actions/functest/action.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: Functional tests
diff --git a/.github/actions/lint/action.yml b/.github/actions/lint/action.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: Lint
diff --git a/.github/actions/multi-functest/action.yml b/.github/actions/multi-functest/action.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: Multiple Functional tests
diff --git a/.github/actions/setup-apt/action.yml b/.github/actions/setup-apt/action.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: Dependencies (apt)
diff --git a/.github/actions/setup-aws-lc/action.yml b/.github/actions/setup-aws-lc/action.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: Setup AWS-LC
diff --git a/.github/actions/setup-brew/action.yml b/.github/actions/setup-brew/action.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: Dependencies (apt)
diff --git a/.github/actions/setup-nix/action.yml b/.github/actions/setup-nix/action.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: Setup nix
diff --git a/.github/actions/setup-opentitan/action.yml b/.github/actions/setup-opentitan/action.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: Setup OpenTitan
diff --git a/.github/actions/setup-oqs/action.yml b/.github/actions/setup-oqs/action.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: Setup libOQS
diff --git a/.github/actions/setup-os/action.yml b/.github/actions/setup-os/action.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: Setup OS
diff --git a/.github/actions/setup-shell/action.yml b/.github/actions/setup-shell/action.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: Set Shell
diff --git a/.github/actions/setup-yum/action.yml b/.github/actions/setup-yum/action.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: Dependencies (yum)
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -1,3 +1,6 @@
+# Copyright (c) The mlkem-native project authors
+# SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
+
 version: 2
 updates:
   - package-ecosystem: github-actions
diff --git a/.github/workflows/all.yml b/.github/workflows/all.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: CI
diff --git a/.github/workflows/base.yml b/.github/workflows/base.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: Base
diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: Bench
diff --git a/.github/workflows/bench_ec2_any.yml b/.github/workflows/bench_ec2_any.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: bench-ec2-any
diff --git a/.github/workflows/bench_ec2_reusable.yml b/.github/workflows/bench_ec2_reusable.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: bench-ec2-reusable
diff --git a/.github/workflows/cbmc.yml b/.github/workflows/cbmc.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: CBMC
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: Extended
diff --git a/.github/workflows/ci_ec2_any.yml b/.github/workflows/ci_ec2_any.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: ci-ec2-any
diff --git a/.github/workflows/ci_ec2_container.yml b/.github/workflows/ci_ec2_container.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: ci-ec2-reusable
diff --git a/.github/workflows/ci_ec2_reusable.yml b/.github/workflows/ci_ec2_reusable.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: ci-ec2-reusable
diff --git a/.github/workflows/ct-tests.yml b/.github/workflows/ct-tests.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: Constant-time tests
diff --git a/.github/workflows/hol_light.yml b/.github/workflows/hol_light.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: HOL-Light
diff --git a/.github/workflows/integration-awslc.yml b/.github/workflows/integration-awslc.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: AWS-LC
diff --git a/.github/workflows/integration-opentitan.yml b/.github/workflows/integration-opentitan.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: OpenTitan
diff --git a/.github/workflows/lint_markdown.yml b/.github/workflows/lint_markdown.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: Lint-Markdown
diff --git a/.github/workflows/nix.yml b/.github/workflows/nix.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: Nix
diff --git a/.github/workflows/slothy.yml b/.github/workflows/slothy.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: SLOTHY re-optimization tests
diff --git a/BIBLIOGRAPHY.yml b/BIBLIOGRAPHY.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 - id: ACVP
diff --git a/META.yml b/META.yml
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 name: ML-KEM
diff --git a/proofs/cbmc/Makefile.common b/proofs/cbmc/Makefile.common
@@ -1,6 +1,7 @@
 # -*- mode: makefile -*-
 # The first line sets the emacs major mode to Makefile
 
+# Copyright (c) The mlkem-native project authors
 # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 # SPDX-License-Identifier: MIT-0
 
diff --git a/proofs/cbmc/Makefile_params.common b/proofs/cbmc/Makefile_params.common
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0
 
 ifndef MLKEM_K
diff --git a/proofs/hol_light/arm/Makefile b/proofs/hol_light/arm/Makefile
@@ -1,4 +1,5 @@
 #############################################################################
+# Copyright (c) The mlkem-native project authors
 # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT-0
 #############################################################################
diff --git a/scripts/lint b/scripts/lint
@@ -93,6 +93,7 @@ gh_summary_failure()
 
 gh_error()
 {
+  error "$4"
   if $IN_GITHUB_CONTEXT; then
     echo "::error file=$1,line=${2:-1},title=$3::$4"
   fi
@@ -156,7 +157,7 @@ check-spdx()
       success=false
     fi
   done
-  for file in $(git ls-files -- "*.[chsS]" "*.py" ":/!proofs/cbmc/*.py" ":/!examples/bring_your_own_fips202/custom_fips202/tiny_sha3/*" ":/!examples/custom_backend/mlkem_native/mlkem/src/fips202/native/custom/src/*"); do
+  for file in $(git ls-files -- "*.[chsS]" "*.py" "*.mk" "*.yml" "**/Makefile*" ":/!proofs/cbmc/*.py" ":/!examples/bring_your_own_fips202/custom_fips202/tiny_sha3/*" ":/!examples/custom_backend/mlkem_native/mlkem/src/fips202/native/custom/src/*"); do
     # Ignore symlinks
     if [[ ! -L $file && $(grep "Copyright (c) The mlkem-native project authors" $file | wc -l) == 0 ]]; then
       gh_error "$file" "${line:-1}" "Missing copyright header error" "$file is missing copyright header"
diff --git a/test/mk/auto.mk b/test/mk/auto.mk
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 #
 # Automatically detect system architecture and set preprocessor flags accordingly
diff --git a/test/mk/compiler.mk b/test/mk/compiler.mk
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 #
 # Compiler feature detection for mlkem-native
diff --git a/test/mk/components.mk b/test/mk/components.mk
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 FIPS202_SRCS = $(wildcard mlkem/src/fips202/*.c)
diff --git a/test/mk/config.mk b/test/mk/config.mk
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 ifndef _CONFIG
 _CONFIG :=
diff --git a/test/mk/rules.mk b/test/mk/rules.mk
@@ -1,3 +1,4 @@
+# Copyright (c) The mlkem-native project authors
 # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT
 
 $(BUILD_DIR)/mlkem512/bin/%: $(CONFIG)

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+# Copyright (c) The mlkem-native project authors`
`1`	`2`	`# SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT`
`2`	`3`
`3`	`4`	`name: Bench mlkem-native`