Byte order test is incorrect

[davidchisnall]

This test checks whether __ORDER_BIG_ENDIAN__ is defined at all, but this predefined macro is not intended for that use case. It is identical to the custom IS_BIG_ENDIAN macro in the same file and is expected to be compared against __BYTE_ORDER__.

The current code unconditionally sets the byte order to big endian. The test probably should be:

# if defined(__BYTE_ORDER__)
#  define PLATFORM_BYTE_ORDER __BYTE_ORDER__
# elif defined(__BIG_ENDIAN)
#  define PLATFORM_BYTE_ORDER IS_BIG_ENDIAN
# else
#  define PLATFORM_BYTE_ORDER IS_LITTLE_ENDIAN
# endif

[mkannwischer]

Thanks for reporting this.
mlkem-c-embedded is no longer being maintained/developed.
You may want to consider https://github.com/pq-code-package/mlkem-native.
I double checked that the same problem does not exist there.

[mkannwischer]

We should probably archive this project to indicate better that it is not under active development anymore.
I opened #58 to add a disclaimer to the README, and pq-code-package/tsc#191 to consider archiving it