Align common.h with mlkem-native #702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The common.h in mldsa-native diverged slightly from the mlkem-native one even though by now they are implementing the same features. The primary difference was ordering. Two minor things have been resolved: 1) There was a bad configuration warning missing when MLD_CONFIG_USE_NATIVE_BACKEND_FIPS202 is set, but MLD_CONFIG_FIPS202_BACKEND_FILE is not set. 2) We did not correctly handle when MLD_CONFIG_NO_ASM is set, and MLD_CONFIG_USE_NATIVE_BACKEND_ARITH or MLD_CONFIG_USE_NATIVE_BACKEND_FIPS202 are also set (MLD_CONFIG_NO_ASM should take precedence). Resolves #684 Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
hanno-becker
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common.h in mldsa-native diverged slightly from the mlkem-native one even though by now they are implementing the same features. The primary difference was ordering.
Two minor things have been resolved:
MLD_CONFIG_FIPS202_BACKEND_FILE is not set.
MLD_CONFIG_USE_NATIVE_BACKEND_FIPS202 are also set (MLD_CONFIG_NO_ASM should take precedence).