Example: Add custom_backend #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willieyz
force-pushed
the
custom-backend
branch
8 times, most recently
from
57c9f4f to
d4f46ac
Compare
mkannwischer
requested changes
Nov 18, 2025
examples/custom_backend/mldsa_native/mldsa/src/fips202/native/custom/custom.h
Outdated
Show resolved
Hide resolved
examples/custom_backend/mldsa_native/mldsa/src/fips202/native/custom/src/sha3.c
Show resolved
Hide resolved
examples/custom_backend/mldsa_native/mldsa/src/fips202/native/custom/src/sha3.h
Show resolved
Hide resolved
examples/custom_backend/mldsa_native/mldsa/src/fips202/native/custom/src/sha3.c
Show resolved
Hide resolved
mkannwischer
requested changes
Nov 18, 2025
Contributor
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
Also, please squash your commits. This is one logical change.
willieyz
force-pushed
the
custom-backend
branch
2 times, most recently
from
3ba2351 to
38aa3f0
Compare
mkannwischer
force-pushed
the
custom-backend
branch
from
38aa3f0 to
a1202a6
Compare
mkannwischer
approved these changes
Dec 2, 2025
Contributor
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
LGTM. Thanks @willieyz
mkannwischer
requested changes
Dec 2, 2025
Contributor
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
Sorry, noticed something late.
- This commit add custom backend example, for this example, we add the arithmetic part but skip the arithmetic backend (remove `native` folder), since we decide to disable it. - This commit add a pseudo random number generator, implementing randombytes.h(reference from tests/test_only_rng). - WARNING: The randombytes() implementation used here is for TESTING ONLY. You MUST NOT use this implementation outside of testing. - This commit add custom backend fips202, we use tiny_sha3 here - This commit add `main.c` and symlink `expected_signatures.h` to custom_backend, generate `custom_config.h` from `configs.yml`, also add auto.mk and Makefile. - Add custom_backend to `tests` and `lint` scripts - Add `Readme.md` to custom_backend, reference from mlkem-native Signed-off-by: willieyz <willie.zhao@chelpis.com>
willieyz
force-pushed
the
custom-backend
branch
from
a1202a6 to
d34cb7a
Compare
mkannwischer
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: Example: Add
custom_backend#622This PR adds a custom_backend to mldsa-native, referencing the mlkem-native example: https://github.com/pq-code-package/mlkem-native/tree/main/examples/custom_backend.
The
custom_backendexample creates a mldsa-native build and adds tiny_sha3 as a backend option.Currently,
MLD_NATIVE_FUNC_SUCCESSdoes not exist (prior to the merge of Add Runtime dispatch based on custom CPU capabilities function #607). It is temporarily added to theautogen's exception list with a TODO comment, and also change the macro incustom.hwith0. This should be removed after PR #607 is merged.