Skip to content

Commit 257e8f8

Browse files
committed
ACVP: Update to v1.1.0.41
Update to the recently released ACVP testvectors v1.1.0.41: https://github.com/usnistgov/ACVP-Server/releases/tag/v1.1.0.41 Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
1 parent b6269a2 commit 257e8f8

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

.github/workflows/base.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ jobs:
6969
name: 'aarch64'
7070
- runner: ubuntu-latest
7171
name: 'x86_64'
72-
acvp-version: [v1.1.0.38, v1.1.0.39, v1.1.0.40]
72+
acvp-version: [v1.1.0.39, v1.1.0.40, v1.1.0.41]
7373
exclude:
7474
- {external: true,
7575
target: {

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,18 +92,18 @@ You can run ACVP tests using the [`tests`](./scripts/tests) script or the [ACVP
9292
# Using the tests script
9393
./scripts/tests acvp
9494
# Using a specific ACVP release
95-
./scripts/tests acvp --version v1.1.0.40
95+
./scripts/tests acvp --version v1.1.0.41
9696

9797
# Using the ACVP client directly
9898
python3 ./test/acvp_client.py
99-
python3 ./test/acvp_client.py --version v1.1.0.40
99+
python3 ./test/acvp_client.py --version v1.1.0.41
100100

101101
# Using specific ACVP test vector files (downloaded from the ACVP-Server)
102102
# python3 ./test/acvp_client.py -p {PROMPT}.json -e {EXPECTED_RESULT}.json
103103
# For example, assuming you have run the above
104104
python3 ./test/acvp_client.py \
105-
-p ./test/.acvp-data/v1.1.0.40/files/ML-DSA-sigVer-FIPS204/prompt.json \
106-
-e ./test/.acvp-data/v1.1.0.40/files/ML-DSA-sigVer-FIPS204/expectedResults.json
105+
-p ./test/.acvp-data/v1.1.0.41/files/ML-DSA-sigVer-FIPS204/prompt.json \
106+
-e ./test/.acvp-data/v1.1.0.41/files/ML-DSA-sigVer-FIPS204/expectedResults.json
107107
```
108108

109109
## Benchmarking

scripts/tests

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1085,8 +1085,8 @@ def cli():
10851085
)
10861086
acvp_parser.add_argument(
10871087
"--version",
1088-
default="v1.1.0.40",
1089-
help="ACVP test vector version (default: v1.1.0.40)",
1088+
default="v1.1.0.41",
1089+
help="ACVP test vector version (default: v1.1.0.41)",
10901090
)
10911091

10921092
# examples arguments

test/acvp_client.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
exec_prefix = exec_prefix.split(" ") if exec_prefix != "" else []
2323

2424

25-
def download_acvp_files(version="v1.1.0.40"):
25+
def download_acvp_files(version):
2626
"""Download ACVP test files for the specified version if not present."""
2727
base_url = f"https://raw.githubusercontent.com/usnistgov/ACVP-Server/{version}/gen-val/json-files"
2828

@@ -78,7 +78,7 @@ def loadAcvpData(prompt, expectedResults):
7878
return (prompt, promptData, expectedResults, expectedResultsData)
7979

8080

81-
def loadDefaultAcvpData(version="v1.1.0.40"):
81+
def loadDefaultAcvpData(version):
8282
data_dir = f"test/.acvp-data/{version}/files"
8383
acvp_jsons_for_version = [
8484
(
@@ -418,7 +418,7 @@ def runTest(data, output):
418418
info("ALL GOOD!")
419419

420420

421-
def test(prompt, expected, output, version="v1.1.0.40"):
421+
def test(prompt, expected, output, version):
422422
assert (
423423
prompt is not None or output is None
424424
), "cannot produce output if there is no input"
@@ -453,8 +453,8 @@ def test(prompt, expected, output, version="v1.1.0.40"):
453453
parser.add_argument(
454454
"--version",
455455
"-v",
456-
default="v1.1.0.40",
457-
help="ACVP test vector version (default: v1.1.0.40)",
456+
default="v1.1.0.41",
457+
help="ACVP test vector version (default: v1.1.0.41)",
458458
)
459459
args = parser.parse_args()
460460

0 commit comments

Comments
 (0)