From 0fb8b34e4de05124b10ccaeb750ffe0fb027c9f5 Mon Sep 17 00:00:00 2001 From: Christiaan Landman Date: Wed, 24 Apr 2024 15:51:46 +0200 Subject: [PATCH 1/3] fix setting temp_store to memory --- .changeset/wise-stingrays-float.md | 5 +++++ android/CMakeLists.txt | 1 + 2 files changed, 6 insertions(+) create mode 100644 .changeset/wise-stingrays-float.md diff --git a/.changeset/wise-stingrays-float.md b/.changeset/wise-stingrays-float.md new file mode 100644 index 0000000..968db72 --- /dev/null +++ b/.changeset/wise-stingrays-float.md @@ -0,0 +1,5 @@ +--- +'@journeyapps/react-native-quick-sqlite': patch +--- + +Use memory temp_store diff --git a/android/CMakeLists.txt b/android/CMakeLists.txt index f3eda02..c19ba9d 100644 --- a/android/CMakeLists.txt +++ b/android/CMakeLists.txt @@ -12,6 +12,7 @@ include_directories( add_definitions( ${SQLITE_FLAGS} + -DSQLITE_TEMP_STORE=2 ) add_library( From 89e7399a14a37adae10b1494acc4486c32f16d5f Mon Sep 17 00:00:00 2001 From: Christiaan Landman Date: Wed, 24 Apr 2024 17:22:27 +0200 Subject: [PATCH 2/3] chore: ensuring user defined flags override memory flag and removed pragma temp_store command in test (covered by makeList change) --- .changeset/gorgeous-chefs-do.md | 5 +++++ android/CMakeLists.txt | 2 +- tests/tests/sqlite/rawQueries.spec.ts | 3 --- 3 files changed, 6 insertions(+), 4 deletions(-) create mode 100644 .changeset/gorgeous-chefs-do.md diff --git a/.changeset/gorgeous-chefs-do.md b/.changeset/gorgeous-chefs-do.md new file mode 100644 index 0000000..981e63e --- /dev/null +++ b/.changeset/gorgeous-chefs-do.md @@ -0,0 +1,5 @@ +--- +'@journeyapps/react-native-quick-sqlite': patch +--- + +Fixed order of makefile flags diff --git a/android/CMakeLists.txt b/android/CMakeLists.txt index c19ba9d..90d5ba2 100644 --- a/android/CMakeLists.txt +++ b/android/CMakeLists.txt @@ -11,8 +11,8 @@ include_directories( ) add_definitions( - ${SQLITE_FLAGS} -DSQLITE_TEMP_STORE=2 + ${SQLITE_FLAGS} ) add_library( diff --git a/tests/tests/sqlite/rawQueries.spec.ts b/tests/tests/sqlite/rawQueries.spec.ts index f5d48aa..833558f 100644 --- a/tests/tests/sqlite/rawQueries.spec.ts +++ b/tests/tests/sqlite/rawQueries.spec.ts @@ -566,9 +566,6 @@ export function registerBaseTests() { // Execute the read test whenever a table change ocurred db.registerTablesChangedHook((update) => readTriggerCallbacks.forEach((cb) => cb())); - // Needed for large volumes of data on older Android devices - // https://github.com/margelo/react-native-quick-sqlite/pull/25 - await db.execute('PRAGMA temp_store = memory;') const numberOfUsers = 100_000; await db.writeLock(async (tx) => { await tx.execute('BEGIN'); From ffbccffa183462b4d1de15e6f880fba9c45a8c6a Mon Sep 17 00:00:00 2001 From: Christiaan Landman Date: Thu, 25 Apr 2024 09:33:29 +0200 Subject: [PATCH 3/3] removed changeset file --- .changeset/gorgeous-chefs-do.md | 5 ----- 1 file changed, 5 deletions(-) delete mode 100644 .changeset/gorgeous-chefs-do.md diff --git a/.changeset/gorgeous-chefs-do.md b/.changeset/gorgeous-chefs-do.md deleted file mode 100644 index 981e63e..0000000 --- a/.changeset/gorgeous-chefs-do.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@journeyapps/react-native-quick-sqlite': patch ---- - -Fixed order of makefile flags