cleanup

stevensJourney · stevensJourney · commit a64555ae8205 · 2025-04-15T12:14:32.000+02:00
diff --git a/Demo/PowerSyncExample.xcodeproj/project.pbxproj b/Demo/PowerSyncExample.xcodeproj/project.pbxproj
@@ -41,7 +41,6 @@
 		B6B3698A2C64F4B30033C307 /* Navigation.swift in Sources */ = {isa = PBXBuildFile; fileRef = B6B369892C64F4B30033C307 /* Navigation.swift */; };
 		B6FFD5322D06DA8000EEE60F /* PowerSync in Frameworks */ = {isa = PBXBuildFile; productRef = B6FFD5312D06DA8000EEE60F /* PowerSync */; };
 		BE2F26EC2DA54B2F0080F1AE /* SupabaseRemoteStorage.swift in Sources */ = {isa = PBXBuildFile; fileRef = BE2F26EB2DA54B2A0080F1AE /* SupabaseRemoteStorage.swift */; };
-		BE2F26EE2DA555E10080F1AE /* PhotoPicker.swift in Sources */ = {isa = PBXBuildFile; fileRef = BE2F26ED2DA555DD0080F1AE /* PhotoPicker.swift */; };
 /* End PBXBuildFile section */
 
 /* Begin PBXCopyFilesBuildPhase section */
@@ -109,7 +108,6 @@
 		B6F4213D2BC42F5B0005D0D0 /* sqlite3.c */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.c; name = sqlite3.c; path = "../powersync-kotlin/core/build/interop/sqlite/sqlite3.c"; sourceTree = "<group>"; };
 		B6F421402BC430B60005D0D0 /* sqlite3.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = sqlite3.h; path = "../powersync-kotlin/core/build/interop/sqlite/sqlite3.h"; sourceTree = "<group>"; };
 		BE2F26EB2DA54B2A0080F1AE /* SupabaseRemoteStorage.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SupabaseRemoteStorage.swift; sourceTree = "<group>"; };
-		BE2F26ED2DA555DD0080F1AE /* PhotoPicker.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PhotoPicker.swift; sourceTree = "<group>"; };
 /* End PBXFileReference section */
 
 /* Begin PBXFrameworksBuildPhase section */
@@ -197,7 +195,6 @@
 		B65C4D6B2C60D36700176007 /* Screens */ = {
 			isa = PBXGroup;
 			children = (
-				BE2F26ED2DA555DD0080F1AE /* PhotoPicker.swift */,
 				6A9669032B9EE6FA00B05DCF /* SignInScreen.swift */,
 				B65C4D6C2C60D38B00176007 /* HomeScreen.swift */,
 				B65C4D702C60D7D800176007 /* SignUpScreen.swift */,
@@ -574,7 +571,6 @@
 				B66658632C621CA700159A81 /* AddTodoListView.swift in Sources */,
 				B666585D2C620E9E00159A81 /* WifiIcon.swift in Sources */,
 				6A9669042B9EE6FA00B05DCF /* SignInScreen.swift in Sources */,
-				BE2F26EE2DA555E10080F1AE /* PhotoPicker.swift in Sources */,
 				6A7315BB2B98BDD30004CB17 /* SystemManager.swift in Sources */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
diff --git a/Demo/PowerSyncExample/Components/TodoListView.swift b/Demo/PowerSyncExample/Components/TodoListView.swift
@@ -69,8 +69,11 @@ struct TodoListView: View {
             }
             .onDelete { indexSet in
                 Task {
-                    if let toDelete = indexSet.map({ todos[$0] }).first {
-                        await delete(todo: toDelete)
+                    let selectedItems = indexSet.compactMap { index in
+                        todos.indices.contains(index) ? todos[index] : nil
+                    }
+                    for try todo in selectedItems {
+                        await delete(todo: todo)
                     }
                 }
             }
diff --git a/Demo/PowerSyncExample/PowerSync/Schema.swift b/Demo/PowerSyncExample/PowerSync/Schema.swift
@@ -10,7 +10,7 @@ let lists = Table(
         // ID column is automatically included
         .text("name"),
         .text("created_at"),
-        .text("owner_id"),
+        .text("owner_id")
     ]
 )
 
@@ -26,13 +26,13 @@ let todos = Table(
         Column.text("created_at"),
         Column.text("completed_at"),
         Column.text("created_by"),
-        Column.text("completed_by"),
+        Column.text("completed_by")
     ],
     indexes: [
         Index(
             name: "list_id",
             columns: [IndexedColumn.ascending("list_id")]
-        ),
+        )
     ]
 )
 
diff --git a/Demo/PowerSyncExample/PowerSync/SupabaseConnector.swift b/Demo/PowerSyncExample/PowerSync/SupabaseConnector.swift
@@ -131,4 +131,8 @@ class SupabaseConnector: PowerSyncBackendConnector {
             throw error
         }
     }
+
+    deinit {
+        observeAuthStateChangesTask?.cancel()
+    }
 }
diff --git a/Demo/PowerSyncExample/PowerSync/SystemManager.swift b/Demo/PowerSyncExample/PowerSync/SystemManager.swift
@@ -6,7 +6,7 @@ func getAttachmentsDirectoryPath() throws -> String {
         for: .documentDirectory,
         in: .userDomainMask
     ).first else {
-        throw PowerSyncError.attachmentError("Could not determine attachments directory path")
+        throw PowerSyncAttachmentError.invalidPath("Could not determine attachments directory path")
     }
     return documentsURL.appendingPathComponent("attachments").path
 }
@@ -112,7 +112,7 @@ class SystemManager {
                 sql: "DELETE FROM \(LISTS_TABLE) WHERE id = ?",
                 parameters: [id]
             )
-            
+
             // Attachments linked to these will be archived and deleted eventually
             // Attachments should be deleted explicitly if required
             _ = try transaction.execute(
@@ -184,7 +184,7 @@ class SystemManager {
         if let attachments, let photoId = todo.photoId {
             try await attachments.deleteFile(
                 attachmentId: photoId
-            ) { (tx, _) in
+            ) { tx, _ in
                 try self.deleteTodoInTX(
                     id: todo.id,
                     tx: tx
@@ -199,7 +199,7 @@ class SystemManager {
             }
         }
     }
-    
+
     func deleteTodoInTX(id: String, tx: ConnectionContext) throws {
         _ = try tx.execute(
             sql: "DELETE FROM \(TODOS_TABLE) WHERE id = ?",
diff --git a/Sources/PowerSync/attachments/Attachment.swift b/Sources/PowerSync/attachments/Attachment.swift
@@ -10,6 +10,17 @@ public enum AttachmentState: Int {
     case synced
     /// The attachment is archived
     case archived
+    
+    enum AttachmentStateError: Error {
+        case invalidState(Int)
+    }
+    
+    static func from(_ rawValue: Int) throws -> AttachmentState {
+        guard let state = AttachmentState(rawValue: rawValue) else {
+            throw AttachmentStateError.invalidState(rawValue)
+        }
+        return state
+    }
 }
 
 /// Struct representing an attachment
@@ -23,8 +34,8 @@ public struct Attachment {
     /// Attachment filename, e.g. `[id].jpg`
     public let filename: String
 
-    /// Current attachment state, represented by the raw value of `AttachmentState`
-    public let state: Int
+    /// Current attachment state
+    public let state: AttachmentState
 
     /// Local URI pointing to the attachment file
     public let localUri: String?
@@ -46,7 +57,7 @@ public struct Attachment {
     public init(
         id: String,
         filename: String,
-        state: Int,
+        state: AttachmentState,
         timestamp: Int = 0,
         hasSynced: Int? = 0,
         localUri: String? = nil,
@@ -79,7 +90,7 @@ public struct Attachment {
     /// - Returns: A new `Attachment` with updated values.
     func with(
         filename _: String? = nil,
-        state: Int? = nil,
+        state: AttachmentState? = nil,
         timestamp _: Int = 0,
         hasSynced: Int? = 0,
         localUri: String? = nil,
@@ -108,7 +119,7 @@ public struct Attachment {
         return try Attachment(
             id: cursor.getString(name: "id"),
             filename: cursor.getString(name: "filename"),
-            state: cursor.getLong(name: "state"),
+            state: AttachmentState.from(cursor.getLong(name: "state")),
             timestamp: cursor.getLong(name: "timestamp"),
             hasSynced: cursor.getLongOptional(name: "has_synced"),
             localUri: cursor.getStringOptional(name: "local_uri"),
diff --git a/Sources/PowerSync/attachments/AttachmentContext.swift b/Sources/PowerSync/attachments/AttachmentContext.swift
@@ -205,7 +205,7 @@ public class AttachmentContext {
                 updatedRecord.localUri as Any,
                 updatedRecord.mediaType ?? NSNull(),
                 updatedRecord.size ?? NSNull(),
-                updatedRecord.state,
+                updatedRecord.state.rawValue,
                 updatedRecord.hasSynced ?? 0
             ]
         )
diff --git a/Sources/PowerSync/attachments/AttachmentQueue.swift b/Sources/PowerSync/attachments/AttachmentQueue.swift
@@ -152,7 +152,7 @@ public actor AttachmentQueue {
     /// Starts the attachment sync process
     public func startSync() async throws {
         if closed {
-            throw NSError(domain: "AttachmentError", code: 4, userInfo: [NSLocalizedDescriptionKey: "Attachment queue has been closed"])
+            throw PowerSyncAttachmentError.closed("Cannot start syncing on closed attachment queue")
         }
 
         // Ensure the directory where attachments are downloaded exists
@@ -251,24 +251,24 @@ public actor AttachmentQueue {
                         Attachment(
                             id: item.id,
                             filename: filename,
-                            state: AttachmentState.queuedDownload.rawValue
+                            state: AttachmentState.queuedDownload
                         )
                     )
-                } else if existingQueueItem!.state == AttachmentState.archived.rawValue {
+                } else if existingQueueItem!.state == AttachmentState.archived {
                     // The attachment is present again. Need to queue it for sync.
                     // We might be able to optimize this in future
                     if existingQueueItem!.hasSynced == 1 {
                         // No remote action required, we can restore the record (avoids deletion)
                         attachmentUpdates.append(
-                            existingQueueItem!.with(state: AttachmentState.synced.rawValue)
+                            existingQueueItem!.with(state: AttachmentState.synced)
                         )
                     } else {
                         // The localURI should be set if the record was meant to be downloaded
                         // and has been synced. If it's missing and hasSynced is false then
                         // it must be an upload operation
                         let newState = existingQueueItem!.localUri == nil ?
-                        AttachmentState.queuedDownload.rawValue :
-                        AttachmentState.queuedUpload.rawValue
+                        AttachmentState.queuedDownload :
+                        AttachmentState.queuedUpload
                         
                         attachmentUpdates.append(
                             existingQueueItem!.with(state: newState)
@@ -282,10 +282,10 @@ public actor AttachmentQueue {
              * Archive any items not specified in the watched items except for items pending delete.
              */
             for attachment in currentAttachments {
-                if attachment.state != AttachmentState.queuedDelete.rawValue &&
+                if attachment.state != AttachmentState.queuedDelete &&
                     items.first(where: { $0.id == attachment.id }) == nil {
                     attachmentUpdates.append(
-                        attachment.with(state: AttachmentState.archived.rawValue)
+                        attachment.with(state: AttachmentState.archived)
                     )
                 }
             }
@@ -327,7 +327,7 @@ public actor AttachmentQueue {
                 let attachment = Attachment(
                     id: id,
                     filename: filename,
-                    state: AttachmentState.queuedUpload.rawValue,
+                    state: AttachmentState.queuedUpload,
                     localUri: localUri,
                     mediaType: mediaType,
                     size: fileSize
@@ -352,12 +352,7 @@ public actor AttachmentQueue {
     ) async throws -> Attachment {
         try await attachmentsService.withLock { context in
             guard let attachment = try await context.getAttachment(id: attachmentId) else {
-                // TODO defined errors
-                throw NSError(
-                    domain: "AttachmentError",
-                    code: 5,
-                    userInfo: [NSLocalizedDescriptionKey: "Attachment record with id \(attachmentId) was not found."]
-                )
+                throw PowerSyncAttachmentError.notFound("Attachment record with id \(attachmentId) was not found.")
             }
 
             self.logger.debug("Marking attachment as deleted", tag: nil)
@@ -367,7 +362,7 @@ public actor AttachmentQueue {
                 let updatedAttachment = Attachment(
                     id: attachment.id,
                     filename: attachment.filename,
-                    state: AttachmentState.queuedDelete.rawValue,
+                    state: AttachmentState.queuedDelete,
                     hasSynced: attachment.hasSynced,
                     localUri: attachment.localUri,
                     mediaType: attachment.mediaType,
diff --git a/Sources/PowerSync/attachments/FileManagerLocalStorage.swift b/Sources/PowerSync/attachments/FileManagerLocalStorage.swift
@@ -29,14 +29,14 @@ public class FileManagerStorageAdapter: LocalStorageAdapter {
             let url = URL(fileURLWithPath: filePath)
 
             if !fileManager.fileExists(atPath: filePath) {
-                throw PowerSyncError.fileNotFound(filePath)
+                throw PowerSyncAttachmentError.fileNotFound(filePath)
             }
 
             // Read data from file
             do {
                 return try Data(contentsOf: url)
             } catch {
-                throw PowerSyncError.ioError(error)
+                throw PowerSyncAttachmentError.ioError(error)
             }
         }.value
     }
@@ -74,7 +74,7 @@ public class FileManagerStorageAdapter: LocalStorageAdapter {
     public func copyFile(sourcePath: String, targetPath: String) async throws {
         try await Task {
             if !fileManager.fileExists(atPath: sourcePath) {
-                throw PowerSyncError.fileNotFound(sourcePath)
+                throw PowerSyncAttachmentError.fileNotFound(sourcePath)
             }
 
             // Ensure target directory exists
diff --git a/Sources/PowerSync/attachments/LocalStorage.swift b/Sources/PowerSync/attachments/LocalStorage.swift
@@ -1,9 +1,12 @@
 import Foundation
 
 /// Error type for PowerSync operations
-public enum PowerSyncError: Error {
+public enum PowerSyncAttachmentError: Error {
     /// A general error with an associated message
     case generalError(String)
+    
+    /// Indicates no matching attachment record could be found
+    case notFound(String)
 
     /// Indicates that a file was not found at the given path
     case fileNotFound(String)
@@ -13,9 +16,9 @@ public enum PowerSyncError: Error {
 
     /// The given file or directory path was invalid
     case invalidPath(String)
-
-    /// An error related to attachment handling
-    case attachmentError(String)
+    
+    /// The attachments queue or sub services have been closed
+    case closed(String)
 }
 
 /// Protocol defining an adapter interface for local file storage
@@ -26,7 +29,7 @@ public protocol LocalStorageAdapter {
     ///   - filePath: The full path where the file should be saved.
     ///   - data: The binary data to save.
     /// - Returns: The byte size of the saved file.
-    /// - Throws: `PowerSyncError` if saving fails.
+    /// - Throws: `PowerSyncAttachmentError` if saving fails.
     func saveFile(
         filePath: String,
         data: Data
@@ -38,7 +41,7 @@ public protocol LocalStorageAdapter {
     ///   - filePath: The full path to the file.
     ///   - mediaType: An optional media type (MIME type) to help determine how to handle the file.
     /// - Returns: The contents of the file as `Data`.
-    /// - Throws: `PowerSyncError` if reading fails or the file doesn't exist.
+    /// - Throws: `PowerSyncAttachmentError` if reading fails or the file doesn't exist.
     func readFile(
         filePath: String,
         mediaType: String?
@@ -47,34 +50,34 @@ public protocol LocalStorageAdapter {
     /// Deletes a file at the specified path.
     ///
     /// - Parameter filePath: The full path to the file to delete.
-    /// - Throws: `PowerSyncError` if deletion fails or file doesn't exist.
+    /// - Throws: `PowerSyncAttachmentError` if deletion fails or file doesn't exist.
     func deleteFile(filePath: String) async throws
 
     /// Checks if a file exists at the specified path.
     ///
     /// - Parameter filePath: The path to the file.
     /// - Returns: `true` if the file exists, `false` otherwise.
-    /// - Throws: `PowerSyncError` if checking fails.
+    /// - Throws: `PowerSyncAttachmentError` if checking fails.
     func fileExists(filePath: String) async throws -> Bool
 
     /// Creates a directory at the specified path.
     ///
     /// - Parameter path: The full path to the directory.
-    /// - Throws: `PowerSyncError` if creation fails.
+    /// - Throws: `PowerSyncAttachmentError` if creation fails.
     func makeDir(path: String) async throws
 
     /// Removes a directory at the specified path.
     ///
     /// - Parameter path: The full path to the directory.
-    /// - Throws: `PowerSyncError` if removal fails.
+    /// - Throws: `PowerSyncAttachmentError` if removal fails.
     func rmDir(path: String) async throws
 
     /// Copies a file from the source path to the target path.
     ///
     /// - Parameters:
     ///   - sourcePath: The original file path.
     ///   - targetPath: The destination file path.
-    /// - Throws: `PowerSyncError` if the copy operation fails.
+    /// - Throws: `PowerSyncAttachmentError` if the copy operation fails.
     func copyFile(
         sourcePath: String,
         targetPath: String
@@ -87,7 +90,7 @@ public extension LocalStorageAdapter {
     ///
     /// - Parameter filePath: The full path to the file.
     /// - Returns: The contents of the file as `Data`.
-    /// - Throws: `PowerSyncError` if reading fails.
+    /// - Throws: `PowerSyncAttachmentError` if reading fails.
     func readFile(filePath: String) async throws -> Data {
         return try await readFile(filePath: filePath, mediaType: nil)
     }
diff --git a/Sources/PowerSync/attachments/README.md b/Sources/PowerSync/attachments/README.md
@@ -94,7 +94,7 @@ func getAttachmentsDirectoryPath() throws -> String {
         for: .documentDirectory,
         in: .userDomainMask
     ).first else {
-        throw PowerSyncError.attachmentError("Could not determine attachments directory path")
+        throw PowerSyncAttachmentError.attachmentError("Could not determine attachments directory path")
     }
     return documentsURL.appendingPathComponent("attachments").path
 }
diff --git a/Sources/PowerSync/attachments/SyncingService.swift b/Sources/PowerSync/attachments/SyncingService.swift

Original file line number	Diff line number	Diff line change
`@@ -69,8 +69,11 @@ struct TodoListView: View {`
`69`	`69`	`}`
`70`	`70`	`.onDelete { indexSet in`
`71`	`71`	`Task {`
`72`		`- if let toDelete = indexSet.map({ todos[$0] }).first {`
`73`		`- await delete(todo: toDelete)`
	`72`	`+ let selectedItems = indexSet.compactMap { index in`
	`73`	`+ todos.indices.contains(index) ? todos[index] : nil`
	`74`	`+ }`
	`75`	`+ for try todo in selectedItems {`
	`76`	`+ await delete(todo: todo)`
`74`	`77`	`}`
`75`	`78`	`}`
`76`	`79`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ let lists = Table(`
`10`	`10`	`// ID column is automatically included`
`11`	`11`	`.text("name"),`
`12`	`12`	`.text("created_at"),`
`13`		`- .text("owner_id"),`
	`13`	`+ .text("owner_id")`
`14`	`14`	`]`
`15`	`15`	`)`
`16`	`16`
`@@ -26,13 +26,13 @@ let todos = Table(`
`26`	`26`	`Column.text("created_at"),`
`27`	`27`	`Column.text("completed_at"),`
`28`	`28`	`Column.text("created_by"),`
`29`		`- Column.text("completed_by"),`
	`29`	`+ Column.text("completed_by")`
`30`	`30`	`],`
`31`	`31`	`indexes: [`
`32`	`32`	`Index(`
`33`	`33`	`name: "list_id",`
`34`	`34`	`columns: [IndexedColumn.ascending("list_id")]`
`35`		`- ),`
	`35`	`+ )`
`36`	`36`	`]`
`37`	`37`	`)`
`38`	`38`
Original file line number	Diff line number	Diff line change
`@@ -131,4 +131,8 @@ class SupabaseConnector: PowerSyncBackendConnector {`
`131`	`131`	`throw error`
`132`	`132`	`}`
`133`	`133`	`}`
	`134`	`+`
	`135`	`+ deinit {`
	`136`	`+ observeAuthStateChangesTask?.cancel()`
	`137`	`+ }`
`134`	`138`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ func getAttachmentsDirectoryPath() throws -> String {`
`6`	`6`	`for: .documentDirectory,`
`7`	`7`	`in: .userDomainMask`
`8`	`8`	`).first else {`
`9`		`- throw PowerSyncError.attachmentError("Could not determine attachments directory path")`
	`9`	`+ throw PowerSyncAttachmentError.invalidPath("Could not determine attachments directory path")`
`10`	`10`	`}`
`11`	`11`	`return documentsURL.appendingPathComponent("attachments").path`
`12`	`12`	`}`
`@@ -112,7 +112,7 @@ class SystemManager {`
`112`	`112`	`sql: "DELETE FROM \(LISTS_TABLE) WHERE id = ?",`
`113`	`113`	`parameters: [id]`
`114`	`114`	`)`
`115`		`-`
	`115`	`+`
`116`	`116`	`// Attachments linked to these will be archived and deleted eventually`
`117`	`117`	`// Attachments should be deleted explicitly if required`
`118`	`118`	`_ = try transaction.execute(`
`@@ -184,7 +184,7 @@ class SystemManager {`
`184`	`184`	`if let attachments, let photoId = todo.photoId {`
`185`	`185`	`try await attachments.deleteFile(`
`186`	`186`	`attachmentId: photoId`
`187`		`- ) { (tx, _) in`
	`187`	`+ ) { tx, _ in`
`188`	`188`	`try self.deleteTodoInTX(`
`189`	`189`	`id: todo.id,`
`190`	`190`	`tx: tx`
`@@ -199,7 +199,7 @@ class SystemManager {`
`199`	`199`	`}`
`200`	`200`	`}`
`201`	`201`	`}`
`202`		`-`
	`202`	`+`
`203`	`203`	`func deleteTodoInTX(id: String, tx: ConnectionContext) throws {`
`204`	`204`	`_ = try tx.execute(`
`205`	`205`	`sql: "DELETE FROM \(TODOS_TABLE) WHERE id = ?",`
Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,7 @@ public class AttachmentContext {`
`205`	`205`	`updatedRecord.localUri as Any,`
`206`	`206`	`updatedRecord.mediaType ?? NSNull(),`
`207`	`207`	`updatedRecord.size ?? NSNull(),`
`208`		`- updatedRecord.state,`
	`208`	`+ updatedRecord.state.rawValue,`
`209`	`209`	`updatedRecord.hasSynced ?? 0`
`210`	`210`	`]`
`211`	`211`	`)`
Original file line number	Diff line number	Diff line change
`@@ -29,14 +29,14 @@ public class FileManagerStorageAdapter: LocalStorageAdapter {`
`29`	`29`	`let url = URL(fileURLWithPath: filePath)`
`30`	`30`
`31`	`31`	`if !fileManager.fileExists(atPath: filePath) {`
`32`		`- throw PowerSyncError.fileNotFound(filePath)`
	`32`	`+ throw PowerSyncAttachmentError.fileNotFound(filePath)`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`// Read data from file`
`36`	`36`	`do {`
`37`	`37`	`return try Data(contentsOf: url)`
`38`	`38`	`} catch {`
`39`		`- throw PowerSyncError.ioError(error)`
	`39`	`+ throw PowerSyncAttachmentError.ioError(error)`
`40`	`40`	`}`
`41`	`41`	`}.value`
`42`	`42`	`}`
`@@ -74,7 +74,7 @@ public class FileManagerStorageAdapter: LocalStorageAdapter {`
`74`	`74`	`public func copyFile(sourcePath: String, targetPath: String) async throws {`
`75`	`75`	`try await Task {`
`76`	`76`	`if !fileManager.fileExists(atPath: sourcePath) {`
`77`		`- throw PowerSyncError.fileNotFound(sourcePath)`
	`77`	`+ throw PowerSyncAttachmentError.fileNotFound(sourcePath)`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`// Ensure target directory exists`