deprecate userId

Author: stevensJourney

CHANGELOG.md

@@ -4,6 +4,8 @@
 
 - Improved the stability of watched queries. Watched queries were previously susceptible to runtime crashes if an exception was thrown in the update stream. Errors are now gracefully handled.
 
+- Deprecated `PowerSyncCredentials` `userId` field. This value is not used by the PowerSync service.
+
 - Added `readLock` and `writeLock` APIs. These methods allow obtaining a SQLite connection context without starting a transaction.
 
 - Removed references to the PowerSync Kotlin SDK from all public API protocols. Dedicated Swift protocols are now defined. These protocols align better with Swift primitives. See the `BRAKING CHANGES` section for more details. Updated protocols include:

Sources/PowerSync/PowerSyncCredentials.swift

@@ -12,22 +12,35 @@ public struct PowerSyncCredentials: Codable {
     public let token: String
 
     /// User ID.
-    public let userId: String?
+    @available(*, deprecated, message: "This value is not used anymore.")
+    public let userId: String? = nil
+    
+    enum CodingKeys: String, CodingKey {
+           case endpoint
+            case token
+       }
+
+    @available(*, deprecated, message: "Use init(endpoint:token:) instead. `userId` is no longer used.")
+    public init(
+        endpoint: String,
+        token: String,
+        userId: String? = nil) {
+        self.endpoint = endpoint
+        self.token = token
+    }
 
-    public init(endpoint: String, token: String, userId: String? = nil) {
+    public init(endpoint: String, token: String) {
         self.endpoint = endpoint
         self.token = token
-        self.userId = userId
     }
 
     internal init(kotlin: KotlinPowerSyncCredentials) {
         self.endpoint = kotlin.endpoint
         self.token = kotlin.token
-        self.userId = kotlin.userId
     }
 
     internal var kotlinCredentials: KotlinPowerSyncCredentials {
-        return KotlinPowerSyncCredentials(endpoint: endpoint, token: token, userId: userId)
+        return KotlinPowerSyncCredentials(endpoint: endpoint, token: token, userId: nil)
     }
 
     public func endpointUri(path: String) -> String {
@@ -37,6 +50,6 @@ public struct PowerSyncCredentials: Codable {
 
 extension PowerSyncCredentials: CustomStringConvertible {
     public var description: String {
-        return "PowerSyncCredentials<endpoint: \(endpoint) userId: \(userId ?? "nil")>"
+        return "PowerSyncCredentials<endpoint: \(endpoint))>"
     }
 }

Sources/PowerSync/attachments/AttachmentContext.swift

@@ -206,12 +206,12 @@ open class AttachmentContext {
                 updatedRecord.id,
                 updatedRecord.timestamp,
                 updatedRecord.filename,
-                updatedRecord.localUri ?? NSNull(),
-                updatedRecord.mediaType ?? NSNull(),
-                updatedRecord.size ?? NSNull(),
+                updatedRecord.localUri,
+                updatedRecord.mediaType,
+                updatedRecord.size,
                 updatedRecord.state.rawValue,
                 updatedRecord.hasSynced ?? 0,
-                updatedRecord.metaData ?? NSNull()
+                updatedRecord.metaData
             ]
         )