Set count_at_last in SDK

Author: simolus3

crates/core/src/sync_local.rs

@@ -259,9 +259,6 @@ GROUP BY b.row_type, b.row_id",
     fn set_last_applied_op(&self) -> Result<(), SQLiteError> {
         match &self.partial {
             Some(partial) => {
-                // Note: This one deliberately doesn't reset count_since_last or updates
-                // count_at_last! We want a download progress to always cover a complete sync
-                // checkpoint instead of resetting for partial completions.
                 // language=SQLite
                 let updated = self
                     .db
@@ -280,10 +277,8 @@ GROUP BY b.row_type, b.row_id",
                 self.db
                     .exec_safe(
                         "UPDATE ps_buckets
-                                SET last_applied_op = last_op,
-                                    count_since_last = 0,
-                                    count_at_last = count_at_last + count_since_last
-                                WHERE (last_applied_op != last_op) OR count_since_last",
+                                SET last_applied_op = last_op
+                                WHERE last_applied_op != last_op",
                     )
                     .into_db_result(self.db)?;
             }

dart/test/sync_test.dart

@@ -278,12 +278,11 @@ void main() {
         isTrue,
       );
 
-      // Despite committing data, a partial checkpoint should not clear download
-      // progress stats.
+      // Running partial or complete checkpoints should not reset stats, client
+      // SDKs are responsible for that.
       expectProgress(0, 2);
       expect(db.select('SELECT * FROM items'), isNotEmpty);
 
-      // Full checkpoint sets count_at_last
       expect(
         pushCheckpointComplete(
           '2',
@@ -292,19 +291,25 @@ void main() {
         ),
         isTrue,
       );
+      expectProgress(0, 2);
+
+      db.execute('''
+UPDATE ps_buckets SET count_since_last = 0, count_at_last = ?1->name
+  WHERE ?1->name IS NOT NULL
+''', [
+        json.encode({bucket: 2}),
+      ]);
       expectProgress(2, 0);
 
       // Run another iteration of this
       pushSyncData(bucket, '3', 'row-3', 'PUT', {'col': 'hi'});
       expectProgress(2, 1);
-      expect(
-        pushCheckpointComplete(
-          '3',
-          null,
-          [_bucketChecksum(bucket, 1, checksum: 0)],
-        ),
-        isTrue,
-      );
+      db.execute('''
+UPDATE ps_buckets SET count_since_last = 0, count_at_last = ?1->name
+  WHERE ?1->name IS NOT NULL
+''', [
+        json.encode({bucket: 3}),
+      ]);
       expectProgress(3, 0);
     });
   });