Skip to content

Conversation

@KhudaDad414
Copy link

@KhudaDad414 KhudaDad414 commented Nov 5, 2025

Support postman CLI for code generation.

@KhudaDad414 KhudaDad414 changed the title fix some missed options in different files Support Postman CLI for Code generation. Nov 5, 2025
@KhudaDad414 KhudaDad414 changed the title Support Postman CLI for Code generation. Support Postman CLI for Code generation Nov 5, 2025
@shamasis shamasis self-requested a review November 5, 2025 15:20
var indent, trim, headersData, body, redirect, timeout, multiLine,
format, snippet, quiet, url, quoteType, maxRedirects, followOriginalHttpMethod;

redirect = options.followRedirect;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can ask AI to cross check options

  1. list all options
  2. cross check with usage here
  3. track what were not used

Copy link
Member

@shamasis shamasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is isolated enough to not be catastrophic,

var self;

self = module.exports = {
convert: function (request, options, callback) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be worth breaking down this function into smaller ones with each function handling one aspect (headers, auth, body, proxy) and we can just chain them together. might make it easier to add a new aspect tomrrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants