Skip to content

Commit 4eee6fb

Browse files
committed
Use regex instead of string in replace function
1 parent 66399bc commit 4eee6fb

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

codegens/python-http.client/lib/util/parseBody.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
var _ = require('../lodash'),
22
sanitize = require('./sanitize').sanitize,
33
path = require('path'),
4-
trueToken = '__PYTHON#%~True__',
5-
falseToken = '__PYTHON#%~False__',
6-
nullToken = '__PYTHON#%~NULL__';
4+
trueToken = '__PYTHON#%0True__',
5+
falseToken = '__PYTHON#%0False__',
6+
nullToken = '__PYTHON#%0NULL__';
77

88
/**
99
* Convert true, false and null to Python equivalent True, False and None
@@ -31,9 +31,9 @@ function replacer (key, value) {
3131
*/
3232
function pythonify (jsonBody, indentCount) {
3333
return JSON.stringify(jsonBody, replacer, indentCount)
34-
.replace(`"${trueToken}"`, 'True')
35-
.replace(`"${falseToken}"`, 'False')
36-
.replace(`"${nullToken}"`, 'None');
34+
.replace(new RegExp(`"${trueToken}"`, 'g'), 'True')
35+
.replace(new RegExp(`"${falseToken}"`, 'g'), 'False')
36+
.replace(new RegExp(`"${nullToken}"`, 'g'), 'None');
3737
}
3838

3939
/**

codegens/python-requests/lib/util/parseBody.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
var _ = require('../lodash'),
22
sanitize = require('./sanitize').sanitize,
3-
trueToken = '__PYTHON#%~True__',
4-
falseToken = '__PYTHON#%~False__',
5-
nullToken = '__PYTHON#%~NULL__',
3+
trueToken = '__PYTHON#%0True__',
4+
falseToken = '__PYTHON#%0False__',
5+
nullToken = '__PYTHON#%0NULL__',
66
contentTypeHeaderMap = {
77
'aac': 'audio/aac',
88
'abw': 'application/x-abiword',
@@ -103,9 +103,9 @@ function replacer (key, value) {
103103
*/
104104
function pythonify (jsonBody, indentCount) {
105105
return JSON.stringify(jsonBody, replacer, indentCount)
106-
.replace(`"${trueToken}"`, 'True')
107-
.replace(`"${falseToken}"`, 'False')
108-
.replace(`"${nullToken}"`, 'None');
106+
.replace(new RegExp(`"${trueToken}"`, 'g'), 'True')
107+
.replace(new RegExp(`"${falseToken}"`, 'g'), 'False')
108+
.replace(new RegExp(`"${nullToken}"`, 'g'), 'None');
109109
}
110110

111111
/**

0 commit comments

Comments
 (0)