This repository was archived by the owner on Jul 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
Add kube inject command #206
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a9936ef to
642c84d
Compare
Contributor
versilis
added a commit
that referenced
this pull request
Mar 24, 2023
This PR adds utilities for injecting Kubernetes deployments to be used with #206. The main component is the `Injector` interface which provides the functionality to traverse YAML files (including those with multiple resources using the `---` directive), and inject sidecar containers into any found Deployments.
…e-inject # Conflicts: # cmd/internal/kube/injector/injector.go
liujed
reviewed
Mar 25, 2023
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable. Before I approve, I have some questions about the intended output for both the secrets file and the Kubernetes YAML. The part I am least sure about is the output of createSidecar, but I assume all this will be (or has been) tested with a Kubernetes instance (or, at the very least, compared with a known working Kubernetes YAML with Akita installed).
Co-authored-by: Jed Liu <liujed@users.noreply.github.com>
Co-authored-by: Jed Liu <liujed@users.noreply.github.com>
liujed
approved these changes
Mar 25, 2023
Co-authored-by: Jed Liu <liujed@users.noreply.github.com>
versilis
added a commit
that referenced
this pull request
Mar 27, 2023
This adds two new commands, `akita kube inject` and `akita kube secret`, for simplifying the process of installing Akita as a sidecar in Kubernetes Deployments. Changes include: - #202 - #207 - #206 --------- Signed-off-by: versilis <versilis@akitasoftware.com> Co-authored-by: Mark Gritter <mgritter@akitasoftware.com> Co-authored-by: Jed Liu <liujed@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
3 – Normal Priority
Non-blocking review—please turn around quickly
Needs Review
PRs with this label are picked up by the Slack integration
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new command
akita kube injectthat can be used to manually inject Kuberentes YAML configuration files. Along with injecting deployments, it also can generate a secret to a file or stdout with the use of the--secretflag.This PR depends on #207 for its injection functionality.
Example usages:
Example Output (w/merged Secrets):