Insert new item in the end of the page if it is the biggest item

Author: za-arthur

src/rumdatapage.c

@@ -409,7 +409,7 @@ rumMergeItemPointers(RumState * rumstate, AttrNumber attno, RumKey * dst,
 
 /*
  * Checks, should we move to right link...
- * Compares inserting itemp pointer with right bound of current page
+ * Compares inserting item pointer with right bound of current page
  */
 static bool
 dataIsMoveRight(RumBtree btree, Page page)
@@ -909,7 +909,9 @@ dataPlaceToPage(RumBtree btree, Page page, OffsetNumber off)
 				if (stopAppend)
 					 /* there is no free space on page */
 					break;
-				else if (RumPageRightMost(page))
+				else if (RumPageRightMost(page) ||
+						 /* Insert item in the end of the page */
+						 off > maxoff)
 					/* force insertion of new item */
 					cmp = 1;
 				else if ((cmp = compareRumKey(btree->rumstate, btree->entryAttnum,
@@ -1211,7 +1213,7 @@ dataSplitPageInternal(RumBtree btree, Buffer lbuf, Buffer rbuf,
 	OffsetNumber separator;
 	RumKey*		bound;
 	Page		newlPage = PageGetTempPageCopy(BufferGetPage(lbuf));
-	RumKey		 oldbound = *RumDataPageGetRightBound(newlPage);
+	RumKey		oldbound = *RumDataPageGetRightBound(newlPage);
 	int			sizeofitem = sizeof(PostingItem);
 	OffsetNumber maxoff = RumPageGetOpaque(newlPage)->maxoff;
 	Size		pageSize = PageGetPageSize(newlPage);

src/ruminsert.c

@@ -99,9 +99,9 @@ createPostingTree(RumState * rumstate, OffsetNumber attnum, Relation index,
  * are making a leaf-level key entry containing a posting list of nipd items.
  * If the caller is actually trying to make a posting-tree entry, non-leaf
  * entry, or pending-list entry, it should pass nipd = 0 and then overwrite
- * the t_tid fields as necessary.  In any case, ipd can be NULL to skip
+ * the t_tid fields as necessary.  In any case, items can be NULL to skip
  * copying any itempointers into the posting list; the caller is responsible
- * for filling the posting list afterwards, if ipd = NULL and nipd > 0.
+ * for filling the posting list afterwards, if items = NULL and nipd > 0.
  */
 static IndexTuple
 RumFormTuple(RumState * rumstate,
@@ -348,7 +348,6 @@ buildFreshLeafTuple(RumState * rumstate,
 		if (size >= RumDataPageSize)
 			itemsCount--;
 
-
 		/*
 		 * Build posting-tree-only result tuple.  We do this first so as to
 		 * fail quickly if the key is too big.