"fix" unstable backup.BackupTest.test_backup_with_less_privileges_role (disable tests in archive mode from replica) (#414)

Author: kulaginm

tests/backup.py

@@ -2518,45 +2518,47 @@ def test_backup_with_less_privileges_role(self):
 
         replica.slow_start(replica=True)
 
+        # Archive backups from replica in this test are disabled,
+        # because WAL archiving on replica in idle DB in PostgreSQL is broken:
+        # replica will not archive the previous WAL until it receives new records in the next WAL file,
+        # this "lazy" archiving can be seen in src/backend/replication/walreceiver.c:XLogWalRcvWrite()
+        # (see !XLByteInSeg checking and XLogArchiveNotify() calling).
+        #
         # self.switch_wal_segment(node)
-        # self.switch_wal_segment(node)
-
-        self.backup_node(
-            backup_dir, 'replica', replica,
-            datname='backupdb', options=['-U', 'backup'])
+        #self.backup_node(
+        #    backup_dir, 'replica', replica,
+        #    datname='backupdb', options=['-U', 'backup'])
 
         # stream full backup from replica
         self.backup_node(
             backup_dir, 'replica', replica,
             datname='backupdb', options=['--stream', '-U', 'backup'])
 
-#        self.switch_wal_segment(node)
-
         # PAGE backup from replica
-        self.switch_wal_segment(node)
-        self.backup_node(
-            backup_dir, 'replica', replica, backup_type='page',
-            datname='backupdb', options=['-U', 'backup', '--archive-timeout=30s'])
+        #self.switch_wal_segment(node)
+        #self.backup_node(
+        #    backup_dir, 'replica', replica, backup_type='page',
+        #    datname='backupdb', options=['-U', 'backup', '--archive-timeout=30s'])
 
         self.backup_node(
             backup_dir, 'replica', replica, backup_type='page',
             datname='backupdb', options=['--stream', '-U', 'backup'])
 
         # DELTA backup from replica
-        self.switch_wal_segment(node)
-        self.backup_node(
-            backup_dir, 'replica', replica, backup_type='delta',
-            datname='backupdb', options=['-U', 'backup'])
+        #self.switch_wal_segment(node)
+        #self.backup_node(
+        #    backup_dir, 'replica', replica, backup_type='delta',
+        #    datname='backupdb', options=['-U', 'backup'])
         self.backup_node(
             backup_dir, 'replica', replica, backup_type='delta',
             datname='backupdb', options=['--stream', '-U', 'backup'])
 
         # PTRACK backup from replica
         if self.ptrack:
-            self.switch_wal_segment(node)
-            self.backup_node(
-                backup_dir, 'replica', replica, backup_type='ptrack',
-                datname='backupdb', options=['-U', 'backup'])
+            #self.switch_wal_segment(node)
+            #self.backup_node(
+            #    backup_dir, 'replica', replica, backup_type='ptrack',
+            #    datname='backupdb', options=['-U', 'backup'])
             self.backup_node(
                 backup_dir, 'replica', replica, backup_type='ptrack',
                 datname='backupdb', options=['--stream', '-U', 'backup'])