[refactor] remove pgut_fopen()

Author: kulaginm

src/utils/configuration.c

@@ -555,8 +555,14 @@ config_read_opt(const char *path, ConfigOption options[], int elevel,
 	if (!options)
 		return parsed_options;
 
-	if ((fp = pgut_fopen(path, "rt", missing_ok)) == NULL)
-		return parsed_options;
+	if ((fp = fio_open_stream(path, FIO_BACKUP_HOST)) == NULL)
+	{
+			if (missing_ok && errno == ENOENT)
+					return parsed_options;
+
+			elog(ERROR, "could not open file \"%s\": %s",
+							path, strerror(errno));
+	}
 
 	while (fgets(buf, lengthof(buf), fp))
 	{

src/utils/pgut.c

@@ -980,7 +980,7 @@ pgut_strndup(const char *str, size_t n)
 /*
  * Allocates new string, that contains part of filepath string minus trailing filename string
  * If trailing filename string not found, returns copy of filepath.
- * Result must be free by caller.
+ * Result must be freed by caller.
  */
 char *
 pgut_str_strip_trailing_filename(const char *filepath, const char *filename)
@@ -993,23 +993,6 @@ pgut_str_strip_trailing_filename(const char *filepath, const char *filename)
 		return pgut_strndup(filepath, fp_len);
 }
 
-FILE *
-pgut_fopen(const char *path, const char *mode, bool missing_ok)
-{
-	FILE *fp;
-
-	if ((fp = fio_open_stream(path, FIO_BACKUP_HOST)) == NULL)
-	{
-		if (missing_ok && errno == ENOENT)
-			return NULL;
-
-		elog(ERROR, "could not open file \"%s\": %s",
-			path, strerror(errno));
-	}
-
-	return fp;
-}
-
 #ifdef WIN32
 static int select_win32(int nfds, fd_set *readfds, fd_set *writefds, fd_set *exceptfds, const struct timeval * timeout);
 #define select		select_win32

src/utils/pgut.h

@@ -69,11 +69,6 @@ extern char *pgut_str_strip_trailing_filename(const char *filepath, const char *
 #define pgut_new0(type)			((type *) pgut_malloc0(sizeof(type)))
 #define pgut_newarray(type, n)	((type *) pgut_malloc(sizeof(type) * (n)))
 
-/*
- * file operations
- */
-extern FILE *pgut_fopen(const char *path, const char *mode, bool missing_ok);
-
 /*
  * Assert
  */