Skip to content

Commit 16b9b36

Browse files
committed
bugfix: change units for archive-timeout & archive-timeout to seconds, log-rotation-age to minutes
1 parent 3769efd commit 16b9b36

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/configure.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ readBackupCatalogConfigFile(void)
245245
{ 's', 0, "error-log-filename", &(config->error_log_filename), SOURCE_CMDLINE },
246246
{ 's', 0, "log-directory", &(config->log_directory), SOURCE_CMDLINE },
247247
{ 'U', 0, "log-rotation-size", &(config->log_rotation_size), SOURCE_CMDLINE, SOURCE_DEFAULT, OPTION_UNIT_KB },
248-
{ 'U', 0, "log-rotation-age", &(config->log_rotation_age), SOURCE_CMDLINE, SOURCE_DEFAULT, OPTION_UNIT_MS },
248+
{ 'U', 0, "log-rotation-age", &(config->log_rotation_age), SOURCE_CMDLINE, SOURCE_DEFAULT, OPTION_UNIT_MIN },
249249
/* connection options */
250250
{ 's', 0, "pgdata", &(config->pgdata), SOURCE_FILE_STRICT },
251251
{ 's', 0, "pgdatabase", &(config->pgdatabase), SOURCE_FILE_STRICT },
@@ -257,14 +257,14 @@ readBackupCatalogConfigFile(void)
257257
{ 's', 0, "master-port", &(config->master_port), SOURCE_FILE_STRICT },
258258
{ 's', 0, "master-db", &(config->master_db), SOURCE_FILE_STRICT },
259259
{ 's', 0, "master-user", &(config->master_user), SOURCE_FILE_STRICT },
260-
{ 'u', 0, "replica-timeout", &(config->replica_timeout), SOURCE_CMDLINE, SOURCE_DEFAULT, OPTION_UNIT_MS },
260+
{ 'u', 0, "replica-timeout", &(config->replica_timeout), SOURCE_CMDLINE, SOURCE_DEFAULT, OPTION_UNIT_S },
261261
/* other options */
262262
{ 'U', 0, "system-identifier", &(config->system_identifier), SOURCE_FILE_STRICT },
263263
#if PG_VERSION_NUM >= 110000
264264
{'u', 0, "xlog-seg-size", &config->xlog_seg_size, SOURCE_FILE_STRICT},
265265
#endif
266266
/* archive options */
267-
{ 'u', 0, "archive-timeout", &(config->archive_timeout), SOURCE_CMDLINE, SOURCE_DEFAULT, OPTION_UNIT_MS },
267+
{ 'u', 0, "archive-timeout", &(config->archive_timeout), SOURCE_CMDLINE, SOURCE_DEFAULT, OPTION_UNIT_S },
268268
{0}
269269
};
270270

src/pg_probackup.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ static pgut_option options[] =
199199
{ 's', 143, "error-log-filename", &error_log_filename, SOURCE_CMDLINE },
200200
{ 's', 144, "log-directory", &log_directory, SOURCE_CMDLINE },
201201
{ 'U', 145, "log-rotation-size", &log_rotation_size, SOURCE_CMDLINE, SOURCE_DEFAULT, OPTION_UNIT_KB },
202-
{ 'U', 146, "log-rotation-age", &log_rotation_age, SOURCE_CMDLINE, SOURCE_DEFAULT, OPTION_UNIT_MS },
202+
{ 'U', 146, "log-rotation-age", &log_rotation_age, SOURCE_CMDLINE, SOURCE_DEFAULT, OPTION_UNIT_MIN },
203203
/* connection options */
204204
{ 's', 'd', "pgdatabase", &pgut_dbname, SOURCE_CMDLINE },
205205
{ 's', 'h', "pghost", &host, SOURCE_CMDLINE },

0 commit comments

Comments
 (0)