introduce view 'pathman_partition_list', pl/pgSQL refactoring, extract pl_range_funcs.c & pl_hash_funcs.c from pl_funcs.c

Author: funbringer

Makefile

@@ -1,10 +1,11 @@
 # contrib/pg_pathman/Makefile
 
 MODULE_big = pg_pathman
-OBJS = src/init.o src/relation_info.o src/utils.o src/partition_filter.o src/runtimeappend.o \
-	src/runtime_merge_append.o src/pg_pathman.o src/rangeset.o src/pl_funcs.o \
-	src/pathman_workers.o src/hooks.o src/nodes_common.o src/xact_handling.o \
-	src/copy_stmt_hooking.o src/pg_compat.o $(WIN32RES)
+OBJS = src/init.o src/relation_info.o src/utils.o src/partition_filter.o \
+	src/runtimeappend.o src/runtime_merge_append.o src/pg_pathman.o src/rangeset.o \
+	src/pl_funcs.o src/pl_range_funcs.o src/pl_hash_funcs.o src/pathman_workers.o \
+	src/hooks.o src/nodes_common.o src/xact_handling.o src/copy_stmt_hooking.o \
+	src/pg_compat.o $(WIN32RES)
 
 EXTENSION = pg_pathman
 EXTVERSION = 1.0

init.sql

@@ -77,9 +77,6 @@ SELECT pg_catalog.pg_extension_config_dump('@extschema@.pathman_config', '');
 SELECT pg_catalog.pg_extension_config_dump('@extschema@.pathman_config_params', '');
 
 
-CREATE OR REPLACE FUNCTION @extschema@.invalidate_relcache(relid OID)
-RETURNS VOID AS 'pg_pathman' LANGUAGE C STRICT;
-
 CREATE OR REPLACE FUNCTION @extschema@.partitions_count(relation REGCLASS)
 RETURNS INT AS
 $$
@@ -150,6 +147,25 @@ END
 $$
 LANGUAGE plpgsql;
 
+/*
+ * Show all existing parents and partitions.
+ */
+CREATE OR REPLACE FUNCTION @extschema@.show_partition_list()
+RETURNS TABLE (
+	 parent		REGCLASS,
+	 partition	REGCLASS,
+	 parttype	INT4,
+	 partattr	TEXT,
+	 range_min	TEXT,
+	 range_max	TEXT)
+AS 'pg_pathman', 'show_partition_list_internal' LANGUAGE C STRICT;
+
+/*
+ * View for show_partition_list().
+ */
+CREATE OR REPLACE VIEW @extschema@.pathman_partition_list
+AS SELECT * FROM @extschema@.show_partition_list();
+
 /*
  * Show all existing concurrent partitioning tasks.
  */
@@ -160,8 +176,8 @@ RETURNS TABLE (
 	dbid		OID,
 	relid		REGCLASS,
 	processed	INT,
-	status		TEXT
-) AS 'pg_pathman', 'show_concurrent_part_tasks_internal' LANGUAGE C STRICT;
+	status		TEXT)
+AS 'pg_pathman', 'show_concurrent_part_tasks_internal' LANGUAGE C STRICT;
 
 /*
  * View for show_concurrent_part_tasks().
@@ -348,7 +364,7 @@ $$
 LANGUAGE plpgsql;
 
 /*
- * Returns relname without quotes or something
+ * Returns relname without quotes or something.
  */
 CREATE OR REPLACE FUNCTION @extschema@.get_plain_schema_and_relname(
 	cls				REGCLASS,
@@ -366,7 +382,7 @@ $$
 LANGUAGE plpgsql STRICT;
 
 /*
- * Returns schema-qualified name for table
+ * Returns the schema-qualified name of table.
  */
 CREATE OR REPLACE FUNCTION @extschema@.get_schema_qualified_name(
 	cls			REGCLASS,
@@ -385,7 +401,7 @@ $$
 LANGUAGE plpgsql STRICT;
 
 /*
- * Validates relation name. It must be schema qualified
+ * Validates relation name. It must be schema qualified.
  */
 CREATE OR REPLACE FUNCTION @extschema@.validate_relname(
 	cls		REGCLASS)
@@ -407,7 +423,7 @@ $$
 LANGUAGE plpgsql;
 
 /*
- * Check if two relations have equal structures
+ * Check if two relations have equal structures.
  */
 CREATE OR REPLACE FUNCTION @extschema@.validate_relations_equality(
 	relation1 OID, relation2 OID)
@@ -439,7 +455,7 @@ $$
 LANGUAGE plpgsql;
 
 /*
- * DDL trigger that deletes entry from pathman_config table
+ * DDL trigger that deletes entry from pathman_config table.
  */
 CREATE OR REPLACE FUNCTION @extschema@.pathman_ddl_trigger_func()
 RETURNS event_trigger AS
@@ -472,7 +488,7 @@ $$
 LANGUAGE plpgsql;
 
 /*
- * Drop trigger
+ * Drop triggers.
  */
 CREATE OR REPLACE FUNCTION @extschema@.drop_triggers(
 	parent_relid	REGCLASS)
@@ -485,8 +501,8 @@ END
 $$ LANGUAGE plpgsql STRICT;
 
 /*
- * Drop partitions
- * If delete_data set to TRUE then partitions will be dropped with all the data
+ * Drop partitions. If delete_data set to TRUE, partitions
+ * will be dropped with all the data.
  */
 CREATE OR REPLACE FUNCTION @extschema@.drop_partitions(
 	parent_relid	REGCLASS,
@@ -578,16 +594,6 @@ ON sql_drop
 EXECUTE PROCEDURE @extschema@.pathman_ddl_trigger_func();
 
 
-/*
- * Attach a previously partitioned table
- */
-CREATE OR REPLACE FUNCTION @extschema@.add_to_pathman_config(
-	parent_relid	REGCLASS,
-	attname			TEXT,
-	range_interval	TEXT DEFAULT NULL)
-RETURNS BOOLEAN AS 'pg_pathman', 'add_to_pathman_config'
-LANGUAGE C;
-
 
 CREATE OR REPLACE FUNCTION @extschema@.on_create_partitions(
 	relid	REGCLASS)
@@ -619,40 +625,41 @@ CREATE OR REPLACE FUNCTION @extschema@.get_base_type(REGTYPE)
 RETURNS REGTYPE AS 'pg_pathman', 'get_base_type_pl'
 LANGUAGE C STRICT;
 
-
 /*
- * Checks if attribute is nullable
+ * Returns attribute type name for relation.
  */
-CREATE OR REPLACE FUNCTION @extschema@.is_attribute_nullable(
+CREATE OR REPLACE FUNCTION @extschema@.get_attribute_type(
 	REGCLASS, TEXT)
-RETURNS BOOLEAN AS 'pg_pathman', 'is_attribute_nullable'
+RETURNS REGTYPE AS 'pg_pathman', 'get_attribute_type_pl'
 LANGUAGE C STRICT;
 
 /*
- * Check if regclass is date or timestamp
+ * Return tablespace name for specified relation.
  */
-CREATE OR REPLACE FUNCTION @extschema@.is_date_type(
-	typid	REGTYPE)
-RETURNS BOOLEAN AS 'pg_pathman', 'is_date_type'
+CREATE OR REPLACE FUNCTION @extschema@.get_rel_tablespace_name(relation REGCLASS)
+RETURNS TEXT AS 'pg_pathman', 'get_rel_tablespace_name'
 LANGUAGE C STRICT;
 
+
 /*
- * Returns attribute type name for relation
+ * Checks if attribute is nullable
  */
-CREATE OR REPLACE FUNCTION @extschema@.get_attribute_type(
+CREATE OR REPLACE FUNCTION @extschema@.is_attribute_nullable(
 	REGCLASS, TEXT)
-RETURNS REGTYPE AS 'pg_pathman', 'get_attribute_type_pl'
+RETURNS BOOLEAN AS 'pg_pathman', 'is_attribute_nullable'
 LANGUAGE C STRICT;
 
 /*
- * Get parent of pg_pathman's partition.
+ * Check if regclass is date or timestamp.
  */
-CREATE OR REPLACE FUNCTION @extschema@.get_parent_of_partition(REGCLASS)
-RETURNS REGCLASS AS 'pg_pathman', 'get_parent_of_partition_pl'
+CREATE OR REPLACE FUNCTION @extschema@.is_date_type(
+	typid	REGTYPE)
+RETURNS BOOLEAN AS 'pg_pathman', 'is_date_type'
 LANGUAGE C STRICT;
 
+
 /*
- * Build check constraint name for a specified relation's column
+ * Build check constraint name for a specified relation's column.
  */
 CREATE OR REPLACE FUNCTION @extschema@.build_check_constraint_name(
 	REGCLASS, INT2)
@@ -679,7 +686,22 @@ LANGUAGE C STRICT;
 
 
 /*
- * Lock partitioned relation to restrict concurrent modification of partitioning scheme.
+ * Attach a previously partitioned table.
+ */
+CREATE OR REPLACE FUNCTION @extschema@.add_to_pathman_config(
+	parent_relid	REGCLASS,
+	attname			TEXT,
+	range_interval	TEXT DEFAULT NULL)
+RETURNS BOOLEAN AS 'pg_pathman', 'add_to_pathman_config'
+LANGUAGE C;
+
+CREATE OR REPLACE FUNCTION @extschema@.invalidate_relcache(relid OID)
+RETURNS VOID AS 'pg_pathman' LANGUAGE C STRICT;
+
+
+/*
+ * Lock partitioned relation to restrict concurrent
+ * modification of partitioning scheme.
  */
  CREATE OR REPLACE FUNCTION @extschema@.lock_partitioned_relation(
 	 REGCLASS)
@@ -702,18 +724,12 @@ CREATE OR REPLACE FUNCTION @extschema@.debug_capture()
 RETURNS VOID AS 'pg_pathman', 'debug_capture'
 LANGUAGE C STRICT;
 
-/*
- * Return tablespace name for specified relation.
- */
-CREATE OR REPLACE FUNCTION @extschema@.get_rel_tablespace_name(relation REGCLASS)
-RETURNS TEXT AS 'pg_pathman', 'get_rel_tablespace_name'
-LANGUAGE C STRICT;
-
 /*
  * Checks that callback function meets specific requirements. Particularly it
  * must have the only JSONB argument and VOID return type.
  */
-CREATE OR REPLACE FUNCTION @extschema@.validate_on_partition_created_callback(callback REGPROC)
+CREATE OR REPLACE FUNCTION @extschema@.validate_on_partition_created_callback(
+	callback		REGPROC)
 RETURNS VOID AS 'pg_pathman', 'validate_on_part_init_callback_pl'
 LANGUAGE C STRICT;
 

src/pathman.h

@@ -52,7 +52,7 @@
 #define PATHMAN_CONFIG_interval_typmod		-1
 
 /*
- * Definitions for the "pathman_config_params" table
+ * Definitions for the "pathman_config_params" table.
  */
 #define PATHMAN_CONFIG_PARAMS						"pathman_config_params"
 #define Natts_pathman_config_params					4
@@ -61,6 +61,19 @@
 #define Anum_pathman_config_params_auto				3	/* auto partitions creation */
 #define Anum_pathman_config_params_init_callback	4	/* partition action callback */
 
+/*
+ * Definitions for the "pathman_partition_list" view.
+ */
+#define PATHMAN_PARTITION_LIST				"pathman_partition_list"
+#define Natts_pathman_partition_list		6
+#define Anum_pathman_pl_parent				1
+#define Anum_pathman_pl_partition			2
+#define Anum_pathman_pl_parttype			3
+#define Anum_pathman_pl_partattr			4
+#define Anum_pathman_pl_range_min			5
+#define Anum_pathman_pl_range_max			6
+
+
 /*
  * Cache current PATHMAN_CONFIG relid (set during load_config()).
  */

src/pathman_workers.h

@@ -111,7 +111,7 @@ cps_set_status(ConcurrentPartSlot *slot, ConcurrentPartSlotStatus status)
 
 
 /*
- * Definitions for the "pathman_concurrent_part_tasks" view
+ * Definitions for the "pathman_concurrent_part_tasks" view.
  */
 #define PATHMAN_CONCURRENT_PART_TASKS		"pathman_concurrent_part_tasks"
 #define Natts_pathman_cp_tasks				6