refactoring, add column 'spawn_using_bgw' to PATHMAN_CONFIG_PARAMS

Author: funbringer

expected/pathman_callbacks.out

@@ -26,39 +26,66 @@ SELECT set_init_callback('callbacks.abc',
 (1 row)
 
 INSERT INTO callbacks.abc VALUES (123, 1);
-INSERT INTO callbacks.abc VALUES (223, 1);
+INSERT INTO callbacks.abc VALUES (223, 1); /* show warning */
+WARNING:  callback arg: {"parent": "abc", "parttype": "2", "partition": "abc_3", "range_max": "301", "range_min": "201"}
+SELECT set_spawn_using_bgw('callbacks.abc', true);
+ set_spawn_using_bgw 
+---------------------
+ 
+(1 row)
+
+SELECT get_number_of_partitions('callbacks.abc');
+ get_number_of_partitions 
+--------------------------
+                        3
+(1 row)
+
+INSERT INTO callbacks.abc VALUES (323, 1);
+SELECT get_number_of_partitions('callbacks.abc'); /* +1 partition (created by BGW) */
+ get_number_of_partitions 
+--------------------------
+                        4
+(1 row)
+
+SELECT set_spawn_using_bgw('callbacks.abc', false);
+ set_spawn_using_bgw 
+---------------------
+ 
+(1 row)
+
 SELECT append_range_partition('callbacks.abc');
-WARNING:  callback arg: {"parent": "abc", "parttype": "2", "partition": "abc_4", "range_max": "401", "range_min": "301"}
+WARNING:  callback arg: {"parent": "abc", "parttype": "2", "partition": "abc_5", "range_max": "501", "range_min": "401"}
  append_range_partition 
 ------------------------
- callbacks.abc_4
+ callbacks.abc_5
 (1 row)
 
 SELECT prepend_range_partition('callbacks.abc');
-WARNING:  callback arg: {"parent": "abc", "parttype": "2", "partition": "abc_5", "range_max": "1", "range_min": "-99"}
+WARNING:  callback arg: {"parent": "abc", "parttype": "2", "partition": "abc_6", "range_max": "1", "range_min": "-99"}
  prepend_range_partition 
 -------------------------
- callbacks.abc_5
+ callbacks.abc_6
 (1 row)
 
-SELECT add_range_partition('callbacks.abc', 401, 502);
-WARNING:  callback arg: {"parent": "abc", "parttype": "2", "partition": "abc_6", "range_max": "502", "range_min": "401"}
+SELECT add_range_partition('callbacks.abc', 501, 602);
+WARNING:  callback arg: {"parent": "abc", "parttype": "2", "partition": "abc_7", "range_max": "602", "range_min": "501"}
  add_range_partition 
 ---------------------
- callbacks.abc_6
+ callbacks.abc_7
 (1 row)
 
 SELECT drop_partitions('callbacks.abc');
 NOTICE:  function callbacks.abc_upd_trig_func() does not exist, skipping
 NOTICE:  0 rows copied from callbacks.abc_1
 NOTICE:  1 rows copied from callbacks.abc_2
 NOTICE:  1 rows copied from callbacks.abc_3
-NOTICE:  0 rows copied from callbacks.abc_4
+NOTICE:  1 rows copied from callbacks.abc_4
 NOTICE:  0 rows copied from callbacks.abc_5
 NOTICE:  0 rows copied from callbacks.abc_6
+NOTICE:  0 rows copied from callbacks.abc_7
  drop_partitions 
 -----------------
-               6
+               7
 (1 row)
 
 /* set callback to be called on HASH partitions */

expected/pathman_permissions.out

@@ -39,9 +39,9 @@ SELECT * FROM pathman_config;
 (1 row)
 
 SELECT * FROM pathman_config_params;
-         partrel         | enable_parent | auto | init_callback 
--------------------------+---------------+------+---------------
- permissions.user1_table | f             | t    | -
+         partrel         | enable_parent | auto | init_callback | spawn_using_bgw 
+-------------------------+---------------+------+---------------+-----------------
+ permissions.user1_table | f             | t    | -             | f
 (1 row)
 
 /* Should fail */

init.sql

@@ -26,6 +26,20 @@ CREATE TABLE IF NOT EXISTS @extschema@.pathman_config (
 	CHECK (parttype IN (1, 2)) /* check for allowed part types */
 );
 
+
+/*
+ * Checks that callback function meets specific requirements.
+ * Particularly it must have the only JSONB argument and VOID return type.
+ *
+ * NOTE: this function is used in CHECK CONSTRAINT.
+ */
+CREATE OR REPLACE FUNCTION @extschema@.validate_part_callback(
+	callback		REGPROC,
+	raise_error		BOOL DEFAULT FALSE)
+RETURNS BOOL AS 'pg_pathman', 'validate_part_callback_pl'
+LANGUAGE C STRICT;
+
+
 /*
  * Optional parameters for partitioned tables.
  *		partrel - regclass (relation type, stored as Oid)
@@ -37,10 +51,11 @@ CREATE TABLE IF NOT EXISTS @extschema@.pathman_config_params (
 	partrel			REGCLASS NOT NULL PRIMARY KEY,
 	enable_parent	BOOLEAN NOT NULL DEFAULT FALSE,
 	auto			BOOLEAN NOT NULL DEFAULT TRUE,
-	init_callback	REGPROCEDURE NOT NULL DEFAULT 0
+	init_callback	REGPROCEDURE NOT NULL DEFAULT 0,
+	spawn_using_bgw	BOOLEAN NOT NULL DEFAULT FALSE
+
+	CHECK (@extschema@.validate_part_callback(init_callback)) /* check signature */
 );
-CREATE UNIQUE INDEX i_pathman_config_params
-ON @extschema@.pathman_config_params(partrel);
 
 GRANT SELECT, INSERT, UPDATE, DELETE
 ON @extschema@.pathman_config, @extschema@.pathman_config_params
@@ -120,7 +135,7 @@ BEGIN
 	USING relation, value;
 END
 $$
-LANGUAGE plpgsql;
+LANGUAGE plpgsql STRICT;
 
 /*
  * Include\exclude parent relation in query plan.
@@ -159,11 +174,25 @@ CREATE OR REPLACE FUNCTION @extschema@.set_init_callback(
 RETURNS VOID AS
 $$
 BEGIN
-	PERFORM @extschema@.validate_on_partition_created_callback(callback);
 	PERFORM @extschema@.pathman_set_param(relation, 'init_callback', callback);
 END
 $$
-LANGUAGE plpgsql;
+LANGUAGE plpgsql STRICT;
+
+/*
+ * Set 'spawn using BGW' option
+ */
+CREATE OR REPLACE FUNCTION @extschema@.set_spawn_using_bgw(
+	relation	REGCLASS,
+	value		BOOLEAN)
+RETURNS VOID AS
+$$
+BEGIN
+	PERFORM @extschema@.pathman_set_param(relation, 'spawn_using_bgw', value);
+END
+$$
+LANGUAGE plpgsql STRICT;
+
 
 /*
  * Show all existing parents and partitions.
@@ -752,15 +781,6 @@ CREATE OR REPLACE FUNCTION @extschema@.debug_capture()
 RETURNS VOID AS 'pg_pathman', 'debug_capture'
 LANGUAGE C STRICT;
 
-/*
- * Checks that callback function meets specific requirements. Particularly it
- * must have the only JSONB argument and VOID return type.
- */
-CREATE OR REPLACE FUNCTION @extschema@.validate_on_partition_created_callback(
-	callback		REGPROC)
-RETURNS VOID AS 'pg_pathman', 'validate_on_part_init_callback_pl'
-LANGUAGE C STRICT;
-
 
 /*
  * Invoke init_callback on RANGE partition.

sql/pathman_callbacks.sql

@@ -22,11 +22,18 @@ SELECT set_init_callback('callbacks.abc',
 						 'callbacks.abc_on_part_created_callback');
 
 INSERT INTO callbacks.abc VALUES (123, 1);
-INSERT INTO callbacks.abc VALUES (223, 1);
+INSERT INTO callbacks.abc VALUES (223, 1); /* show warning */
+
+SELECT set_spawn_using_bgw('callbacks.abc', true);
+SELECT get_number_of_partitions('callbacks.abc');
+INSERT INTO callbacks.abc VALUES (323, 1);
+SELECT get_number_of_partitions('callbacks.abc'); /* +1 partition (created by BGW) */
+SELECT set_spawn_using_bgw('callbacks.abc', false);
+
 
 SELECT append_range_partition('callbacks.abc');
 SELECT prepend_range_partition('callbacks.abc');
-SELECT add_range_partition('callbacks.abc', 401, 502);
+SELECT add_range_partition('callbacks.abc', 501, 602);
 
 SELECT drop_partitions('callbacks.abc');
 

src/init.c

@@ -128,7 +128,7 @@ init_main_pathman_toggles(void)
 							 "Enables automatic partition creation",
 							 NULL,
 							 &pg_pathman_init_state.auto_partition,
-							 true,
+							 DEFAULT_AUTO,
 							 PGC_SUSET,
 							 0,
 							 NULL,
@@ -730,6 +730,7 @@ read_pathman_params(Oid relid, Datum *values, bool *isnull)
 		Assert(!isnull[Anum_pathman_config_params_enable_parent - 1]);
 		Assert(!isnull[Anum_pathman_config_params_auto - 1]);
 		Assert(!isnull[Anum_pathman_config_params_init_callback - 1]);
+		Assert(!isnull[Anum_pathman_config_params_spawn_using_bgw - 1]);
 	}
 
 	/* Clean resources */

src/init.h

@@ -87,6 +87,13 @@ extern PathmanInitState 	pg_pathman_init_state;
 	} while (0)
 
 
+/* Default column values for PATHMAN_CONFIG_PARAMS */
+#define DEFAULT_ENABLE_PARENT		false
+#define DEFAULT_AUTO				true
+#define DEFAULT_INIT_CALLBACK		InvalidOid
+#define DEFAULT_SPAWN_USING_BGW		false
+
+
 /*
  * Save and restore PathmanInitState.
  */