remove unnecessary code, fix tests

Author: funbringer

expected/pathman_expressions.out

@@ -109,32 +109,32 @@ SELECT add_to_pathman_config('test_exprs.composite',
 (1 row)
 
 SELECT add_range_partition('test_exprs.composite',
-						   '(1,  ''a'')'::test_exprs.composite,
-						   '(10, ''a'')'::test_exprs.composite);
+						   '(1,a)'::test_exprs.composite,
+						   '(10,a)'::test_exprs.composite);
   add_range_partition   
 ------------------------
  test_exprs.composite_1
 (1 row)
 
 SELECT add_range_partition('test_exprs.composite',
-						   '(10, ''a'')'::test_exprs.composite,
-						   '(20, ''a'')'::test_exprs.composite);
+						   '(10,a)'::test_exprs.composite,
+						   '(20,a)'::test_exprs.composite);
   add_range_partition   
 ------------------------
  test_exprs.composite_2
 (1 row)
 
 SELECT add_range_partition('test_exprs.composite',
-						   '(20, ''a'')'::test_exprs.composite,
-						   '(30, ''a'')'::test_exprs.composite);
+						   '(20,a)'::test_exprs.composite,
+						   '(30,a)'::test_exprs.composite);
   add_range_partition   
 ------------------------
  test_exprs.composite_3
 (1 row)
 
 SELECT add_range_partition('test_exprs.composite',
-						   '(30, ''a'')'::test_exprs.composite,
-						   '(40, ''a'')'::test_exprs.composite);
+						   '(30,a)'::test_exprs.composite,
+						   '(40,a)'::test_exprs.composite);
   add_range_partition   
 ------------------------
  test_exprs.composite_4

sql/pathman_expressions.sql

@@ -43,17 +43,17 @@ SELECT add_to_pathman_config('test_exprs.composite',
 							 '(a, b)::test_exprs.composite',
 							 NULL);
 SELECT add_range_partition('test_exprs.composite',
-						   '(1,  ''a'')'::test_exprs.composite,
-						   '(10, ''a'')'::test_exprs.composite);
+						   '(1,a)'::test_exprs.composite,
+						   '(10,a)'::test_exprs.composite);
 SELECT add_range_partition('test_exprs.composite',
-						   '(10, ''a'')'::test_exprs.composite,
-						   '(20, ''a'')'::test_exprs.composite);
+						   '(10,a)'::test_exprs.composite,
+						   '(20,a)'::test_exprs.composite);
 SELECT add_range_partition('test_exprs.composite',
-						   '(20, ''a'')'::test_exprs.composite,
-						   '(30, ''a'')'::test_exprs.composite);
+						   '(20,a)'::test_exprs.composite,
+						   '(30,a)'::test_exprs.composite);
 SELECT add_range_partition('test_exprs.composite',
-						   '(30, ''a'')'::test_exprs.composite,
-						   '(40, ''a'')'::test_exprs.composite);
+						   '(30,a)'::test_exprs.composite,
+						   '(40,a)'::test_exprs.composite);
 SELECT expr FROM pathman_config; /* check expression */
 INSERT INTO test_exprs.composite VALUES(2,  'a');
 INSERT INTO test_exprs.composite VALUES(11, 'a');

src/pg_pathman.c

@@ -184,15 +184,7 @@ ExtractConst(Node *node, const WalkerContext *context)
 			break;
 
 		default:
-			{
-				/* Keep compiler happy */
-				typid	= InvalidOid;
-				typmod	= - 1;
-				collid	= InvalidOid;
-
-				elog(ERROR, "error in function " CppAsString(ExtractConst));
-			}
-			break;
+			elog(ERROR, "error in function " CppAsString(ExtractConst));;
 	}
 
 	return makeConst(typid, typmod, collid, get_typlen(typid),