Merge branch 'rel_future_beta' of github.com:postgrespro/pg_pathman into rel_future_beta

Author: ildus

Makefile

@@ -25,22 +25,24 @@ DATA = pg_pathman--1.0--1.1.sql \
 PGFILEDESC = "pg_pathman - partitioning tool for PostgreSQL"
 
 REGRESS = pathman_basic \
-		  pathman_only \
-		  pathman_cte \
 		  pathman_bgw \
-		  pathman_inserts \
-		  pathman_updates \
-		  pathman_domains \
-		  pathman_interval \
+		  pathman_calamity \
 		  pathman_callbacks \
+		  pathman_column_type \
+		  pathman_cte \
+		  pathman_domains \
 		  pathman_foreign_keys \
+		  pathman_inserts \
+		  pathman_interval \
+		  pathman_join_clause \
+		  pathman_only \
 		  pathman_permissions \
 		  pathman_rowmarks \
 		  pathman_runtime_nodes \
-		  pathman_utility_stmt \
-		  pathman_column_type \
 		  pathman_update_trigger \
-		  pathman_calamity
+		  pathman_updates \
+		  pathman_utility_stmt
+
 
 EXTRA_REGRESS_OPTS=--temp-config=$(top_srcdir)/$(subdir)/conf.add
 

README.md

@@ -671,7 +671,8 @@ All sections and data will remain unchanged and will be handled by the standard
 Do not hesitate to post your issues, questions and new ideas at the [issues](https://github.com/postgrespro/pg_pathman/issues) page.
 
 ## Authors
-Ildar Musin <i.musin@postgrespro.ru> Postgres Professional Ltd., Russia  
-Alexander Korotkov <a.korotkov@postgrespro.ru> Postgres Professional Ltd., Russia  
-Dmitry Ivanov <d.ivanov@postgrespro.ru> Postgres Professional Ltd., Russia  
+Ildar Musin <i.musin(at)postgrespro.ru> Postgres Professional Ltd., Russia  
+Alexander Korotkov <a.korotkov(at)postgrespro.ru> Postgres Professional Ltd., Russia  
+Dmitry Ivanov <d.ivanov(at)postgrespro.ru> Postgres Professional Ltd., Russia  
+Maksim Milyutin <m.milyutin(at)postgrespro.ru> Postgres Professional Ltd., Russia  
 

expected/pathman_calamity.out

@@ -102,23 +102,26 @@ SELECT count(*) FROM calamity.part_test;
 (1 row)
 
 DELETE FROM calamity.part_test;
+/* test function create_single_range_partition() */
+SELECT create_single_range_partition(NULL, NULL::INT4, NULL); /* not ok */
+ERROR:  'parent_relid' should not be NULL
 /* test function create_range_partitions_internal() */
-SELECT create_range_partitions_internal(NULL, '{}'::INT[], NULL, NULL);			/* not ok */
+SELECT create_range_partitions_internal(NULL, '{}'::INT[], NULL, NULL);		/* not ok */
 ERROR:  'parent_relid' should not be NULL
 SELECT create_range_partitions_internal('calamity.part_test',
-										NULL::INT[], NULL, NULL);				/* not ok */
+										NULL::INT[], NULL, NULL);			/* not ok */
 ERROR:  'bounds' should not be NULL
 SELECT create_range_partitions_internal('calamity.part_test', '{1}'::INT[],
-										'{part_1}'::TEXT[], NULL);				/* not ok */
+										'{part_1}'::TEXT[], NULL);			/* not ok */
 ERROR:  wrong length of 'partition_names' array
 SELECT create_range_partitions_internal('calamity.part_test', '{1}'::INT[],
-										NULL, '{tblspc_1}'::TEXT[]);			/* not ok */
+										NULL, '{tblspc_1}'::TEXT[]);		/* not ok */
 ERROR:  wrong length of 'tablespaces' array
 SELECT create_range_partitions_internal('calamity.part_test',
-										'{1, NULL}'::INT[], NULL, NULL);		/* not ok */
+										'{1, NULL}'::INT[], NULL, NULL);	/* not ok */
 ERROR:  only first bound can be NULL
 SELECT create_range_partitions_internal('calamity.part_test',
-										'{2, 1}'::INT[], NULL, NULL);			/* not ok */
+										'{2, 1}'::INT[], NULL, NULL);		/* not ok */
 ERROR:  'bounds' array must be ascending
 /* test function create_hash_partitions() */
 SELECT create_hash_partitions('calamity.part_test', 'val', 2,
@@ -244,24 +247,45 @@ SELECT build_hash_condition('text', 'val', 10, NULL) IS NULL;
 SELECT build_hash_condition('calamity.part_test', 'val', 10, 1);
 ERROR:  no hash function for type calamity.part_test
 /* check function build_range_condition() */
-SELECT build_range_condition('calamity.part_test', 'val', 10, 20);
+SELECT build_range_condition(NULL, 'val', 10, 20);						/* not ok */
+ERROR:  'partition_relid' should not be NULL
+SELECT build_range_condition('calamity.part_test', NULL, 10, 20);		/* not ok */
+ERROR:  'attribute' should not be NULL
+SELECT build_range_condition('calamity.part_test', 'val', 10, 20);		/* OK */
     build_range_condition     
 ------------------------------
  ((val >= 10) AND (val < 20))
 (1 row)
 
-SELECT build_range_condition('calamity.part_test', 'val', 10, NULL);
+SELECT build_range_condition('calamity.part_test', 'val', 10, NULL);	/* OK */
  build_range_condition 
 -----------------------
  ((val >= 10))
 (1 row)
 
-SELECT build_range_condition('calamity.part_test', 'val', NULL, 10);
+SELECT build_range_condition('calamity.part_test', 'val', NULL, 10);	/* OK */
  build_range_condition 
 -----------------------
  ((val < 10))
 (1 row)
 
+/* check function validate_interval_value() */
+SELECT validate_interval_value(NULL, 'val', 2, '1 mon');					/* not ok */
+ERROR:  'partrel' should not be NULL
+SELECT validate_interval_value('calamity.part_test', NULL, 2, '1 mon');		/* not ok */
+ERROR:  'attname' should not be NULL
+SELECT validate_interval_value('calamity.part_test', 'val', NULL, '1 mon');	/* not ok */
+ERROR:  'parttype' should not be NULL
+SELECT validate_interval_value('calamity.part_test', 'val', 2, '1 mon');	/* not ok */
+ERROR:  invalid input syntax for integer: "1 mon"
+SELECT validate_interval_value('calamity.part_test', 'val', 1, '1 mon');	/* not ok */
+ERROR:  interval should be NULL for HASH partitioned table
+SELECT validate_interval_value('calamity.part_test', 'val', 2, NULL);		/* OK */
+ validate_interval_value 
+-------------------------
+ t
+(1 row)
+
 /* check function validate_relname() */
 SELECT validate_relname('calamity.part_test');
  validate_relname 
@@ -327,12 +351,16 @@ SELECT get_partition_key_type(NULL) IS NULL;
 (1 row)
 
 /* check function build_check_constraint_name_attnum() */
-SELECT build_check_constraint_name('calamity.part_test', 1::int2);
+SELECT build_check_constraint_name('calamity.part_test', 1::int2);	/* OK */
  build_check_constraint_name 
 -----------------------------
  pathman_part_test_1_check
 (1 row)
 
+SELECT build_check_constraint_name(0::REGCLASS, 1::int2);			/* not ok */
+ERROR:  relation "0" does not exist
+SELECT build_check_constraint_name('calamity.part_test', -1::int2);	/* not ok */
+ERROR:  invalid attribute number -1
 SELECT build_check_constraint_name('calamity.part_test', NULL::int2) IS NULL;
  ?column? 
 ----------
@@ -352,12 +380,16 @@ SELECT build_check_constraint_name(NULL, NULL::int2) IS NULL;
 (1 row)
 
 /* check function build_check_constraint_name_attname() */
-SELECT build_check_constraint_name('calamity.part_test', 'val');
+SELECT build_check_constraint_name('calamity.part_test', 'val');	/* OK */
  build_check_constraint_name 
 -----------------------------
  pathman_part_test_1_check
 (1 row)
 
+SELECT build_check_constraint_name(0::REGCLASS, 'val');				/* not ok */
+ERROR:  relation "0" does not exist
+SELECT build_check_constraint_name('calamity.part_test', 'nocol');	/* not ok */
+ERROR:  relation "part_test" has no column "nocol"
 SELECT build_check_constraint_name('calamity.part_test', NULL::text) IS NULL;
  ?column? 
 ----------
@@ -377,36 +409,64 @@ SELECT build_check_constraint_name(NULL, NULL::text) IS NULL;
 (1 row)
 
 /* check function build_update_trigger_name() */
-SELECT build_update_trigger_name('calamity.part_test');
+SELECT build_update_trigger_name('calamity.part_test');			/* OK */
  build_update_trigger_name 
 ---------------------------
  part_test_upd_trig
 (1 row)
 
+SELECT build_update_trigger_name(0::REGCLASS);					/* not ok */
+ERROR:  relation "0" does not exist
 SELECT build_update_trigger_name(NULL) IS NULL;
  ?column? 
 ----------
  t
 (1 row)
 
 /* check function build_update_trigger_func_name() */
-SELECT build_update_trigger_func_name('calamity.part_test');
+SELECT build_update_trigger_func_name('calamity.part_test');	/* OK */
   build_update_trigger_func_name  
 ----------------------------------
  calamity.part_test_upd_trig_func
 (1 row)
 
+SELECT build_update_trigger_func_name(0::REGCLASS);				/* not ok */
+ERROR:  relation "0" does not exist
 SELECT build_update_trigger_func_name(NULL) IS NULL;
  ?column? 
 ----------
  t
 (1 row)
 
+/* check function build_sequence_name() */
+SELECT build_sequence_name('calamity.part_test');				/* OK */
+  build_sequence_name   
+------------------------
+ calamity.part_test_seq
+(1 row)
+
+SELECT build_sequence_name(1::REGCLASS);						/* not ok */
+ERROR:  relation "1" does not exist
+SELECT build_sequence_name(NULL) IS NULL;
+ ?column? 
+----------
+ t
+(1 row)
+
+/* check function partition_table_concurrently() */
+SELECT partition_table_concurrently(1::REGCLASS);				/* not ok */
+ERROR:  relation "1" has no partitions
+SELECT partition_table_concurrently('pg_class', 0);				/* not ok */
+ERROR:  'batch_size' should not be less than 1 or greater than 10000
+SELECT partition_table_concurrently('pg_class', 1, 1E-5);		/* not ok */
+ERROR:  'sleep_time' should not be less than 0.5
+SELECT partition_table_concurrently('pg_class');				/* not ok */
+ERROR:  relation "pg_class" has no partitions
 /* check function stop_concurrent_part_task() */
-SELECT stop_concurrent_part_task(1::regclass);
+SELECT stop_concurrent_part_task(1::REGCLASS);					/* not ok */
 ERROR:  cannot find worker for relation "1"
 /* check function drop_range_partition_expand_next() */
-SELECT drop_range_partition_expand_next('pg_class');
+SELECT drop_range_partition_expand_next('pg_class');			/* not ok */
 ERROR:  relation "pg_class" is not a partition
 SELECT drop_range_partition_expand_next(NULL) IS NULL;
  ?column? 
@@ -453,6 +513,23 @@ SELECT generate_range_bounds('1-jan-2017'::DATE,
  {01-01-2017,01-02-2017,01-03-2017,01-04-2017,01-05-2017}
 (1 row)
 
+SELECT check_range_available(NULL, NULL::INT4, NULL);	/* not ok */
+ERROR:  'parent_relid' should not be NULL
+SELECT check_range_available('pg_class', 1, 10);		/* OK (not partitioned) */
+WARNING:  relation "pg_class" is not partitioned
+ check_range_available 
+-----------------------
+ 
+(1 row)
+
+SELECT has_update_trigger(NULL);
+ has_update_trigger 
+--------------------
+ 
+(1 row)
+
+SELECT has_update_trigger(0::REGCLASS); /* not ok */
+ERROR:  relation "0" does not exist
 /* check invoke_on_partition_created_callback() */
 CREATE FUNCTION calamity.dummy_cb(arg jsonb) RETURNS void AS $$
 	begin
@@ -463,7 +540,7 @@ $$ LANGUAGE plpgsql;
 SELECT invoke_on_partition_created_callback(NULL, 'calamity.part_test', 1);
 ERROR:  'parent_relid' should not be NULL
 SELECT invoke_on_partition_created_callback('calamity.part_test', NULL, 1);
-ERROR:  'partition' should not be NULL
+ERROR:  'partition_relid' should not be NULL
 SELECT invoke_on_partition_created_callback('calamity.part_test', 'calamity.part_test', 0);
  invoke_on_partition_created_callback 
 --------------------------------------
@@ -519,6 +596,8 @@ DROP FUNCTION calamity.dummy_cb(arg jsonb);
 /* check function add_to_pathman_config() -- PHASE #1 */
 SELECT add_to_pathman_config(NULL, 'val');						/* no table */
 ERROR:  'parent_relid' should not be NULL
+SELECT add_to_pathman_config(0::REGCLASS, 'val');				/* no table (oid) */
+ERROR:  relation "0" does not exist
 SELECT add_to_pathman_config('calamity.part_test', NULL);		/* no column */
 ERROR:  'attname' should not be NULL
 SELECT add_to_pathman_config('calamity.part_test', 'V_A_L');	/* wrong column */

expected/pathman_interval.out

@@ -21,14 +21,14 @@ INSERT INTO test_interval.abc VALUES (250);
 ERROR:  cannot find appropriate partition for key '250'
 /* Set a trivial interval */
 SELECT set_interval('test_interval.abc', 0);
-ERROR:  interval must not be trivial
+ERROR:  interval should not be trivial
 /* Set a negative interval */
 SELECT set_interval('test_interval.abc', -100);
-ERROR:  interval must not be negative
+ERROR:  interval should not be negative
 /* We also shouldn't be able to set a trivial interval directly */
 UPDATE pathman_config SET range_interval = '0'
 WHERE partrel = 'test_interval.abc'::REGCLASS;
-ERROR:  interval must not be trivial
+ERROR:  interval should not be trivial
 /* Set a normal interval */
 SELECT set_interval('test_interval.abc', 1000);
  set_interval 
@@ -64,14 +64,14 @@ INSERT INTO test_interval.abc VALUES (250);
 ERROR:  cannot find appropriate partition for key '250'
 /* Set a trivial interval */
 SELECT set_interval('test_interval.abc', 0);
-ERROR:  interval must not be trivial
+ERROR:  interval should not be trivial
 /* Set a negative interval */
 SELECT set_interval('test_interval.abc', -100);
-ERROR:  interval must not be negative
+ERROR:  interval should not be negative
 /* We also shouldn't be able to set a trivial interval directly */
 UPDATE pathman_config SET range_interval = '0'
 WHERE partrel = 'test_interval.abc'::REGCLASS;
-ERROR:  interval must not be trivial
+ERROR:  interval should not be trivial
 /* Set a normal interval */
 SELECT set_interval('test_interval.abc', 1000);
  set_interval 
@@ -107,14 +107,14 @@ INSERT INTO test_interval.abc VALUES (250);
 ERROR:  cannot find appropriate partition for key '250'
 /* Set a trivial interval */
 SELECT set_interval('test_interval.abc', 0);
-ERROR:  interval must not be trivial
+ERROR:  interval should not be trivial
 /* Set a negative interval */
 SELECT set_interval('test_interval.abc', -100);
-ERROR:  interval must not be negative
+ERROR:  interval should not be negative
 /* We also shouldn't be able to set a trivial interval directly */
 UPDATE pathman_config SET range_interval = '0'
 WHERE partrel = 'test_interval.abc'::REGCLASS;
-ERROR:  interval must not be trivial
+ERROR:  interval should not be trivial
 /* Set a normal interval */
 SELECT set_interval('test_interval.abc', 1000);
  set_interval 
@@ -148,7 +148,7 @@ SELECT set_interval('test_interval.abc', NULL::INTERVAL);
 
 /* Set a trivial interval */
 SELECT set_interval('test_interval.abc', '1 second'::INTERVAL);
-ERROR:  interval must not be trivial
+ERROR:  interval should not be trivial
 /* Set a normal interval */
 SELECT set_interval('test_interval.abc', '1 month'::INTERVAL);
  set_interval 
@@ -180,7 +180,7 @@ SELECT set_interval('test_interval.abc', NULL::FLOAT4);
 
 /* Set a trivial interval */
 SELECT set_interval('test_interval.abc', 0);
-ERROR:  interval must not be trivial
+ERROR:  interval should not be trivial
 /* Set NaN float as interval */
 SELECT set_interval('test_interval.abc', 'NaN'::FLOAT4);
 ERROR:  invalid floating point interval
@@ -212,7 +212,7 @@ SELECT set_interval('test_interval.abc', NULL::FLOAT8);
 
 /* Set a trivial interval */
 SELECT set_interval('test_interval.abc', 0);
-ERROR:  interval must not be trivial
+ERROR:  interval should not be trivial
 /* Set NaN float as interval */
 SELECT set_interval('test_interval.abc', 'NaN'::FLOAT8);
 ERROR:  invalid floating point interval
@@ -244,7 +244,7 @@ SELECT set_interval('test_interval.abc', NULL::NUMERIC);
 
 /* Set a trivial interval */
 SELECT set_interval('test_interval.abc', 0);
-ERROR:  interval must not be trivial
+ERROR:  interval should not be trivial
 /* Set NaN numeric as interval */
 SELECT set_interval('test_interval.abc', 'NaN'::NUMERIC);
 ERROR:  invalid numeric interval