auto partitions creation parameter added

Author: zilder

expected/pg_pathman.out

@@ -1109,6 +1109,46 @@ CREATE TABLE test.range_rel_test2 (
 	dt  TIMESTAMP);
 SELECT pathman.attach_range_partition('test.range_rel', 'test.range_rel_test2', '2013-01-01'::DATE, '2014-01-01'::DATE);
 ERROR:  Partition must have the exact same structure as parent
+/*
+ * Zero partitions count and adding partitions with specified name
+ */
+CREATE TABLE test.zero(
+	id		SERIAL PRIMARY KEY,
+	value	INT NOT NULL);
+INSERT INTO test.zero SELECT g, g FROM generate_series(1, 100) as g;
+SELECT pathman.create_range_partitions('test.zero', 'value', 50, 10, 0);
+NOTICE:  sequence "zero_seq" does not exist, skipping
+ create_range_partitions 
+-------------------------
+                       0
+(1 row)
+
+SELECT pathman.append_range_partition('test.zero', 'test.zero_0');
+ERROR:  Cannot append to empty partitions set
+SELECT pathman.prepend_range_partition('test.zero', 'test.zero_1');
+ERROR:  Cannot prepend to empty partitions set
+SELECT pathman.add_range_partition('test.zero', 50, 70, 'test.zero_50');
+ add_range_partition 
+---------------------
+ test.zero_50
+(1 row)
+
+SELECT pathman.append_range_partition('test.zero', 'test.zero_appended');
+ERROR:  Partition #-1 does not exist (total amount is 1)
+SELECT pathman.prepend_range_partition('test.zero', 'test.zero_prepended');
+ prepend_range_partition 
+-------------------------
+ test.zero_prepended
+(1 row)
+
+SELECT pathman.split_range_partition('test.zero_50', 60, 'test.zero_60');
+ split_range_partition 
+-----------------------
+ {50,70}
+(1 row)
+
+DROP TABLE test.zero CASCADE;
+NOTICE:  drop cascades to 3 other objects
 /*
  * Check that altering table columns doesn't break trigger
  */

init.sql

@@ -29,7 +29,8 @@ CREATE TABLE IF NOT EXISTS @extschema@.pathman_config (
 
 CREATE TABLE IF NOT EXISTS @extschema@.pathman_config_params (
 	partrel			REGCLASS NOT NULL,
-	enable_parent	BOOLEAN NOT NULL DEFAULT TRUE
+	enable_parent	BOOLEAN NOT NULL DEFAULT TRUE,
+	auto			BOOLEAN NOT NULL DEFAULT TRUE
 );
 CREATE UNIQUE INDEX i_pathman_config_params
 ON @extschema@.pathman_config_params(partrel);
@@ -81,32 +82,73 @@ END
 $$
 LANGUAGE plpgsql;
 
-/* Include parent relation into query plan's for specified relation */
+/*
+ * Set additional param
+ */
+CREATE OR REPLACE FUNCTION @extschema@.pathman_set_param(
+	relation	REGCLASS,
+	param		TEXT,
+	value		BOOLEAN)
+RETURNS VOID AS
+$$
+BEGIN
+	EXECUTE format(
+		'INSERT INTO @extschema@.pathman_config_params (partrel, %1$s)
+		VALUES ($1, $2)
+		ON CONFLICT (partrel) DO
+		UPDATE SET %1$s = $2',
+		param)
+	USING
+		relation,
+		value;
+END
+$$
+LANGUAGE plpgsql;
+
+/*
+ * Include parent relation into query plan's for specified relation
+ */
 CREATE OR REPLACE FUNCTION @extschema@.enable_parent(relation REGCLASS)
 RETURNS VOID AS
 $$
 BEGIN
-	INSERT INTO @extschema@.pathman_config_params values (relation, True)
-	ON CONFLICT (partrel) DO
-	UPDATE SET enable_parent = True;
+	PERFORM @extschema@.pathman_set_param(relation, 'enable_parent', True);
+END
+$$ 
+LANGUAGE plpgsql;
 
-	-- PERFORM @extschema@.invalidate_relcache(relation::oid);
-	-- PERFORM @extschema@.on_enable_parent(relation::oid);
+/*
+ * Do not include parent relation into query plan's for specified relation
+ */
+CREATE OR REPLACE FUNCTION @extschema@.disable_parent(relation REGCLASS)
+RETURNS VOID AS
+$$
+BEGIN
+	PERFORM @extschema@.pathman_set_param(relation, 'enable_parent', False);
 END
 $$
 LANGUAGE plpgsql;
 
-/* Do not include parent relation into query plan's for specified relation */
-CREATE OR REPLACE FUNCTION @extschema@.disable_parent(relation REGCLASS)
+/*
+ * Enable auto partition creation
+ */
+CREATE OR REPLACE FUNCTION @extschema@.enable_auto(relation REGCLASS)
 RETURNS VOID AS
 $$
 BEGIN
-	INSERT INTO @extschema@.pathman_config_params values (relation, False)
-	ON CONFLICT (partrel) DO
-	UPDATE SET enable_parent = False;
+	PERFORM @extschema@.pathman_set_param(relation, 'auto', True);
+END
+$$
+LANGUAGE plpgsql;
 
-	-- PERFORM @extschema@.invalidate_relcache(relation::oid);
-	-- PERFORM @extschema@.on_disable_parent(relation::oid);
+/*
+ * Disable auto partition creation
+ */
+CREATE OR REPLACE FUNCTION @extschema@.disable_auto(relation REGCLASS)
+RETURNS VOID AS
+$$
+BEGIN
+	PERFORM @extschema@.pathman_set_param(relation, 'auto', False);
 END
 $$
 LANGUAGE plpgsql;

sql/pg_pathman.sql

@@ -485,6 +485,7 @@ SELECT pathman.add_range_partition('test.zero', 50, 70, 'test.zero_50');
 SELECT pathman.append_range_partition('test.zero', 'test.zero_appended');
 SELECT pathman.prepend_range_partition('test.zero', 'test.zero_prepended');
 SELECT pathman.split_range_partition('test.zero_50', 60, 'test.zero_60');
+DROP TABLE test.zero CASCADE;
 
 /*
  * Check that altering table columns doesn't break trigger

src/init.c

@@ -570,7 +570,7 @@ pathman_config_contains_relation(Oid relid, Datum *values, bool *isnull,
  * Return 'enable_parent' parameter of relation
  */
 bool
-read_enable_parent_parameter(Oid relid)
+read_pathman_params(Oid relid, Datum *values, bool *isnull)
 {
 	Relation		rel;
 	HeapScanDesc	scan;
@@ -590,12 +590,9 @@ read_enable_parent_parameter(Oid relid)
 
 	if ((htup = heap_getnext(scan, ForwardScanDirection)) != NULL)
 	{
-		Datum	values[Natts_pathman_config_params];
-		bool	isnull[Natts_pathman_config_params];
-
 		/* Extract data if necessary */
 		heap_deform_tuple(htup, RelationGetDescr(rel), values, isnull);
-		result = values[Anum_pathman_config_params_enable_parent - 1];
+		result = true;
 	}
 
 	/* Clean resources */

src/init.h

@@ -47,6 +47,8 @@ bool pathman_config_contains_relation(Oid relid,
 									  bool *isnull,
 									  TransactionId *xmin);
 
-bool read_enable_parent_parameter(Oid relid);
+bool read_pathman_params(Oid relid,
+						 Datum *values,
+						 bool *isnull);
 
 #endif

src/pathman.h

@@ -57,10 +57,10 @@
  * Definitions for the "pathman_config_params" table
  */
 #define PATHMAN_CONFIG_PARAMS						"pathman_config_params"
-// #define PATHMAN_CONFIG_PARAMS_INDEX					"i_pathman_config_params"
-#define Natts_pathman_config_params					2
+#define Natts_pathman_config_params					3
 #define Anum_pathman_config_params_partrel			1	/* primary key */
 #define Anum_pathman_config_params_enable_parent	2	/* include parent into plan */
+#define Anum_pathman_config_params_auto				3	/* auto partitions creation */
 
 /*
  * Cache current PATHMAN_CONFIG relid (set during load_config()).

src/relation_info.c

@@ -74,6 +74,8 @@ refresh_pathman_relation_info(Oid relid,
 							i;
 	bool					found;
 	PartRelationInfo	   *prel;
+	Datum					param_values[Natts_pathman_config_params];
+	bool					param_isnull[Natts_pathman_config_params];
 
 	prel = (PartRelationInfo *) hash_search(partitioned_rels,
 											(const void *) &relid,
@@ -158,10 +160,13 @@ refresh_pathman_relation_info(Oid relid,
 	pfree(prel_children);
 
 	/*
-	 * Read additional parameter ('enable_parent' is the only one at
-	 * the moment)
+	 * Read additional parameters ('enable_parent' and 'auto' at the moment)
 	 */
-	prel->enable_parent = read_enable_parent_parameter(relid);
+	if (read_pathman_params(relid, param_values, param_isnull))
+	{
+		prel->enable_parent = param_values[Anum_pathman_config_params_enable_parent - 1];
+		prel->auto_partition = param_values[Anum_pathman_config_params_auto - 1];
+	}
 
 	/* We've successfully built a cache entry */
 	prel->valid = true;

src/relation_info.h

@@ -48,6 +48,7 @@ typedef struct
 	Oid				key;			/* partitioned table's Oid */
 	bool			valid;			/* is this entry valid? */
 	bool			enable_parent;	/* include parent to the plan */
+	bool			auto_partition; /* auto partition creation */
 
 	uint32			children_count;
 	Oid			   *children;		/* Oids of child partitions */