fix: add support old zabbix

Author: alexander popov

mamonsu/plugins/pgsql/memory_leak_diagnostic.py

@@ -4,35 +4,37 @@
 import re
 from distutils.version import LooseVersion
 import mamonsu.lib.platform as platform
+import posix
 
 
 class MemoryLeakDiagnostic(Plugin):
     DEFAULT_CONFIG = {'enabled': 'False',
-                      'private_anon_mem_threshold': '1GB'}
+                      'private_anon_mem_threshold': '1GB',
+                      'interval': '60'}
     Interval = 60
-
+    
     query = 'select pid from pg_stat_activity'
     key_count_diff = 'pgsql.memory_leak_diagnostic.count_diff[]'
     key_count_diff_error = 'pgsql.memory_leak_diagnostic.msg_text[]'
     name_count_diff = 'PostgreSQL: number of pids which private anonymous memory exceeds ' \
                       'private_anon_mem_threshold'
     name_count_diff_error = 'PostgreSQL: number of pids which private anonymous memory ' \
                             'exceeds private_anon_mem_threshold, text of message'
-
+    
     def __init__(self, config):
         super(Plugin, self).__init__(config)
         if not platform.LINUX:
             self.disable()
             self.log.error('Plugin {name} work only on Linux. '.format(name=self.__class__.__name__))
-
+        
         if self.is_enabled():
             self.page_size = os.sysconf('SC_PAGE_SIZE')
-
+            
             private_anon_mem_threshold_row = self.plugin_config('private_anon_mem_threshold').upper()
             private_anon_mem_threshold, prefix = re.match(r'([0-9]*)([A-Z]*)',
                                                           private_anon_mem_threshold_row, re.I).groups()
             ratio = 0
-
+            
             if prefix == 'MB':
                 ratio = 1024 * 1024
             elif prefix == 'GB':
@@ -44,17 +46,24 @@ def __init__(self, config):
                 self.log.error('Error in config, section [{section}], parameter private_anon_mem_threshold. '
                                'Possible values MB, GB, TB. For example 1GB.'
                                .format(section=self.__class__.__name__.lower()))
-
+            
             self.diff = ratio * int(private_anon_mem_threshold)
-
-            self.os_release = os.uname().release
+            
+            uname = os.uname()
+            if isinstance(uname, tuple):
+                self.os_release = uname[2]
+            elif isinstance(uname, posix.uname_result):
+                self.os_release = uname.release
+            else:
+                self.os_release = '0'
+            
             os_release_file = '/etc/os-release'
             try:
                 release_file = open(os_release_file, 'r').readlines()
             except Exception as e:
                 self.log.info('Cannot read file {os_release_file} : {e}'.format(os_release_file=os_release_file, e=e))
                 release_file = None
-
+            
             if release_file:
                 for line in release_file:
                     if line.strip('"\n') != '':
@@ -66,50 +75,47 @@ def __init__(self, config):
             else:
                 self.os_name = None
                 self.os_version = None
-
+    
     def run(self, zbx):
         pids = []
         count_diff = 0
         diffs = []
         msg_text = ''
-
+        
         for row in Pooler.query(query=self.query):
             pids.append(row[0])
-
+        
         if (LooseVersion(self.os_release) < LooseVersion("4.5")
-            and not (self.os_name == 'centos' and self.os_version == '7'))\
+            and not (self.os_name == 'centos' and self.os_version == '7')) \
                 or (not self.os_name and not self.os_version):
             for pid in pids:
                 try:
                     statm = open('/proc/{pid}/statm'.format(pid=pid), 'r').read().split(' ')
                 except FileNotFoundError:
                     continue
-
+                
                 RES = int(statm[1]) * self.page_size
                 SHR = int(statm[2]) * self.page_size
                 if RES - SHR > self.diff:
                     count_diff += 1
                     diffs.append({'pid': pid, 'RES': RES, 'SHR': SHR, 'diff': self.diff})
             if diffs:
                 for diff in diffs:
-                    msg_text += 'pid: {pid},  RES {RES} - SHR {SHR} more then {diff}\n'.format(pid=diff.get('pid'),
-                                                                                               RES=diff.get('RES'),
-                                                                                               SHR=diff.get('SHR'),
-                                                                                               diff=diff.get('diff'))
+                    msg_text += 'pid: {pid},  RES {RES} - SHR {SHR} more then {diff}\n'.format_map(diff)
         else:
             for pid in pids:
                 try:
                     statm = open('/proc/{pid}/status'.format(pid=pid), 'r').readlines()
                 except FileNotFoundError:
                     continue
-
+                
                 for line in statm:
                     VmRSS = 0
                     RssAnon = 0
                     RssFile = 0
                     RssShmem = 0
                     k, v = line.split(':\t', 1)
-
+                    
                     if k == 'VmRSS':
                         VmRSS = int(v.strip('"\n\t ').split(' ')[0]) * 1024
                     elif k == 'RssAnon':
@@ -126,16 +132,11 @@ def run(self, zbx):
             if diffs:
                 for diff in diffs:
                     msg_text += 'pid: {pid},  RssAnon {RssAnon} more then {diff}, VmRSS {VmRSS}, ' \
-                                'RssFile {RssFile}, RssShmem {RssShmem} \n'.format(pid=diff.get('pid'),
-                                                                                   RssAnon=diff.get('RssAnon'),
-                                                                                   diff=diff.get('diff'),
-                                                                                   VmRSS=diff.get('VmRSS'),
-                                                                                   RssFile=diff.get('RssFile'),
-                                                                                   RssShmem=diff.get('RssShmem'))
-
+                                'RssFile {RssFile}, RssShmem {RssShmem} \n'.format_map(diff)
+        
         zbx.send(self.key_count_diff, int(count_diff))
         zbx.send(self.key_count_diff_error, msg_text)
-
+    
     def items(self, template):
         result = template.item(
             {
@@ -153,7 +154,7 @@ def items(self, template):
             }
         )
         return result
-
+    
     def graphs(self, template):
         result = template.graph(
             {
@@ -167,7 +168,7 @@ def graphs(self, template):
             }
         )
         return result
-
+    
     def triggers(self, template):
         result = template.trigger(
             {