From 9dfb0b36dd499c5ce7950f02ae08a41a74ca95a7 Mon Sep 17 00:00:00 2001 From: Lionel Henry Date: Fri, 7 Nov 2025 09:44:21 +0100 Subject: [PATCH 1/4] Bump Ark to `feature/read-srcref` --- extensions/positron-r/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/positron-r/package.json b/extensions/positron-r/package.json index 4f3a0795ced..a0db7f3dfb2 100644 --- a/extensions/positron-r/package.json +++ b/extensions/positron-r/package.json @@ -928,7 +928,7 @@ }, "positron": { "binaryDependencies": { - "ark": "0.1.218" + "ark": "posit-dev/ark@feature/read-srcref" }, "minimumRVersion": "4.2.0", "minimumRenvVersion": "1.0.9" From c6ec4be15e09cffbfe7a8252dd203b2906787fe5 Mon Sep 17 00:00:00 2001 From: Lionel Henry Date: Wed, 19 Nov 2025 19:12:00 +0100 Subject: [PATCH 2/4] Fix call stack expectations The srcref change depending on how the code is evaluated. Also the srcref might not be displayed if the side bar is too narrow, causing indeterminism. --- test/e2e/tests/debug/r-debug.test.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/test/e2e/tests/debug/r-debug.test.ts b/test/e2e/tests/debug/r-debug.test.ts index b69ede1f476..490061398da 100644 --- a/test/e2e/tests/debug/r-debug.test.ts +++ b/test/e2e/tests/debug/r-debug.test.ts @@ -65,8 +65,8 @@ test.describe('R Debugging', { await debug.expectBrowserModeFrame(1); // Verify call stack order - await debug.expectCallStackAtIndex(0, 'inner()inner()2:'); - await debug.expectCallStackAtIndex(1, 'outer(5)inner(x)2:'); + await debug.expectCallStackAtIndex(0, 'inner()inner(x)'); + await debug.expectCallStackAtIndex(1, 'outer(5)inner(x)'); await debug.expectCallStackAtIndex(2, 'outer(5)'); // Verify the call stack redirects to correct data frame(s) @@ -269,4 +269,3 @@ async function verifyVariableInConsole(app: Application, name: string, expectedT await expect(app.code.driver.page.getByText(expectedText)).toBeVisible({ timeout: 30000 }); }); } - From 64ad34e91b6abd09b280694451b8916196845b3f Mon Sep 17 00:00:00 2001 From: Lionel Henry Date: Thu, 20 Nov 2025 15:13:39 +0100 Subject: [PATCH 3/4] Remove `recover()` test as it's no longer supported --- test/e2e/tests/debug/r-debug.test.ts | 34 ---------------------------- 1 file changed, 34 deletions(-) diff --git a/test/e2e/tests/debug/r-debug.test.ts b/test/e2e/tests/debug/r-debug.test.ts index 490061398da..f6aec15f180 100644 --- a/test/e2e/tests/debug/r-debug.test.ts +++ b/test/e2e/tests/debug/r-debug.test.ts @@ -210,40 +210,6 @@ test.describe('R Debugging', { await executeCode('R', 'fruit_avg(dat, "berry")', { waitForReady: false }); await console.waitForConsoleContents('Found 2 fruits!', { expectedCount: 2 }); }); - - test('R - Verify debugging with `options(error = recover)` interactive recovery mode', async ({ app, page, openFile, runCommand, executeCode }) => { - const { console } = app.workbench; - - await openFile('workspaces/r-debugging/fruit_avg.r'); - await runCommand('r.sourceCurrentFile'); - - // Enable recovery mode so errors trigger the interactive debugger - await executeCode('R', 'options(error = recover)'); - - // Trigger an error: this should throw an error inside rowMeans(mini_dat) - await executeCode('R', 'fruit_avg(dat, "black")', { waitForReady: false }); - - // Confirm recovery prompt appears and frame selection is offered - await console.waitForConsoleContents('Enter a frame number, or 0 to exit'); - await console.waitForConsoleContents('1: fruit_avg(dat, "black")'); - - // Select the inner function frame - await console.waitForConsoleContents('Selection:'); - await page.keyboard.type('1'); - await page.keyboard.press('Enter'); - - // Confirm error message appears in sidebar - await console.expectConsoleToContainError("'x' must be an array of at least two dimensions"); - - // Check the contents of mini_dat in the console - await console.focus(); - await verifyVariableInConsole(app, 'mini_dat', '[1] 4 9 6'); - - // Quit the debugger - await page.keyboard.type('Q'); - await page.keyboard.press('Enter'); - await console.waitForReady('>'); - }); }); From c20e3655c363d2c1204299ee417aa217e3d3656e Mon Sep 17 00:00:00 2001 From: Lionel Henry Date: Thu, 27 Nov 2025 19:55:13 +0100 Subject: [PATCH 4/4] Bump Ark to 0.1.219 --- extensions/positron-r/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/positron-r/package.json b/extensions/positron-r/package.json index a0db7f3dfb2..36a54533225 100644 --- a/extensions/positron-r/package.json +++ b/extensions/positron-r/package.json @@ -928,7 +928,7 @@ }, "positron": { "binaryDependencies": { - "ark": "posit-dev/ark@feature/read-srcref" + "ark": "0.1.219" }, "minimumRVersion": "4.2.0", "minimumRenvVersion": "1.0.9"