Fix failures in sql.reserve() connect shadowing real errors

fixes #778 #923 #944 #1028

Author: porsager

src/connection.js

@@ -381,7 +381,7 @@ function Connection(options, queues = {}, { onopen = noop, onend = noop, onclose
   function errored(err) {
     stream && (stream.destroy(err), stream = null)
     query && queryError(query, err)
-    initial && (queryError(initial, err), initial = null)
+    initial && (initial.reserve ? initial.reject(err) : queryError(initial, err), initial = null)
   }
 
   function queryError(query, err) {

src/index.js

@@ -204,9 +204,10 @@ function Postgres(a, b) {
     const queue = Queue()
     const c = open.length
       ? open.shift()
-      : await new Promise(r => {
-        queries.push({ reserve: r })
-        closed.length && connect(closed.shift())
+      : await new Promise((resolve, reject) => {
+        const query = { reserve: resolve, reject }
+        queries.push(query)
+        closed.length && connect(closed.shift(), query)
       })
 
     move(c, reserved)

tests/index.js

@@ -445,6 +445,14 @@ t('Proper handling of null Errors', async() => {
   ]
 })
 
+t('Ensure reserve throws proper error', async() => {
+  const sql = postgres({ socket: () => { throw 'wat' }, idle_timeout })
+
+  return [
+    'wat', await sql.reserve().catch(e => e)
+  ]
+})
+
 t('Login without password', async() => {
   return [true, (await postgres({ ...options, ...login })`select true as x`)[0].x]
 })